Received-SPF: pass (google.com: domain of linux-kernel+bounces-110488-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Elad Nachman <enachman@marvell.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: Taras Chornyi <taras.chornyi@plvision.eu>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "kory.maincent@bootlin.com" <kory.maincent@bootlin.com>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "przemyslaw.kitszel@intel.com" <przemyslaw.kitszel@intel.com>,
        "dkirjanov@suse.de" <dkirjanov@suse.de>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v2 1/5] net: marvell: prestera: fix driver
 reload
Thread-Topic: [EXTERNAL] Re: [PATCH v2 1/5] net: marvell: prestera: fix driver
 reload
Thread-Index: AQHaeur1JZLk7MSy40+/riWFv1ZU97FBPlOAgAEzX5A=
Date: Thu, 21 Mar 2024 17:22:01 +0000
Message-ID: 
 <BN9PR18MB4251367BBD2F9EB77679E91DDB322@BN9PR18MB4251.namprd18.prod.outlook.com>
References: <20240320172008.2989693-1-enachman@marvell.com>
 <20240320172008.2989693-2-enachman@marvell.com>
 <d02e6c38-042f-416e-b5c8-96dc55e1fd5f@lunn.ch>
In-Reply-To: <d02e6c38-042f-416e-b5c8-96dc55e1fd5f@lunn.ch>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?ChtzwnMIVLt4y7o+Gp7WbKSpKjxGx6eVocqdRyf+knwc74UXKx7PH3yFIkca?=
 =?us-ascii?Q?wTDVEsxRCy34m+ZKay+V8IBEi49Yo20iifzw9UzRrQ8u2Lf0i5+osa7L24e4?=
 =?us-ascii?Q?/NCquymRho+rJocWz9RYrRo73wQQQF/mxzSCroUHLWU57S/rU1auzG9kIwrn?=
 =?us-ascii?Q?xI3p/GuR1cEXpNT1qq2ZLkqtU++JUhtXgkVibWtHbWcocp1Z9qpnesJFmwdj?=
 =?us-ascii?Q?Q7z2OgztiTl2flC8lfgF3lMEPdKyAtXKgzrm/jMi+Htqdk/fdbKlm/2ebU5W?=
 =?us-ascii?Q?/7R8Q+8oLqVa7nhdrUny7bwIxb0AEmNh03KAcM+8S2UeDDLQeDhr2BE46xIU?=
 =?us-ascii?Q?hhaJVWnNkuQEz9WmKN2e38TK4tHO85u9oBAfaG5+xVYO1HfohFZlQb0ChHfy?=
 =?us-ascii?Q?zcguWUI5b8KmLRCu8y6/OrBf+KAQ3wNFnQJwxGERgKiYF6ln+bZuehOd/4NE?=
 =?us-ascii?Q?v/fLmxZ7h6ReE5zn7fZJAtIKw+0b4hggtNx4HG0S22XBwU1PBRKj3MqWPsnK?=
 =?us-ascii?Q?YsfD90XraRJmH0QoW+bdhFa82WVWSRWnXwo8u4FKtK87hyeOHOJtpf+K2fbU?=
 =?us-ascii?Q?2c0MQ0MRf20Ey4CW68TxZfUMNDiLmSiwYgv12xE954Ju/ZbD1bj0QMDPxWFP?=
 =?us-ascii?Q?hUVC1sGBnNLROswxmPodl1akTTWIxRueuO3KbldsWXSJbV5TEcG4AOdDrA+M?=
 =?us-ascii?Q?IwHkB+BLJchaIrJPpOQGEOgU1LBqv3Kx+3oinvKbV9/pwVcHr+znb6lvA/7y?=
 =?us-ascii?Q?vzKAbU7BiodlQdDpzt/WIjH+YU1l9/vJpEd03VyE3HT95/p3QP5HoJz9YuC/?=
 =?us-ascii?Q?Buboq2aqrOoRLa+h8MW5p/VPTUAY4aULRixfyg1wr/tHuRO7jhHImtJc4gyM?=
 =?us-ascii?Q?wDu4fn+K1QbPanQY5jIssdGcr6NkEG7afJHbD25YuYNHojNcm0Edrp+IEKev?=
 =?us-ascii?Q?7duGZ6KddOIMupQUFT56Zkv2hSIfrpYqSVV0dDyXr4VVnKgdHEZRqKRWJk26?=
 =?us-ascii?Q?QLB9z2l3tU5j6JOL3kGCfCpKcXm0Swf+08vW5mXIPCJpPzCMm2Sxl0XO6auU?=
 =?us-ascii?Q?B3/TKEnDh/CDlLqSB8SIsQCyGOn4alKWJr7o8F4Wv+7LxkP2rspz26J6MSB7?=
 =?us-ascii?Q?xu6b3YNT5V1bfKVrnNMlP9a3E0Ze3cNLkIaf1/oTR2s5uW1M981meQK+Ca/Y?=
 =?us-ascii?Q?0FUKbFpMBuIF0Ij6SjXRErxYL5VUeWi2z+WkX5etnaWGQ/X7Kqua8wCLNpYJ?=
 =?us-ascii?Q?9d+vAdtt7LoETMdIyk+IZlPJdPHpI56RvJxJtvaJ8VB06bmj1ZgB9CPz10lC?=
 =?us-ascii?Q?hPFLWUW3RqQRzj43gYQaSfj2tOQnMMOrTp3P8rWMgnXd2x4ZRdVOtxeWp8KO?=
 =?us-ascii?Q?kBLYG4kuYwrOuDiz/ZuMHz4RR+PLJdua64yGUIHv70OtkWMn7qiTVpH30YU2?=
 =?us-ascii?Q?8vnQrHJzE6nIZmhNgbD6PEm6dcCo+Fwqqy+Fj3AyMzNd7Y0EP+pNs71jN+Cp?=
 =?us-ascii?Q?slO1z6qiiLLljjSb8QL2TdOApRzs9mGIXEgZ9t/N3kxEhX0EaHB+OZwrt2QD?=
 =?us-ascii?Q?g8JsYtLWBeDiorYp7jKSeThnCM2bzeb7iTzftyEG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4251.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4dea6cf-b98f-421a-ed60-08dc49cb6bd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2024 17:22:01.6162
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fSqfTmD+mgsv8HtYmqstc9bWAgxGl0fjMGq0yLeKMMeHe++WZ/UdV/ouft6KPneA1rtW1CPtdl+o7dPq4I9r/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB5018
X-Proofpoint-GUID: _CH7fYfE4rqG9p1XX7yn23NWFPjvxFNg
X-Proofpoint-ORIG-GUID: _CH7fYfE4rqG9p1XX7yn23NWFPjvxFNg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-21_10,2024-03-21_01,2023-05-22_02


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, March 21, 2024 12:58 AM
> To: Elad Nachman <enachman@marvell.com>
> Cc: Taras Chornyi <taras.chornyi@plvision.eu>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> kory.maincent@bootlin.com; thomas.petazzoni@bootlin.com;
> miquel.raynal@bootlin.com; przemyslaw.kitszel@intel.com;
> dkirjanov@suse.de; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] Re: [PATCH v2 1/5] net: marvell: prestera: fix driver
> reload
>=20
> Prioritize security for external emails: Confirm sender and content safet=
y
> before clicking links or opening attachments
>=20
> ----------------------------------------------------------------------
> On Wed, Mar 20, 2024 at 07:20:04PM +0200, Elad Nachman wrote:
> > From: Elad Nachman <enachman@marvell.com>
> >
> > Driver rmmod after insmod would fail because API call to reset the
> > switch HW and restart the firmware CPU code loading procedure was
> > missing in driver removal code handler.
> >
> > Firmware reset and reload is needed as the firmware termination will
> > make the firmware loader change its state machine to the firmware
> > loading state, and thus will be able to load new firmware, which is
> > done at the beginning of the probing of the prestera_pci module.
> >
> > Without this reset, the firmware loader will stay in the wrong state,
> > causing the next firmware loading phase in the probe to fail.
>=20
> What is missing from this is an explanation why you need to reload the
> firmware at the next re-probe. That just seems like a waste of time if yo=
u have
> already loaded it once.
>=20
>     Andrew

Unfortunately that's how the firmware loader on the firmware cpu state mach=
ine works.
There is no ABI interface to verify which firmware is already loaded, and t=
hen supporting
Warm boot reading of the values back to the kernel.
Since many of these firmware binaries are secure-boot protected, upgrading =
is very tricky.

Elad.