Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp634732lqp; Thu, 21 Mar 2024 10:48:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCURvi2abFUS/5fEaV+u8Voqs3JMq6kICb0GAWwBZLkw+zPkNZqKAAQb4kNbl3a7qXh9/jzjfe5BJjUgCi2HuVsDIzu1C5Zzq/CZmQ8UYA== X-Google-Smtp-Source: AGHT+IHgIwfmAWjOOEdA2HxxYe99npb2Vuz9p+wme8haWlVE4cg0svgy2O8jqdi5OhBAbTKBbezS X-Received: by 2002:ac8:5442:0:b0:430:c757:45ba with SMTP id d2-20020ac85442000000b00430c75745bamr5153402qtq.27.1711043321928; Thu, 21 Mar 2024 10:48:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711043321; cv=pass; d=google.com; s=arc-20160816; b=y5fYMGvE8adiJbVHxhaoLR7fH/hGr3ci9WvKHFZuswqn6/T9WEPssKUy8Ne86fDjtH kLVkIlVWDBL7gxdbk/5A4F19HOTz3AjOBvhQzNrLH0jH/mBBeqaSRlbP+dlEO155E3Fe hWKn5oen49puRxRITF21wLRSGvhbJ5S3Z85EK/XfTouBxHVtnlzu2WpjGDPoiseZBdbB EZF+w/SU/9B25bAfk0eJeU7mHUIsXQmEJg3jgdRp3BVRD8OizAeOsYpLFTzd/OkdGdhm iFoqeyx005vonSip9Q6h+fo4UIuYR/fm1Yq2s7kcZ6YvGtucqpPMUtqKJzOVuTJOlSCg QUAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dZklAdxeTDHOPKaVTO8lyzp0Uh81/7ghkcv66PECnyQ=; fh=ajoUvUBPSVRUDV7elHg55EjDpIme1WnNxSidUEX6orU=; b=a/rmorerqKA6eyDd6jlJ5sSFHCngpmFhFhv6X7t7PobAMxPh3AEn0a372gE28d2x3F xJRVJB7J8197JO+e3AByNWXHKj0RMgW2hC3s1p3QjxzPzh6nIVZ4xy6RZW6wQ2azmlJn Ds3mJq1PicaMYtcKHmiYzLfc3xwnQWnFVJ69vt77r07mtPSIwV4dH7NNCOGBFwjfcEFq 5cid6IVXovGYP71M9Os/d8gqVbgyOAnQ90s5kbbgUV8O4BjGrBQtUiEQb53/KmOPZypj ehmLMs4CcnmxhLcTTsHxv0N8scfI7yWCCQ2HW42y7+I6rAL8G7B2MYiDSbrZHhxzHHbZ te2Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FlSypDNW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110519-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110519-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d1-20020ac85ac1000000b00430cb71cad6si206678qtd.384.2024.03.21.10.48.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 10:48:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-110519-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FlSypDNW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110519-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110519-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9F1581C21834 for ; Thu, 21 Mar 2024 17:48:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D5A13132C1F; Thu, 21 Mar 2024 17:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FlSypDNW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09A08C0A; Thu, 21 Mar 2024 17:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711043314; cv=none; b=Mvhh9Y5a1S+GpgKpI7efqpTvgdiReX3LlwMEQgI0976/hNtgAghtbNv7i/uaeubViyt9so8IL2mD41vyhmb/gZ3wU/UP4aOqrpxVz9Z9jKneyytRhmLmXjJRtzMFGX9jo+l7vGMdI+A7O/t77aC4cQBU1TFOM1OWjvJOuv5DfQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711043314; c=relaxed/simple; bh=+JJX9o8lHqOEwaTZe7QvwxLg0SJmmcEplHy7GcPD31E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hbaflprv1PywMdNeMENHcZSdMmhTOG5DGrkxLy5MRvJz/NWDqXOlLb5yOYnewb6t2yagL2NT8KsqiOyJ0jwBHFfnJAM5kGsJB8VVWy1WjQgELpP9j5NrrpHb8hc6G0DenZ1IAJZaOzg0WR/Gcaq/wlOcWtMEdjYLxRGIVgs6Uac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FlSypDNW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D774BC433C7; Thu, 21 Mar 2024 17:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711043313; bh=+JJX9o8lHqOEwaTZe7QvwxLg0SJmmcEplHy7GcPD31E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FlSypDNWg4UbypzYgQIEx/rQjsTmJspj0zuhylQdzBW8gEc6ICcf0MI2A5SfNtg6D q6Fxs30BiXA7HEUWKxO2vQxwFtz7AdkIRnexjIrdaU+rsnIS8De2tHXCwkaOtECCUP T9M2wFcHR6Z1ancQsCPlJ/FXFYVoT5QnCyXm++trAXTu8/b+UKDMG5sDI6Jg42/wR5 /z8hvOUMUvki1+bgIedQaoRsS1omPEsWyN9uuaNKCbrFRZ8LkitNr1qIdV08ERTbTY tf1DXo3PAqcsCMmI8UliyKrbQiRNIUoBVedO08pwofCOpi0itKWFsUOfKwdZcKvIfO TzVGGDJHwDp/w== Date: Thu, 21 Mar 2024 17:48:28 +0000 From: Mark Brown To: Karel Balej Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Duje =?utf-8?Q?Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC Message-ID: References: <20240311160110.32185-1-karelb@gimli.ms.mff.cuni.cz> <20240311160110.32185-3-karelb@gimli.ms.mff.cuni.cz> <20240321154211.GA13211@google.com> <20240321162045.GC13211@google.com> <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk> <45079e37-dde9-4310-a112-7af49f35ac77@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rI0a4HK4N/lO0HZ9" Content-Disposition: inline In-Reply-To: X-Cookie: MIT: --rI0a4HK4N/lO0HZ9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 21, 2024 at 06:32:03PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T17:17:40+00:00: > > Do they both genuinely have the same maximum register? > They do according to the downstream driver which is my only reference. > In fact, there the driver defines the configs separately for each regmap > but with the same values. This is a downstream driver - are you sure it's got the best code quality? I'm not seeing any references to registers with numbers as high as the maximum register that's there in your driver for example. --rI0a4HK4N/lO0HZ9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX8cusACgkQJNaLcl1U h9DRAQf/b2vXpWtTSOuxP+Jv459OplttogJWu185FKj94bmbQTuuhuaSmwLDekNj 92G29am26hhKJ9BRHfwVnXC0v9iaMWTG1wJzTHPxUliYixd+CJ9IfvqHAMsVaHUS 9gLj4wqhQSDGNqh93KXWzzttpVeCGO9cRmq3A5cfucZuAAjpEN47AZHBAZPv5s2f SMdYd3oFoBARmvyzgfaUZaPp8wu9IAh2jcNrFQnB1z6Vx4Ym4ouIAKkTd32aHIo8 OPrrgL1g0cDtSAineggjPO/chFFkKHCtkHTVa4OTC715yLS8YCoKEJ3FRxXW6L41 bZWlnVDLAkDFXUPLNFUHsNwomu4rug== =48cj -----END PGP SIGNATURE----- --rI0a4HK4N/lO0HZ9--