Received-SPF: pass (google.com: domain of linux-kernel+bounces-110501-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Elad Nachman <enachman@marvell.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: Taras Chornyi <taras.chornyi@plvision.eu>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "kory.maincent@bootlin.com" <kory.maincent@bootlin.com>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "przemyslaw.kitszel@intel.com" <przemyslaw.kitszel@intel.com>,
        "dkirjanov@suse.de" <dkirjanov@suse.de>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v2 0/5] Fix prestera driver fail to probe
 twice
Thread-Topic: [EXTERNAL] Re: [PATCH v2 0/5] Fix prestera driver fail to probe
 twice
Thread-Index: AQHaeurjPmANQMrOHkqJdwxY/uh+37FBVLMAgAEesYA=
Date: Thu, 21 Mar 2024 17:33:40 +0000
Message-ID: 
 <BN9PR18MB42517F8E84C8C18078E45C37DB322@BN9PR18MB4251.namprd18.prod.outlook.com>
References: <20240320172008.2989693-1-enachman@marvell.com>
 <4104387a-d7b5-4029-b822-060ef478c6e3@lunn.ch>
In-Reply-To: <4104387a-d7b5-4029-b822-060ef478c6e3@lunn.ch>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?y2r91s3cvzRLsqfR03qeCPa6iyQpNHPqCBJvzPleSPrlydnHb40K05s+uo7X?=
 =?us-ascii?Q?+Odv2kiVHceZflI/dmtLiBTOlZdYdsAXWXXzF/v7vwGkNFw0t2995k8vb9mg?=
 =?us-ascii?Q?4VgBiLFefkMhnUN2xVf7f9coUR32GvvwqS4kGGSQneUHU+N+13ilqR/uhTW/?=
 =?us-ascii?Q?Er4f532yAjHl/Oab4uYWoYyRmYsZ+0BI6V5oilX5f2wyUEucl6UknZkzraSF?=
 =?us-ascii?Q?3CkXGr+82wzNGeZ2Mk1QpKMLzzT12sRJLMgCum6C8QsDGEoqhNzeDIkLk5NV?=
 =?us-ascii?Q?HMCzCpaN5paa43fu/J42Z7T2TiRCikj8H9ObsWgVRVEich9Rln1U9UZQjlDu?=
 =?us-ascii?Q?nTIjQN1pW+Dtpv2a3mitRSszUfWg1AqZMALshSCu3p87bUduXrEn2qZ6Ax0M?=
 =?us-ascii?Q?hVkESeH3/oi9wKrYwZBlMRkYwj4Ja7WBnQ5WX4pyUI2CBAnxzpqbdStOtcn7?=
 =?us-ascii?Q?x1m/2I5fa83/JJtyx37wNTH946FYHAbWCJARCndy57Etm8Ik0AawWnHX5K1D?=
 =?us-ascii?Q?FUDSvxdPptq4E9sIxxAlx77SL7HnjrNTH0JpseS2yXBikEPsdoeICMgWDXdZ?=
 =?us-ascii?Q?xd1o6/9byykr8YxCUOvoAxs3F7k0rk2cUCAooI9uDsuH5mW86HNj3MvXRZnJ?=
 =?us-ascii?Q?yXghdT6lcGAePFET1ojg1oH99BjXELNhyHlxAg1rdCyZbAVFg87bJRIX6NjE?=
 =?us-ascii?Q?FJ++tt/4vlCgRRTp2TTmZN75bodqk0RH0hA9su7Lb3Jizbq/akY+ub1eZusX?=
 =?us-ascii?Q?hR0/FE2qbAwJz9cH0Gc5b77pIXyWhRyQKP+wo+e+hXTeFzBIEbP5CbvBy+La?=
 =?us-ascii?Q?CbcbFVVgcY03Vg7ssRzPwh9h+h5S/UpJjbb8JJmHR061WaynZTW8tRnkleCQ?=
 =?us-ascii?Q?HXHuysVCVvZGB6K/LNQkRy1/AECQFKFqMYS+yJlNzLm9tTJ8M2Ksvhol946Q?=
 =?us-ascii?Q?vbflMoGq5vLsJnHhdo1lt7TnBpgywlnQnUdfpV6iMK2nJdj9wNLYjC+sasRU?=
 =?us-ascii?Q?KWzXsMbfBuA7GU6ecN9sRl1Bg8vmieHVouGUGjT6EkM7WjwXwCrpwOnZZkq5?=
 =?us-ascii?Q?eEiM5WPXD6Xg8mVUqn5HiQwMzYpQuv8Pn5EftZSQW6WJa8OUz/IBJ2dToyEw?=
 =?us-ascii?Q?9ls2na8iDVCARg9PZXOzQmLOqd1Wph/nXykR21qPfgEvXg3N8lyN1A/nWiUA?=
 =?us-ascii?Q?Dmbf2PePQE81EsDz2knp00rRQ1SKMFr/YFo3GkxLHtDEWe3fyNMTS9wDUhKf?=
 =?us-ascii?Q?98YcgruCvrIyK0eN4246wfj4G2QvTc3BoD44S+xmxGKa81dL95IBEPGuBFqH?=
 =?us-ascii?Q?nGFFi9FywiDyBvtjAE39amEjzk/SS4n/GAoNnOitLcS5PMoFRNm1zfF2i5la?=
 =?us-ascii?Q?KBq01/kKhqZtD+SpAWRm1hcHfG748uHisu1vD+3xp+gyxnOFMbaSuXCv84rS?=
 =?us-ascii?Q?5j6qSBR1sQWSCOl5/vYMkm7Di1W1zxxy2mgxeIQv5wMDujyPEavvBC8VBiv0?=
 =?us-ascii?Q?q9PMytSQAh+MbmsRIwMRwsvZInNffnGO9oIgP2dLgT2I/AsMHjOvQoQyon7J?=
 =?us-ascii?Q?cUbsByuV0Um3qSnwnh5tJ0A6Rb1rKUjwWmcsEK5j?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4251.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 230e22e4-f82a-4b21-5317-08dc49cd0c23
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2024 17:33:40.0280
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H9JcGwTTuXCDObXYDpmWP5aWKaiKMzTtvAp5a29wSZ/9Zi2VeQajt9yjcHk8eJ/VmktZaoVxlNspxvk4vjMBMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4730
X-Proofpoint-GUID: 6LlCd1BncpSu-zxjLPEdtkctNRdXaowk
X-Proofpoint-ORIG-GUID: 6LlCd1BncpSu-zxjLPEdtkctNRdXaowk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-21_10,2024-03-21_01,2023-05-22_02


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, March 21, 2024 2:18 AM
> To: Elad Nachman <enachman@marvell.com>
> Cc: Taras Chornyi <taras.chornyi@plvision.eu>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> kory.maincent@bootlin.com; thomas.petazzoni@bootlin.com;
> miquel.raynal@bootlin.com; przemyslaw.kitszel@intel.com;
> dkirjanov@suse.de; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] Re: [PATCH v2 0/5] Fix prestera driver fail to probe =
twice
>=20
> Prioritize security for external emails: Confirm sender and content safet=
y
> before clicking links or opening attachments
>=20
> ----------------------------------------------------------------------
> On Wed, Mar 20, 2024 at 07:20:03PM +0200, Elad Nachman wrote:
> > From: Elad Nachman <enachman@marvell.com>
> >
> > Fix issues resulting from insmod, rmmod and insmod of the prestera
> > driver:
> >
> > 1. Call of firmware switch HW reset was missing, and is required
> >    in order to make the firmware loader shift to the correct state
> >    needed for loading the next firmware.
> > 2. Time-out for waiting for firmware loader to be ready was too small.
> > 3. memory referencing after freeing
> > 4. MAC addresses wrapping
> > 5. Missing SFP unbind (phylink release) of a port during the port relea=
se.
>=20
> I don't see any problems with 3-5. Maybe post them independent of the fir=
st
> 2 and they can be merged.
>=20
> Are you really saying it is impossible to determine if the hardware is in=
 the
> boot loader waiting for firmware, or is running the firmware?
>=20
>    Andrew

Originally, the pain point for Kory was the rmmod + insmod re-probing failu=
re,
Which is only fixed by the first two commits, so I see little point in subm=
itting 3-5 alone,
Without fixing Kory's problem.

The problem is not with the hardware, but with the existing firmware code o=
n the
Firmware cpu, most probably secure-boot protected, which lacks the ABIs to =
report to
The kernel what is loaded, what version, what state, etc.

I agree that with better original design, we could have made a better work =
of avoiding
This lengthy reload, but at this point, I believe my options are quite limi=
ted here, unfortunately.

Elad.