Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp638992lqp; Thu, 21 Mar 2024 10:57:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUADGB15FKTFL4JZXgMnAcj/Z+eGSTKiHw3izopJ8JipgafLxNSeUlvEZlixb5U9JeTsVI1QHg0iDiquU6yksz1Dv8ideL9+yBDrLEqhA== X-Google-Smtp-Source: AGHT+IF0D2THGbfmLbbHJovxfSj8lhEMoODQUK5ulFPB7vChJrS6u+adGiw+ez6GDPXbm4Z5+Goc X-Received: by 2002:a05:6808:201f:b0:3c3:9e8a:fc20 with SMTP id q31-20020a056808201f00b003c39e8afc20mr3472582oiw.54.1711043823038; Thu, 21 Mar 2024 10:57:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711043822; cv=pass; d=google.com; s=arc-20160816; b=L0vLw3GhWJCwmAya0MjG2Hjl8jYXhftD0xs59VYiO2TZRLLbvJ4OdQTtKppu5oLxG0 XAyuIxY+ZO1KCr379YTwJgDxfDt8lc+Z84HT7plo7DfR4zYK3xnwYdFg2WpUlQUvy3br IvCkWvFbsgKwYYYj8sXVzyENBYi3+PNFaJ4roxBsLm9mYTl9rgcUomenwWNl8QOv0D52 biK+dxJ5mvX1WMGLjTYCd3hJfqS1mx14dRIFLs45duf4EpdEQ1JNvFb5XF8EmSmsuZ58 aMmcTDCc+aoPex1wllDH587BNPMy1jbLysgRqVprzKpqN2II2Jp/P5jULwb2WGc5hzJl oc4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7/Vr7UGZFgfY5hiZbZVagMHjl3VeIKITw0zb4mGRSdw=; fh=Y50HDBPCfUT7SSvUUogizqGjzVMgbet10vuCSTW2UDQ=; b=s1eiasmxKihOzPb4AIY6y8xbCA++UKIUnFj+PMD4Zk/VOnwVpBHnujITyKv1ajjwsX TVcS/+Fv+LqX8Oqt2bERwbRohutIat89RVPOE00hqpcm0djD51I25ESWz4LxLIFx6Ix3 Iday5lwrnyF6Rkg/4IXYOkv/4Vdrh94WNuxRESj8jMw7bcoU79dunq716WCEHedYdvWI t7c/doJFfHE7ePxcUOCTDo3IA8tdKeRmqR4Cfi42Gjb3Zn5WJAHATWZGNPnUwlfti12w xJzuPlHCtXlSVUpcpt0Xx9nRQEYpBZP+Rtav1qAN1Hv3+cXrCpN1giRHbn5c1Bu4AUWw mO7Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=zCyF18DF; arc=pass (i=1 dkim=pass dkdomain=resnulli-us.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-110257-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110257-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id v8-20020a63b648000000b005e8428f86efsi224206pgt.275.2024.03.21.10.57.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 10:57:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-110257-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=zCyF18DF; arc=pass (i=1 dkim=pass dkdomain=resnulli-us.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-110257-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110257-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 26DB6B2564E for ; Thu, 21 Mar 2024 15:40:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 145D98665A; Thu, 21 Mar 2024 15:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="zCyF18DF" Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A304386ADB for ; Thu, 21 Mar 2024 15:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711035320; cv=none; b=o/9Wo+a+eEmmW410atbQPeCAM6pTP+t1pmkXoBhIJbgdgxTlgROUsSDFwLOoo68xpZxLfHyPifJeZOOz9ptPZdIKum8STQb/Y+yzB37mex/+84h99k7zTyhXFBczoVb5WRWZAhYDoIcLSqMbMBoBf7MRe3+PFPB3SnCkb/+ODKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711035320; c=relaxed/simple; bh=7/Vr7UGZFgfY5hiZbZVagMHjl3VeIKITw0zb4mGRSdw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oKFEPgVuSZsJPPEyiIciNedfdMcTSNRj5ArZB5CTSrPM+8MvYIWBKPCSBja1ZR7iEKsZ3z5L5d1s07GWLDdX+rSQAO1IxhYB8prl3ClZNWqy/SvYiMHUXY4F6VsT4LN7ALSDzoLNlWwiw3MGl1+w/ebguOJ9XcLbVyelWscjNJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=zCyF18DF; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a470c79ef7cso155533366b.0 for ; Thu, 21 Mar 2024 08:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1711035317; x=1711640117; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7/Vr7UGZFgfY5hiZbZVagMHjl3VeIKITw0zb4mGRSdw=; b=zCyF18DFXr31m/24zPy4vHD0iVUXK/iO3DFdA+PsRBeOnabwqpwQZrSrqXFNLntlWj YdpGS2H4cq0aZtqGlfu0Dwqn0Be7UQ6OfvOAWkYHJqLFGpMfZLiiwtN7oNdOFV52hnxO v22ae/TBDNPTQ2Z9nq+MDnhRZxKkKLpSTr5HB4tgq9vmtJ11+Wku1Sn53OjHYtYWmtsD D6DFom5lcCNMTPSHD84mhxpVJWDElwzv8nSpNujgS0nt2eDW7BxA+9aTGrYHUQT/kz+e qzrAkupnUu/IRQIshLWaZN/nY+4yDnPw2W+oiPPnku4+VrX9Ma673TspLhmb31dKUO+M ZTSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711035317; x=1711640117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7/Vr7UGZFgfY5hiZbZVagMHjl3VeIKITw0zb4mGRSdw=; b=G8yRBojNOJMZ1avxiGqQDx+biH4kWDr2UaL8C/h9SToDRtSl6EipkWs2ozVpVr2DN9 knHuDHIniBAyFW8v4jzP3crhIf9ndC+wQQB2Db0BicYRH5T0hQAqj6XRgOHozcpZ7ZSh u91jZl89JBq67cEtgyp14S5JDC1kBCtuRxOVerUxmdkVjaa0FD9BvW5UNMBG8WrcdEI0 kFT0/ry52Xcq1AILPGk+05pWvsoXg5Y5bQjBE7jjji5eZ1/GohW/CcabJp9EhtLEwLm4 UrqWLlk+2IbAFLKsxvM0sTLZF+d6gIX2Sxldua1tuzPcbGXwvrfAsXrdS49Clj0u7pnt tQCA== X-Forwarded-Encrypted: i=1; AJvYcCXzYeESj2hxjD0aQPtRmEMFpDVOpdZqAIElfe5UasKsxs/sMuRHQ2FQNH0HjJpLcX8rMsf+TpGvoFczsiaKCrX0bW1ngJnv5JhuA0xe X-Gm-Message-State: AOJu0YwEjm8+PRQ1SwqMR5il0eiwOkC5vpwlkPGMJIa/kwnwvsctW5L7 9VaPTEEsZVG/RK2K1jo8xJ3qxSvbnfIYDZmBqztgW3mrvoV3azHun7d19sa+smQ= X-Received: by 2002:a17:906:590c:b0:a46:a85d:de81 with SMTP id h12-20020a170906590c00b00a46a85dde81mr2754941ejq.12.1711035316755; Thu, 21 Mar 2024 08:35:16 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id w1-20020a1709067c8100b00a46a04d7dc4sm40922ejo.61.2024.03.21.08.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 08:35:16 -0700 (PDT) Date: Thu, 21 Mar 2024 16:35:13 +0100 From: Jiri Pirko To: Dan Carpenter Cc: Ido Schimmel , David Ahern , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Petr Machata , Kees Cook , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 net] nexthop: fix uninitialized variable in nla_put_nh_group_stats() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Thu, Mar 21, 2024 at 03:42:18PM CET, dan.carpenter@linaro.org wrote: >The "*hw_stats_used" value needs to be set on the success paths to prevent >an uninitialized variable bug in the caller, nla_put_nh_group_stats(). > >Fixes: 5072ae00aea4 ("net: nexthop: Expose nexthop group HW stats to user space") >Signed-off-by: Dan Carpenter Reviewed-by: Jiri Pirko