Received-SPF: pass (google.com: domain of linux-kernel+bounces-110571-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 21 Mar 2024 14:48:44 -0400
From: Frank Li <Frank.li@nxp.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com,
	marex@denx.de, manivannan.sadhasivam@linaro.org,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com
Subject: Re: [PATCH] PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI
Message-ID: <ZfyBDBGizGwiQvgs@lizhi-Precision-Tower-5810>
References: <1710906338-4596-1-git-send-email-hongxing.zhu@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1710906338-4596-1-git-send-email-hongxing.zhu@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LcyOxTG5YhSeYLkDw4pIeBUiWuVr8pCvsoud9ASYmboffJZpiSZ8pJQ4ZFhu?=
 =?us-ascii?Q?/zPl6NCzRbEDwbl3JoGIr3xZJBshSWTMg+HJZjBwngDD4SwmIjhG+iJ6Nz8H?=
 =?us-ascii?Q?n6yQuEXkWdRrsLP3LQ8Z7NpTNB/tMMAAQ3TQsFgIWJ7D7++4xXIS1I2DChX5?=
 =?us-ascii?Q?TzbsdlGdbaRILbwWzFAU6fTIsdI8NBZTonfD0MGERAPfjOBEAfBwzwiYnHSh?=
 =?us-ascii?Q?qETogrvg8p0QNtX91aWKHDrZg/xNuOJFx0YI5JH4zcAKeNTMa1cU4er3wRj+?=
 =?us-ascii?Q?SDfDDwUvxD02jOOuBNY3QL+mHakJLHjGDgqfbhBmrr+nntYs0M2nm6S0sc33?=
 =?us-ascii?Q?Dq5MJdMM3hneMv81mNMwmiBfnVQ2KGAGbItUXjTAmw4fG7KbNaNqIXqnyykE?=
 =?us-ascii?Q?+hx20lJynfDzbZZkGQGpIQKLEQjadRkfynCfgKt5sFRobMouFASLMyjIlGJ9?=
 =?us-ascii?Q?NzGgvQUCRRWQ5TC+j18BvIcL+molgRAqY0Qmx4hApmt+Pg8v3yvYvynXva8q?=
 =?us-ascii?Q?et6OfDVFezg1B1s6E/4QL9bT9f+tLmSHSQ3QQnhqnT+Ub5D0EoSdlUM2jRpx?=
 =?us-ascii?Q?+MyRInsQuY3BJx8dI4PpGmfmHiUY9DHozAciOQ6fgR+9cCJthF1usIQdJyw5?=
 =?us-ascii?Q?79+QAYjxoQ1z9IJ/wHvQpThUQ5/ZXAjuVaVjF70hud3kGzKgru/fXKYp7cL/?=
 =?us-ascii?Q?Mdab3jciDJorgJOPCZST1rMBwAOBYIOywfhAp5+MpSzQOKheZu+qAmgmUM74?=
 =?us-ascii?Q?wYQwpf+g6l0KDskio93nlRSjxsD4jIKYT+hLeMNTnIImuxAw0GipMIW24bsE?=
 =?us-ascii?Q?cgomJ0q8YYYid3iR3sqUe7O57qoXWaE1qPl/p8sIlFKjWgB6zyV3BMq00ePH?=
 =?us-ascii?Q?iYdxVBAKVdBf+H+g539vTnmKV6Eh16zY43gET5oNKnybub96yUVmoZgldUkv?=
 =?us-ascii?Q?ffSYKjTAh8cW4AmrNObYnWID7DCGg7JEZbI6RmroJqlkNf8OBedQpcJOsBfu?=
 =?us-ascii?Q?yVWVyEZUtXbtbc5/dOCzLYMXMCVOn5B+q6lJhH3TP0Ag13jcoQCPMEy9UYOM?=
 =?us-ascii?Q?M2YFQJ+l7EcZMj0MdBJBjWr1jSF5JLR3y/bIJ5Rsq6HF5g2WAfp92jiUp5d4?=
 =?us-ascii?Q?ApI5lYn+0FrVBis5A1t3XqLYj2SKKfCYyJIcHrb75KQ2bk72FiNM9NcuxxjT?=
 =?us-ascii?Q?2wazKnZd5KRdJcOYotkOGUL+WA/z1fH9YzFpJJBl0zL8T8RKJgdZinGQIZUI?=
 =?us-ascii?Q?g4MZ1hTBpbsIhQ0EmmKLlcyyB+ziNayDmpDhS/941gd85IB2PAW7J49n/XbS?=
 =?us-ascii?Q?2J1XWds/y19WgEOgdDWJXRjrzZsG2Q14Lcsm9eO3Gtac1nFziw+1i7Zc7Nfv?=
 =?us-ascii?Q?TETj4h5gl3r0tnF0AfPpK3JmAu5fLi65fQbpQ+ElY9ooKncv717R9V16+Khd?=
 =?us-ascii?Q?iTs1qMixf7CrILnbaQ3x4M89jUVbSKe+/Eit35KLl4cbRv+5/mHUCTh+CHeu?=
 =?us-ascii?Q?srZnUVMij0eokMAJFyrDuyak1mUEFveNm8Yi1rj9i5Lbe9JhM7Nk0fDppt5H?=
 =?us-ascii?Q?fBfNZNfBkAyMRb9UShk=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a40d7fe8-d48b-4160-cb8d-08dc49d78e0b
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 18:48:53.1131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3kVPKoLCRxxN1OpjoMvx6b/5kE/QIgf1KSqcxDj2VDjLsv+h/hEVHcLqE9bIiipWMv1prpJJ60XccS/vVIBTpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7065

On Wed, Mar 20, 2024 at 11:45:38AM +0800, Richard Zhu wrote:
> Fix i.MX8MP PCIe EP can't trigger MSI issue.
> There is one 64Kbytes minimal requirement on i.MX8M PCIe outbound
> region configuration.
> 
> EP uses Bar0 to set the outboud region to configure the MSI setting.
> Set the page_size to "epc_features->align" to meet the requirement,
> let the MSI can be triggered successfully.
> 
> Fixes: 1bd0d43dcf3b ("PCI: imx6: Clean up addr_space retrieval code")
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> Reviewed-by: Frank Li <frank.li@nxp.com>
> Acked-by: Jason Liu <jason.hui.liu@nxp.com>
> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 99a60270b26c..3238b63721bc 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1013,9 +1013,14 @@ static void imx6_pcie_ep_init(struct dw_pcie_ep *ep)
>  {
>  	enum pci_barno bar;
>  	struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
> +	const struct pci_epc_features *epc_features;
>  
>  	for (bar = BAR_0; bar <= BAR_5; bar++)
>  		dw_pcie_ep_reset_bar(pci, bar);
> +	if (ep->ops->get_features) {
> +		epc_features = ep->ops->get_features(ep);
> +		ep->page_size = epc_features->align;
> +	}

I suggest in imx6_add_pcie_ep()

	ep->page_size = imx_pcie->drvdata->epc_features->aglgin;

	it should be set before call dw_pcie_ep_init().

If you like, I can add this fixed to my patch serial to avoid conflict
https://lore.kernel.org/linux-pci/Zfm720fz9NE0fD%2FP@lizhi-Precision-Tower-5810/T/#t

Frank
 
>  }
>  
>  static int imx6_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
> -- 
> 2.37.1
>