Received-SPF: pass (google.com: domain of linux-kernel+bounces-110576-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 21 Mar 2024 19:00:24 +0000
From: Mark Brown <broonie@kernel.org>
To: Karel Balej <balejk@matfyz.cz>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Duje =?utf-8?Q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
	~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC
Message-ID: <bd4e96b9-1026-469b-9884-073cde1f39dc@sirena.org.uk>
References: <20240321154211.GA13211@google.com>
 <CZZK759UU6G7.MFPYOI0HBB6I@matfyz.cz>
 <20240321162045.GC13211@google.com>
 <CZZL3MNOT0QG.2WDSNX9XD2RET@matfyz.cz>
 <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk>
 <CZZLDK79D5VK.2VK3X59OHIY2Z@matfyz.cz>
 <45079e37-dde9-4310-a112-7af49f35ac77@sirena.org.uk>
 <CZZLVS3T3QIS.223XHI5OZ7UBG@matfyz.cz>
 <e9c7bd38-49cd-44c2-8842-292bc0b4205f@sirena.org.uk>
 <CZZMTZBZ5S7B.2HR8A6LEY08D4@matfyz.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gbeioFqnXp7Lrcpb"
Content-Disposition: inline
In-Reply-To: <CZZMTZBZ5S7B.2HR8A6LEY08D4@matfyz.cz>


--gbeioFqnXp7Lrcpb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 21, 2024 at 07:16:43PM +0100, Karel Balej wrote:
> Mark Brown, 2024-03-21T17:48:28+00:00:

> > > They do according to the downstream driver which is my only reference.
> > > In fact, there the driver defines the configs separately for each regmap
> > > but with the same values.

> > This is a downstream driver - are you sure it's got the best code
> > quality?

> No, that is why I have rewritten it and tried to improve on this. But
> like I said, it is my only reference. Is there some other way to verify
> this value (besides perhaps the datasheet)?

The maximum register is whatever the maximum register we know about for
the device is, the datasheet is generally a good reference there.

> > I'm not seeing any references to registers with numbers as high as the
> > maximum register that's there in your driver for example.

> Indeed, I have performed the same check with the same findings. But that
> doesn't necessarily mean that the maximum should be lower, no?

> Do you have some specific modifications of my code in mind regarding
> this?

I would expect that if you have two separate register maps they would
have separate configurations that describe the corresponding physical
register maps, as far as I can tell this driver is just making up a
maximum register number.

--gbeioFqnXp7Lrcpb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX8g8cACgkQJNaLcl1U
h9AxBQgAgjcW+ImZ11bySq1bHwmyQL3Ncx+yP1+3gBzqnuQjU8YLtueCjwMzPOlK
DbH6rty6I5az2zxFLRGUn0iF10RlH2GsTNMKvsaO4VkkpGg6q9M7l1bI/EwPmmx3
DTYt2m4HSfa3Rxx3C4LuwyC+RXuN960pv3Vf07QREno2432fAYdoa+dpC0Uw71fO
jgvvr73JuQ+xEJmibUrfOO98Fq4wXKrS93vKNMWDoA+ANoAZX+jeQat5CA/Z3cQV
S7Xt7nhAAxLYwlYfehh6WTLGNWHhPA6g+nb4x8yd+GjinffbDRB9cQPfMuMPSR1M
W/9QuiLVtbR3MSk0SbqfseCTjlmf8w==
=houc
-----END PGP SIGNATURE-----

--gbeioFqnXp7Lrcpb--