Received-SPF: pass (google.com: domain of linux-kernel+bounces-110585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Thu, 21 Mar 2024 20:24:59 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	John Allen <john.allen@amd.com>
Subject: Re: [PATCH 1/2] x86/microcode/AMD: Add a patch revision number union
Message-ID: <ZfyJi2xFbxqyNR/G@gmail.com>
References: <20240321120548.22687-1-bp@alien8.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240321120548.22687-1-bp@alien8.de>


* Borislav Petkov <bp@alien8.de> wrote:

> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> Add a structure which will be used to split the Zen generation of
> microcode revision numbers into its corresponding elements. This will be
> used to match microcode patches a lot easier and obviate the need for
> a equivalence table.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: John Allen <john.allen@amd.com>
> ---
>  arch/x86/include/asm/microcode.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/x86/include/asm/microcode.h b/arch/x86/include/asm/microcode.h
> index 695e569159c1..c1de0a6aefbc 100644
> --- a/arch/x86/include/asm/microcode.h
> +++ b/arch/x86/include/asm/microcode.h
> @@ -47,6 +47,18 @@ struct microcode_intel {
>  	unsigned int			bits[];
>  };
>  
> +union zen_patch_rev {
> +	struct {
> +		__u32 rev	: 8,
> +		      stepping	: 4,
> +		      model	: 4,
> +		      __resv    : 4,
> +		      ext_model	: 4,
> +		      ext_fam	: 8;
> +	};
> +	__u32 ucode_rev;
> +};

s/__resv/__reserved please?

Had to look twice (ok, I'm lying, had to look 3 times) whether it stood for 
'reserved' or some source of 'revision' / 'reservation' thing.

Thanks,

	Ingo