Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp692557lqp; Thu, 21 Mar 2024 12:32:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXaoMbunH/f2TdEDeR+nms/uBdzniRweIPCvhVGDIVxYOrd3VwATR8NbG5oG+CUEeopzkw07j3BAYt7Oq2lws/QbHFypLHwB9ixify1ow== X-Google-Smtp-Source: AGHT+IGksS8KyDqsJbt+NmAy7arTSDhKE1WQWqrQGpnmM5v3gWIIlIl8uu1yPRUgwjtWiuZOYCTN X-Received: by 2002:a17:90a:fd01:b0:29e:5ed:ead1 with SMTP id cv1-20020a17090afd0100b0029e05edead1mr315771pjb.1.1711049550668; Thu, 21 Mar 2024 12:32:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711049550; cv=pass; d=google.com; s=arc-20160816; b=BbtcJxx8IOMdLXg3msOZ7mg4kDUhrnzGoaMXmnw17/Dvm7ciEU+MIpmqJnnMhiPTR4 tt5u/y5l8/B71ZpqlUAUGNQTJ9jXCS5tt2IkmnMQHSVo5J94djBNhRBB+1UJSQdmS7HU hKZdxp+j+Jjgf8sJbaOjHjM3nuV7zezx3aJFAfthZvxuwYV/0/n0UQm/7pfGxQs/9p6q xksVlUQsCcJM0u2IoykMcovf8JWzCiDFKHF2/KPwnrBQ894ymtBoXIAiRW5bI2ZsVP1B CO43gHcl+QZ8kcgfeH5i9FmRZIdf8p8oYIHaNsnPST/xx6LamBStnkCfl9z3fteWz+9K MKHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RkMIcVyJBPNmrP3i9RZqC7EKeP38W9cL9a+3Pjk0aZE=; fh=ajoUvUBPSVRUDV7elHg55EjDpIme1WnNxSidUEX6orU=; b=kf+5udcrQDRY03LbeAxMM4e2DxOe3/WJLSfuc5ynFkzvsveyrPyWMrMTIJrKBacK7J NztzQGoAgRkBQD3L7bUMmTwC4XQLpDEYuK05/QabW6Ib+ntzVmhWwmapaOzlThUcuDhh +5RzSaXotH6gcalGNQe8sc/N67vls+3hkXUJ/gsj/vuLX+GAyz2cQj+E7vG/b5+UQIWF hXt9pLn4Tk3i9nDj/kEMGK3rpOFpRN4B9S6Lx0Yle0xp97fXkNnOyO+5QaTMaZGP3G39 1TpAqp4RJSJ08h+EMPdQIh0fm1ORl/dO/vdV/WWeb9zQXprdaC0j/hVPSi28Re3Wh38e Dvzg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PrcQiucb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110589-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 91-20020a17090a09e400b002a03864ce2bsi11835pjo.171.2024.03.21.12.32.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 12:32:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-110589-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PrcQiucb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110589-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id CBDA5B21416 for ; Thu, 21 Mar 2024 19:32:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E799F134428; Thu, 21 Mar 2024 19:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PrcQiucb" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F8C133413; Thu, 21 Mar 2024 19:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711049538; cv=none; b=PTrN4PgyF67APtr0HKHLyI//D5I1a5NBrG1/9I6oMpSNWWdSJ5nk0JeaMzR2pDHBRuuuMJwUPc044aTKh2qfv1hhUUvJWLA6auuFDDz7qv1HTThtBI4zX+7MKiSvrRfq3e5wVgSTTVfXOmNPzE/uGwlhyjoqGc/j0bAfgXCE/+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711049538; c=relaxed/simple; bh=RkMIcVyJBPNmrP3i9RZqC7EKeP38W9cL9a+3Pjk0aZE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tJ8Rzsa6AmTbT2n9dCkpB0lZaMlHg3CqUTDHkTrWx4qPMYgHlJwsJVvnXx3Ft4CBziz8adDSarE07vgVQML8cItKguZICUca0wtXj8KxMnokt6B5C4IED2yR6UGH1b/bhFJq/ardlC/BlNXLveoo23Qh3owYTinSAIzWLcSQ01g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PrcQiucb; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A137AC433C7; Thu, 21 Mar 2024 19:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711049537; bh=RkMIcVyJBPNmrP3i9RZqC7EKeP38W9cL9a+3Pjk0aZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PrcQiucb3Na9xyPrmXC9TSX4UDaxP+7U1soYBdyjR2HCre3PRWSG2s5bbynhPVg4P LEIZQULFUXBjsBH4vcTK31KyaLOGIwLoAR4qEIJmH9UzBTQ9mVWNCrS6lC6jc25tmV hNI5jHmLijs/jTuQpin2x04fCiVny0tasAYgWO7k3qboizIqL+ppr9+8ekLVlBIZz2 j8j2JP7bQnHS+u0wWIDG3UhvFj3ZgtEjTFN1A7dDz4JAX6Hvr5slEsJ4R2l10ZMrZM 0xufXPMba01stBnPIZExvxs0meAOo33ctzQxg/s+yeQK/dIhY0cg3ommFYC389PXAa VqJ8eKgxUtboQ== Date: Thu, 21 Mar 2024 19:32:11 +0000 From: Mark Brown To: Karel Balej Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Duje =?utf-8?Q?Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC Message-ID: References: <20240321162045.GC13211@google.com> <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk> <45079e37-dde9-4310-a112-7af49f35ac77@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lLalkpu8aLGWk2zM" Content-Disposition: inline In-Reply-To: X-Cookie: MIT: --lLalkpu8aLGWk2zM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 21, 2024 at 08:14:44PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T19:00:24+00:00: > > I would expect that if you have two separate register maps they would > > have separate configurations that describe the corresponding physical > > register maps, as far as I can tell this driver is just making up a > > maximum register number. > Alright, so I should just use a separate config for each regmap and set > the max_register value for each to whatever I can find is actually the > highest used value in the downstream code -- correct? That sounds plausible if you don't have any other information about the register maps. --lLalkpu8aLGWk2zM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX8izsACgkQJNaLcl1U h9AxyAf/ZKddewyBvi8stRYLa9VKzILgV3va7iA2wGRy5+HbwQi1sP2TV5cyvzGZ Kuervgv5gAQ2mmFT4nGVjVdRwVaoDXlgjLVZ7AyA+ST/PZj3Z7VN1h/Nu9fFIuGT 0mcWYGGCACD2/6g4hd61VVj41r/PL3ZAXLQi477azLRoZHNOGWzl8H97NY14QMW6 hJzba3tTNCoDAQJkdC7BF+OZrx42l0mvQlrttLKeZumGiU33w2yuOiMgnejfmwJN zCu4sqrftv3zzX/9q5kAvARdQJ8Tk3A7m79RrcxTZGrj7VsLBoDZ+UN+zBSeirsb 3C0TExKyX35FDNakR9pxN232X6UETQ== =3Zwp -----END PGP SIGNATURE----- --lLalkpu8aLGWk2zM--