Received-SPF: pass (google.com: domain of linux-kernel+bounces-110611-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240321181403.1365947-1-sunil.khatri@amd.com>
In-Reply-To: <20240321181403.1365947-1-sunil.khatri@amd.com>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Thu, 21 Mar 2024 15:45:50 -0400
Message-ID: <CADnq5_NbOxav2U-hK8PGnsSymqKn_xjuxGtStjuHzWu_PjfPmA@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: fix function implicit declaration error
To: Sunil Khatri <sunil.khatri@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>, 
	=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	Shashank Sharma <shashank.sharma@amd.com>, amd-gfx@lists.freedesktop.org, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, 
	Hawking Zhang <Hawking.Zhang@amd.com>, Felix Kuehling <Felix.Kuehling@amd.com>, 
	Lijo Lazar <lijo.lazar@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Acked-by: Alex Deucher <alexander.deucher@amd.com>

On Thu, Mar 21, 2024 at 2:14=E2=80=AFPM Sunil Khatri <sunil.khatri@amd.com>=
 wrote:
>
> when CONFIG_DEV_COREDUMP is not defined in that case
> when amdgpu_coredump() is called it does not find it's
> definition and the build fails.
>
> This happens as the header is defined without the
> CONFIG_DEV_COREDUMP ifdef and due to which header isn't
> enabled.
>
> Pulling the header out of such ifdef so in both the
> cases the build does not fail.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm=
/amd/amdgpu/amdgpu_device.c
> index 95028f57cb56..f771b2042a43 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -74,10 +74,7 @@
>  #include "amdgpu_fru_eeprom.h"
>  #include "amdgpu_reset.h"
>  #include "amdgpu_virt.h"
> -
> -#ifdef CONFIG_DEV_COREDUMP
>  #include "amdgpu_dev_coredump.h"
> -#endif
>
>  #include <linux/suspend.h>
>  #include <drm/task_barrier.h>
> --
> 2.34.1
>