Received-SPF: pass (google.com: domain of linux-kernel+bounces-110612-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240315091434.10622-1-dmitrii.bundin.a@gmail.com>
 <CAADnVQ+o9WQNdY2iApYMN=KnKSxnKGb6NcYzYkDD9V36Di6bCw@mail.gmail.com>
 <CANXV_XwaPOOYuAsveVbfNU4tFbw30rkX3AKrBdKzrNNsUxer+Q@mail.gmail.com> <CACGdZYLn5pokOQN-uqeaVPSOtVUHy+CGmuBduhgtV+Vft8WxbQ@mail.gmail.com>
In-Reply-To: <CACGdZYLn5pokOQN-uqeaVPSOtVUHy+CGmuBduhgtV+Vft8WxbQ@mail.gmail.com>
From: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Date: Thu, 21 Mar 2024 22:50:51 +0300
Message-ID: <CANXV_XzktootzRkRSWVCgBTUOdS5eOxKZyGV3w+uMYO1uAavKg@mail.gmail.com>
Subject: Re: [PATCH] tools/resolve_btfids: Include linux/types.h
To: Khazhy Kumykov <khazhy@chromium.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>, LKML <linux-kernel@vger.kernel.org>, 
	Daniel Xu <dxu@dxuuu.xyz>, Viktor Malik <vmalik@redhat.com>, Alexei Starovoitov <ast@kernel.org>, 
	Andrii Nakryiko <andrii@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 7:56=E2=80=AFPM Khazhy Kumykov <khazhy@chromium.org=
> wrote:
> I'm also seeing this, on clang.

I think the error is more related to the libc version. I updated the
libc6 to 2.35 and noticed that the <linux/types.h> header is included
indirectly through <sys/stat.h>. The relevant sample of the include
hierarchy for <sys/stat.h> with libc6 v2.35 looks as follows:

 /usr/include/x86_64-linux-gnu/sys/stat.h
. /usr/include/x86_64-linux-gnu/bits/stat.h
.. /usr/include/x86_64-linux-gnu/bits/struct_stat.h
. /usr/include/x86_64-linux-gnu/bits/statx.h
.. /linux/tools/include/uapi/linux/stat.h
... /linux/tools/include/linux/types.h

The <linux/types.h> is included on the latest line of the sample.
Starting the version 2.28 there's an inclusion of <bits/statx.h> which
was not presented in 2.27.

When building the resolve_btfids with the libc6 version 2.27
<linux/types.h> is not included through <sys/stat.h>. The include
hierarchy for <sys/stat.h> with libc6 v2.27 looks as follows:

 /usr/include/x86_64-linux-gnu/sys/stat.h
. /usr/include/x86_64-linux-gnu/bits/stat.h
 /usr/include/fcntl.h

To avoid being dependent on the inclusion of <linux/types.h> at some
other place it looks reasonable to include it explicitly to bring all
the necessary declarations before their usage.

What do you think?