Received-SPF: pass (google.com: domain of linux-kernel+bounces-110699-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <de9358c7-4ec4-4966-a5e9-16e38b0b9500@intel.com>
Date: Fri, 22 Mar 2024 10:40:20 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 025/130] KVM: TDX: Make TDX VM type supported
To: "Yamahata, Isaku" <isaku.yamahata@intel.com>, Binbin Wu
	<binbin.wu@linux.intel.com>
CC: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>, Paolo Bonzini
	<pbonzini@redhat.com>, "Aktas, Erdem" <erdemaktas@google.com>, "Sean
 Christopherson" <seanjc@google.com>, Sagi Shahar <sagis@google.com>, "Chen,
 Bo2" <chen.bo@intel.com>, "Yuan, Hang" <hang.yuan@intel.com>, "Zhang, Tina"
	<tina.zhang@intel.com>, "isaku.yamahata@linux.intel.com"
	<isaku.yamahata@linux.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <5159c2b6a23560e9d8252c1311dd91d328e58871.1708933498.git.isaku.yamahata@intel.com>
 <f4961c6d-aa67-4427-bcc7-17942b5f1a9b@linux.intel.com>
 <20240315213638.GJ1258280@ls.amr.corp.intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240315213638.GJ1258280@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WERaR3Y4MmZyK0duMnB4UG5rWTVXeVdaWmdETGtPUEJ4M2c5WTFlWkFDTTh4?=
 =?utf-8?B?V3Rib1huZjAvbStnWHFTbXh1UENRMFkreXdvZWFTU2NCbVd1Qk9xZVBReHFa?=
 =?utf-8?B?aHBKTUdPUTJwS0xwaEdJT3VuT1FWQnczWlV3UjhxektEamliVEtKQzlRajRU?=
 =?utf-8?B?THhLRDUvMkk2bnpid3hSN2J1ZUt1cmVDeFU2UitlQ2t3aTAwM1JTdFVPMzVN?=
 =?utf-8?B?dUZveWVaYk1aemtEVDVoRS9yL0NNVVkwSS8vTDdYOGJTTkU1VTN4SEJOdGZH?=
 =?utf-8?B?YzBUQXdlZWYrVlJWMC91VXFtTmpnemlYNlNCN25CV1g0Mzl2YjBURC9jUEtu?=
 =?utf-8?B?R0JNNXdsZUlWUzZBRG55aWI0RkJjMmt5VDlST05MNnlmMTRjTzF2d0FEcFZP?=
 =?utf-8?B?VEhLZU1ZMTF3VmVEWVg5Z0RZWll5MUZ1RzB6bkJoOGRvbU5Edm1naEpiS29z?=
 =?utf-8?B?cDF3OERtSjJtVUxtQWt2NkdVaFhLb3JlTlJGQ21nVk5IbzMrdGEvaFVJNXAz?=
 =?utf-8?B?Qk1xNUR6dTVCV3Z4T2pYWU94a0cvRU9SMGpNb0RnYlBibGdTOGlTbkdTa2M4?=
 =?utf-8?B?RFI4M0czQkZHcmtZRFFEN3BZSjZKM3hxTExOMU9GeHRoeUVtZlBWR3p2c0hi?=
 =?utf-8?B?T2M5RXRVdlZyKzlhRFZmN1FUY2VNV2tsRy9xRktmL3RVOVREQUZWaUNVNklL?=
 =?utf-8?B?QWFmRCt3VjR2THRxUkdmenliZ29jVVJOWmhxUmhWQTZxTDJCaFA0TEJtSGxU?=
 =?utf-8?B?Mzh5d1FmNTAwL080MjE1QVJpZnZzOWdFMVpYQWtheW1MVFZ4ZnN1cGs1dXJr?=
 =?utf-8?B?cndDOC9Qd2VISjhUanJyU215MTFTa3hiVkdaUmxhM2JhMWtFeWFlVUpCSjVu?=
 =?utf-8?B?ZkJJL2pvTCtDdUNoOUxNaGppL3lMN2M4UnpCc1lrejJSMjQyaFhadXZwSitC?=
 =?utf-8?B?ZzVJWEFCd0xxNVhJNHA4L29FdVBTcHlCZ2RISU85Q3RDa1R2a3M2VEtWVUhy?=
 =?utf-8?B?OUk3c0VYMDg4RVZhTEd4M2Jtb2xDTUxKeU1peDZueERpWElZZEc0NkVHdU11?=
 =?utf-8?B?SG1LTEMzcXo5U21aU05VWDUrTUFhTGhQbC9CUmM2K2NLb1gzdk9yRTY3RTBE?=
 =?utf-8?B?QndmS3dXZTVwK2EvOG5DajVDUW9xT3VJUm91V0ZEZjdnZUdlVUliMFkzNzI2?=
 =?utf-8?B?UnIzdG5KRTN6WTBLUlpobi9lVlpkNkY5TGx6aVJCZXlkcXpLOFl3VkJ2Rkhu?=
 =?utf-8?B?Mmg0TkI3Y0o2eG5lOTE1UmN0VmdEQzZ2akVQQ2Y1eElNSkhsVm9LMExRVUJT?=
 =?utf-8?B?Uzk0VG94Vy82RFphRHlpRmo2aUZWN3p4ek53ckJCK2RVMUh5Tm9nRGJJZEN1?=
 =?utf-8?B?MWdiMGdiY0xUVktQWGZnVVlYRzFhUEtJTWZjR3FKM3RUd3NDeko0ZWI3Q0Y1?=
 =?utf-8?B?UVNTcnVmdzBuQzNpMEJNSmhYdW0wK1lYalpZUExYWXlIWUpRTXdweXordk54?=
 =?utf-8?B?WlV3czA5Ny9VMmJZNk0ycnBqZUxJTVBuY0VqTzVCbGRNcWgvT001SHlTcmU5?=
 =?utf-8?B?VjdCczA3N01sS1EwZHdDL1RFajRVUWZWb09YNUplRGRWT0JZM2tSUlltQ0l1?=
 =?utf-8?B?ZFdQUnBPcm5UNHRSVG9ncVNsaGhKenMybXkrRzllUmQxbkgwRnJsY3Vid1FL?=
 =?utf-8?B?L0dEb2R2cHZrMERQM2I4TWdDRjlmL1MvdmUzN3c1RmhGbU1oeTBmbzc1Tm0v?=
 =?utf-8?B?bUc4M3R6TjQrY3VmOXdRVE1LUEVYSjdYdW9wTmZ6V2Zmd1dOYVk4VXhXNmRZ?=
 =?utf-8?B?dmdoMWRGbUVvY29vVXlKb25UYk1DckE2K3gxaGFIWE5way90ckVZTVM3U1h5?=
 =?utf-8?B?Tkp2UDBFNGxyOFlQUTczYnovcWpsODFOUVQwemR3NXBSMEQ4emdscUNjY3ZW?=
 =?utf-8?B?dE43b1piWnJFY3p5WGpucjlQNHlnSzNydEc2NjZoVWVUcHF5aVhxYmt0VHJt?=
 =?utf-8?B?QUkxWFVhdEtsblR4cHdJb3FIT1hKbTJXWUFJVURoM25NRU4rWDNqcGR1OFZp?=
 =?utf-8?B?dkt3MHhRNStjcUNJN1ZaVGxwRysrdFR6ZVB0bkFlNE0xZHN0MFNoc3psV01X?=
 =?utf-8?Q?AumYcnLBpwkxto2NFsmVZTdfP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fbff84c5-e640-4a5b-5bba-08dc49ef888f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 21:40:31.7866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hVS2Blwcdc8WOB2agh0/WASceK2bca7j3GsZ0Ofc2AtXox6vJVqCaB2GOHN3iWV+RLS7b+iCUCZhhM8DQU3XqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4627
X-OriginatorOrg: intel.com


On 16/03/2024 10:36 am, Yamahata, Isaku wrote:
> On Thu, Mar 14, 2024 at 02:29:07PM +0800,
> Binbin Wu <binbin.wu@linux.intel.com> wrote:
> 
>>
>>
>> On 2/26/2024 4:25 PM, isaku.yamahata@intel.com wrote:
>>> From: Isaku Yamahata <isaku.yamahata@intel.com>
>>>
>>> NOTE: This patch is in position of the patch series for developers to be
>>> able to test codes during the middle of the patch series although this
>>> patch series doesn't provide functional features until the all the patches
>>> of this patch series.  When merging this patch series, this patch can be
>>> moved to the end.
>>
>> Maybe at this point of time, you can consider to move this patch to the end?
> 
> Given I don't have to do step-by-step debug recently, I think it's safe to move
> it.

Even if you have to, I don't think it's a valid reason for "official" 
patches.

I agree we should move this to the end after all build blocks of running 
TDX guest is ready.