Subject: Re: [PATCH 10/10] x86: Unify percpu.h
From: Dave Hansen <haveblue@us.ibm.com>
To: travis@sgi.com
Cc: Andrew Morton <akpm@linux-foundation.org>, mingo@elte.hu,
       Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
       Jack Steiner <steiner@sgi.com>, linux-mm@kvack.org,
       linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
       tglx@linutronix.de, mingo@redhat.com
In-Reply-To: <20080108211025.293924000@sgi.com>
References: <20080108211023.923047000@sgi.com>
	 <20080108211025.293924000@sgi.com>
Content-Type: text/plain
Date: Wed, 09 Jan 2008 11:28:24 -0800
Message-Id: <1199906905.9834.101.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 922
Lines: 26

On Tue, 2008-01-08 at 13:10 -0800, travis@sgi.com wrote:
> Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty
> small so this is simply adding them together. 

I guess I just don't really see the point of moving the code around like
this.  Before, it would have been easier to tell at a glance before
whether you were looking at 32 or 64-bit code because of which file you
are in.  But, now, you need to look for #ifdef context.  I'm not sure
that's a win.

This only saves 5 net lines of code, and those are probably from:

-#ifndef __ARCH_I386_PERCPU__
-#define __ARCH_I386_PERCPU__

right?

The rest of the set looks brilliant, though.  

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/