Received-SPF: pass (google.com: domain of linux-kernel+bounces-108754-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
IronPort-SDR: p4GGiX6mksnr9sfUSQzMzyObBqJqHn5W8vEq7ogckftZWGWQH9OKvP1HQJIEPqGK58yz9CfDZW
 v5GjaBAS46Bg==
From: Bhargav Raviprakash <bhargav.r@ltts.com>
To: dan.carpenter@linaro.org
Cc: arnd@arndb.de,
	bhargav.r@ltts.com,
	broonie@kernel.org,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	eblanc@baylibre.com,
	gregkh@linuxfoundation.org,
	jpanis@baylibre.com,
	kristo@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	lee@kernel.org,
	lgirdwood@gmail.com,
	linus.walleij@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	m.nirmaladevi@ltts.com,
	nm@ti.com,
	robh+dt@kernel.org,
	vigneshr@ti.com
Subject: Re: [PATCH v3 03/11] mfd: tps6594: add regmap config in match data
Date: Wed, 20 Mar 2024 15:52:29 +0530
Message-Id: <20240320102229.464673-1-bhargav.r@ltts.com>
In-Reply-To: <bb5de326-899c-4c32-b9af-f1698316e5f8@moroto.mountain>
References: <bb5de326-899c-4c32-b9af-f1698316e5f8@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Thu, 14 Mar 2024 16:30:39 +0300, Dan Carpenter wrote:
> On Fri, Mar 08, 2024 at 04:04:47PM +0530, Bhargav Raviprakash wrote:
> > +static const struct tps6594_match_data match_data[] = {
> > +	[TPS6594] = {TPS6594, &tps6594_i2c_regmap_config},
> > +	[TPS6593] = {TPS6593, &tps6594_i2c_regmap_config},
> > +	[LP8764] = {LP8764, &tps6594_i2c_regmap_config},
> > +};
> > +
> >  static const struct of_device_id tps6594_i2c_of_match_table[] = {
> > -	{ .compatible = "ti,tps6594-q1", .data = (void *)TPS6594, },
> > -	{ .compatible = "ti,tps6593-q1", .data = (void *)TPS6593, },
> > -	{ .compatible = "ti,lp8764-q1",  .data = (void *)LP8764,  },
> > +	{ .compatible = "ti,tps6594-q1", .data = (void *)&match_data[TPS6594], },
> > +	{ .compatible = "ti,tps6593-q1", .data = (void *)&match_data[TPS6593], },
> > +	{ .compatible = "ti,lp8764-q1",  .data = (void *)&match_data[LP8764], },
> 
> The casts are no longer required.  Same for tps6594_spi_of_match_table.
> 
> regards,
> dan carpenter

Will remove the casts in the next version. Thanks!

Regards,
Bhargav