Received-SPF: pass (google.com: domain of linux-kernel+bounces-106126-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Mar 2024 12:40:41 +0000
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
CC: David Lechner <dlechner@baylibre.com>, Jonathan Cameron
	<jic23@kernel.org>, Michael Hennerich <michael.hennerich@analog.com>, Nuno
 =?ISO-8859-1?Q?S=E1?= <nuno.sa@analog.com>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: adc: ad7944: Add support for "3-wire mode"
Message-ID: <20240318124041.0000032d@Huawei.com>
In-Reply-To: <ZfX5jynjW4M9pvw1@surfacebook.localdomain>
References: <20240314-mainline-ad7944-3-wire-mode-v2-1-d469da0705d2@baylibre.com>
	<ZfX5jynjW4M9pvw1@surfacebook.localdomain>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

> 
> >  struct ad7944_adc {
> >  	struct spi_device *spi;
> > +	enum ad7944_spi_mode spi_mode;
> >  	/* Chip-specific timing specifications. */
> >  	const struct ad7944_timing_spec *timing_spec;
> >  	/* GPIO connected to CNV pin. */
> > @@ -58,6 +75,9 @@ struct ad7944_adc {
> >  	 } sample __aligned(IIO_DMA_MINALIGN);
> >  };  
> 
> Have you run `pahole` to see if there is a better place for a new member?

I know this matters for structures where we see lots of them, but do we actually
care for one offs?  Whilst it doesn't matter here I'd focus much more
on readability and like parameter grouping for cases like this than wasting
a few bytes.

Jonathan