Received-SPF: pass (google.com: domain of linux-kernel+bounces-105254-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>
To: Ayush Tiwari <ayushtiw0110@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
 gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
 linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH v4] staging: greybus: Constify gb_audio_module_type
Date: Sat, 16 Mar 2024 18:41:44 +0100
Message-ID: <6152476.lOV4Wx5bFT@fdefranc-mobl3>
Organization: intel
In-Reply-To: <ZfNGYSC8CDHqVPlm@ayush-HP-Pavilion-Gaming-Laptop-15-ec0xxx>
References: <ZfNGYSC8CDHqVPlm@ayush-HP-Pavilion-Gaming-Laptop-15-ec0xxx>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday, 14 March 2024 19:48:01 CET Ayush Tiwari wrote:
> Constify static struct kobj_type gb_audio_module_type to prevent
> modification of data shared across many instances, 

I overlooked these in v3... 

What do you exactly mean, in this context, by "data shared across many 
instances"? Can you please clarify that?

I suspect that by "shared data" we usually mean something different.

> ensuring that the
> structure's usage is consistent and predictable throughout the driver
> and allows 

ensuring, allowing (s/allows/allowing/).

> the compiler to place it in read-only memory.
> The gb_audio_module_type structure is used when initializing and
> adding kobj instances to the kernel's object hierarchy.
> After adding const, any attempt to alter gb_audio_module_type
> in the code is raising 

would raise?

Fabio

> a compile-time error. This enforcement
> ensures that the sysfs interface and operations for audio
> modules remain stable.
> 
> Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
> 
> ---
> Changes in v4: added more details verifying the change.
> 
> Changes in v3: added the message that verifies the change,
> as suggested by Julia
> 
> Changes in v2: incorporated changes in commit message
> as suggested by Alison
> ---
>  drivers/staging/greybus/audio_manager_module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_module.c
> b/drivers/staging/greybus/audio_manager_module.c index
> 5f9dcbdbc191..4a4dfb42f50f 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -144,7 +144,7 @@ static struct attribute
> *gb_audio_module_default_attrs[] = { };
>  ATTRIBUTE_GROUPS(gb_audio_module_default);
> 
> -static struct kobj_type gb_audio_module_type = {
> +static const struct kobj_type gb_audio_module_type = {
>  	.sysfs_ops = &gb_audio_module_sysfs_ops,
>  	.release = gb_audio_module_release,
>  	.default_groups = gb_audio_module_default_groups,