Received-SPF: pass (google.com: domain of linux-kernel+bounces-105110-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240314100131.323540-1-qiujingbao.dlmu@gmail.com>
 <20240314100131.323540-3-qiujingbao.dlmu@gmail.com> <ZfT42gzJhVd1NQzd@xhacker>
 <jtqqbpr4qeo4m5oetmmusf2hy2wy6hnpstl344p2hu62vbbqrk@tefqeoqf37jh>
In-Reply-To: <jtqqbpr4qeo4m5oetmmusf2hy2wy6hnpstl344p2hu62vbbqrk@tefqeoqf37jh>
From: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
Date: Sat, 16 Mar 2024 15:42:09 +0800
Message-ID: <CAJRtX8TV7AEC7_owA819X_NzTS9Y6WdbHED1NQZWWfTK_zYcww@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC
To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Jisheng Zhang <jszhang@kernel.org>, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, 
	paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, 
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, 
	dlan@gentoo.org, inochiama@outlook.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 16, 2024 at 3:22=E2=80=AFPM Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> On Sat, Mar 16, 2024 at 09:41:46AM +0800, Jisheng Zhang wrote:
> > On Thu, Mar 14, 2024 at 06:01:31PM +0800, Jingbao Qiu wrote:
> > > +static void cv1800_pwm_set_oe(struct pwm_chip *chip, struct pwm_devi=
ce *pwm,
> > > +                         u32 mode)
> >
> > Did you get any information about the capture support pwm controller?
>
> Instead of adding capture support to this pwm driver, I'd rather see
> support added to the counter subsystem. That's more versatile.
>
> See https://lore.kernel.org/linux-pwm/Y3aze3B6%2Fe5uWS%2FH@fedora for
> some more context.
>

Thank you for your suggestion. I will add support for the counter subsystem
after communicating with the hardware designer about the input function of =
PWM.
Do you have any suggestions for this patch?

Best regards
Jingbao Qiu