Received: by 2002:ab2:6486:0:b0:1ef:eae8:a797 with SMTP id de6csp37826lqb; Fri, 15 Mar 2024 14:19:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV1/2p/58gH19d796gRIiiO4xERiH105kRjk6fqQNwsZ9yHGrScTVtr/FS6r5JN0XNlcmqxUNIDMaP9U/hb7JohyRcRVySTul/7i3zeuA== X-Google-Smtp-Source: AGHT+IG6nd4r/Y009GkRXOIU+Dqu3+PEBUnXCST6qrGJ8m7QfX/6XGM6coCPMAICS+eCgZNkYbMS X-Received: by 2002:a05:6a21:32a9:b0:1a3:5354:490f with SMTP id yt41-20020a056a2132a900b001a35354490fmr1569861pzb.2.1710537595619; Fri, 15 Mar 2024 14:19:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710537595; cv=pass; d=google.com; s=arc-20160816; b=uR620ldEDMiYvdf9rNBZFoVfKhwPkrJgd9bUVvlipwecST72l3xEv8QpquJLExcY9R b9IF42vZ057vw5HL32Ar4AXrRRgEJAz5qDFQ0QErkCoB4AtcdBBWulTf5L3S7+VLg/AA cNkbzcmeS3fHCUF0SDyYhs36ZrxNGSWjWKCPiG38n8OkWO86DoDIVcduPBSXp1xGVKql sHJVC0cToaafSMxEUHQkAMbrVhl8NUApH9MtSo8XQj3pB1mpS+JGFKipZ5v4JIj0Jg7y 4WRxYkZpG50YT/X0PU1kVqCU699HNHWP+bT8Ewq9wMQeQbX18h/pbf5E52vkVmCq9FjL xUtg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=o1YIiWKWxJNDdSzsWJzaL07fe51Di6mSo9Y2mM7H6Io=; fh=y7wJp14XU8O1ZSjzhz8S5MYcvySTwtRn21GHO6kMwSw=; b=YZoTth8Pn7sVXRmJR7biYqZlxPDTUoYLM6J8nGM33S360m8EM/OD3bLF6ffXlIfUS9 2unqwcFM2QA7YYmbAfNLAprT5fnEAPSdPRvgoRZGMWV0/ZSSlnTHpUGsSQ+xVzHZJJwF LzmIfUgj1wq4wmb0ia7VHyRTefejlAAmxMzP387YwGDi9H7mbcKrt457vKcppzA/qbIK WvuhZoh80b1mniFnfYv8/vxDoMAvmVuueMoq20EkJEoXOQpUabqC46TpbA1il/ZEir63 +Qh0XxvbZYM4akiY88wev+8gRjmw4GoZIYMKQf0oxFiJXcaqc7vGMoHBrG7mx8rbO8jp NaWQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=b3Y4ofKL; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-104932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104932-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id m184-20020a633fc1000000b005dc498de156si3399406pga.502.2024.03.15.14.19.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 14:19:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-104932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=b3Y4ofKL; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-104932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104932-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4F9DB283D8B for ; Fri, 15 Mar 2024 21:19:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 342D554902; Fri, 15 Mar 2024 21:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="b3Y4ofKL" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BBFE1DA5E; Fri, 15 Mar 2024 21:19:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710537586; cv=none; b=m8r3x2zX4qTHrkLUKegUIt8f8eG4q3edByHmGNpkHu+LunlJwOgINzI48IMTMcr6xfpwFhbx177hAwc0qPm3bejXPv2msArLjdOsUlK9IlJVBmb+nxc5HGBS3R4o3VwxxNokRucXvSXVmw7ynt1payXseb6jVDISJYvpyYGvaec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710537586; c=relaxed/simple; bh=hHtgEr/5VMXCz8vuPkp/Mit3mZ//jYLgkBhhrYiMYJM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rkMHrRPcMYFCz1pNZ7BIf3ZEbll0C0pwNq0gkbiwidIR7201LodUhHQ/1rXlblGDJ8KhQRgF07QMMrVoZcr9QPqZD/R6UTGHW30iwkYKS5XlndYIJwwmB8YNofm/WdMtgC1tmiE2svphXNjwceKS0rCir9fyJ3iMiMQMDMrTWiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=b3Y4ofKL; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=o1YIiWKWxJNDdSzsWJzaL07fe51Di6mSo9Y2mM7H6Io=; b=b3Y4ofKLZ9KN4+FKDyOeexkEK7 ozRPcoV4wiTdmBXClQmxRHZ0NGGlWJPcAyCC2YHX1uMGzq8qGZt4vXBd1WNaCF3WCQFDd3z88gktJ 848Xkq/rVoOXc3VOISf9mQtyo3axW/LQAB36CI5cs/Aajp0UG71emubX+s2vPGLyMvnQllPyd5EB/ LrFiCPXGk5GdlT1xvKfqwDmi50pzKrFvG4zCenPj6t9AlNLD4Z3ymd4oXyNpjmVpnEKNCMNTM9TRA 0mFcmkxPmex71LMYqFbAJdvjWc76IcKuXVMZvAZ/fySLgaOZWkzUVqZhLR4o4D4f6C82hAj9S9Cuh mlNUKnSw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58700) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rlExj-00022E-2D; Fri, 15 Mar 2024 21:19:35 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rlExh-0006iE-Gw; Fri, 15 Mar 2024 21:19:33 +0000 Date: Fri, 15 Mar 2024 21:19:33 +0000 From: "Russell King (Oracle)" To: Ayush Singh Cc: linux-kernel@vger.kernel.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Vaishnav M A , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Jiri Slaby , Johan Hovold , Alex Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [PATCH v3 7/8] mikrobus: Add mikrobus driver Message-ID: References: <20240315184908.500352-1-ayushdevel1325@gmail.com> <20240315184908.500352-8-ayushdevel1325@gmail.com> <46ba778a-5966-4b99-b820-f0d047a56227@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46ba778a-5966-4b99-b820-f0d047a56227@gmail.com> Sender: Russell King (Oracle) On Sat, Mar 16, 2024 at 02:17:24AM +0530, Ayush Singh wrote: > On 3/16/24 01:02, Russell King (Oracle) wrote: > > > On Sat, Mar 16, 2024 at 12:19:05AM +0530, Ayush Singh wrote: > > > diff --git a/drivers/misc/mikrobus/Kconfig b/drivers/misc/mikrobus/Kconfig > > > new file mode 100644 > > > index 000000000000..f0770006b4fe > > > --- /dev/null > > > +++ b/drivers/misc/mikrobus/Kconfig > > > @@ -0,0 +1,19 @@ > > > +menuconfig MIKROBUS > > > + tristate "Module for instantiating devices on mikroBUS ports" > > > + depends on GPIOLIB > > > + depends on W1 > > > + depends on W1_MASTER_GPIO > > > + help > > > + This option enables the mikroBUS driver. mikroBUS is an add-on > > > + board socket standard that offers maximum expandability with > > > + the smallest number of pins. The mikroBUS driver instantiates > > > + devices on a mikroBUS port described by identifying data present > > > + in an add-on board resident EEPROM, more details on the mikroBUS > > > + driver support and discussion can be found in this eLinux wiki : > > > + elinux.org/Mikrobus > > I think this is a fallacy. I have boards that support Mikrobus - some of > > the SolidRun products do. I have several Mikrobus "click" boards. > > > > This help text seems to imply that Mikrobus click boards include an > > EEPROM that identify them, hence you make the support for mikroBUS > > depend on it. No, this is not the case - the click boards do not > > contain a 1-wire EEPROM. > > > > Please fetch a copy of the official Mikrobus specification which is > > available here: > > > > https://download.mikroe.com/documents/standards/mikrobus/mikrobus-standard-specification-v200.pdf > > > > and rather than creating something that is implementation specific but > > appears to be generic, create something that is generic with > > implementation specific extensions. > > I think you mean mikroBUS addon boards? mikroBUS is an open socket and click > boards™ are MikroElektronika’s brand of mikroBUS™ add-on boards. MikroElektronika _owns_ the standard for mikroBUS, they're the ones who publish it and it has their logo plastered all over it. > So I think > all click boards™ do have clickID support, but yes, mikroBUS spec is not the > same as clickID and thus are not mutually dependent. None of the MikroElektronika "click" boards that I have (and thus officially produced boards) have any ID EEPROM on them, so your statement is false. For example, if you look at the "relay click" board schematic: https://download.mikroe.com/documents/add-on-boards/click/relay/relay-click-schematic-v100-a.pdf you will find no EEPROM. The "relay 3" click board also doesn't: https://download.mikroe.com/documents/add-on-boards/click/relay-3/relay-3-schematic-v100.pdf However, the "relay 4" click board does: https://download.mikroe.com/documents/add-on-boards/click/relay_4_click/Relay_4_Click_v100_Schematic.PDF Now, ClickID is relatively new. Note that the mikroBUS standard dates from 2011, with v2 coming out in 2015. A blog post introducing ClickID was posted in November 2023, just some 5 months ago, so that leaves an awful lot of click boards out there at the moment which have no EEPROM on them. If what you have written assumes that all click boards have this EEPROM then you are - in my opinion - intolerably constraining the usefulness of your idea for those of us who have click boards bought over the past few years, and this will confuse users who have these older boards. "I've enabled mikroBUS support in the kernel, but my board isn't recognised" will probably end up being a regular cry from people with this. So, I think you need to consider how to support the already vast number of click boards that do not support ClickID. At the moment, my own personal solution is currently to hack the platform's DT file for the board I wish to use, creating a new variant of the platform which configures the SoC so the mikroBUS connector pins are appropriately configured. It would be good to get away from the need to do that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!