Received-SPF: pass (google.com: domain of linux-kernel+bounces-110857-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240314141516.31747-1-liuhailong@oppo.com> <20240315081803.2223-1-liuhailong@oppo.com>
 <ZflTCY-Oaxm0U70u@tiehlicka> <CAGsJ_4w0EHuAwvSFuqUsMO-bLjJwCmN_qjL6NuA043-4rgfgsQ@mail.gmail.com>
 <ZfmV0uEMgZ2Dzdnm@tiehlicka>
In-Reply-To: <ZfmV0uEMgZ2Dzdnm@tiehlicka>
From: Barry Song <21cnbao@gmail.com>
Date: Fri, 22 Mar 2024 14:28:44 +1300
Message-ID: <CAGsJ_4zC5A2K6=u6jYDmCX4YWw-2utheQZzb8pi-BezayObvKw@mail.gmail.com>
Subject: Re: [PATCH v2] Revert "mm: skip CMA pages when they are not available"
To: Michal Hocko <mhocko@suse.com>
Cc: liuhailong@oppo.com, akpm@linux-foundation.org, nathan@kernel.org, 
	ndesaulniers@google.com, trix@redhat.com, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev, surenb@google.com, 
	zhaoyang.huang@unisoc.com, quic_charante@quicinc.com, yuzhao@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 20, 2024 at 2:40=E2=80=AFAM Michal Hocko <mhocko@suse.com> wrot=
e:
>
> On Tue 19-03-24 19:09:18, Barry Song wrote:
> > On Tue, Mar 19, 2024 at 4:56=E2=80=AFPM Michal Hocko <mhocko@suse.com> =
wrote:
> > >
> > > On Fri 15-03-24 16:18:03, liuhailong@oppo.com wrote:
> > > > From: "Hailong.Liu" <liuhailong@oppo.com>
> > > >
> > > > This reverts
> > > > commit b7108d66318a ("Multi-gen LRU: skip CMA pages when they are n=
ot eligible")
> > > > commit 5da226dbfce3 ("mm: skip CMA pages when they are not availabl=
e")
> > > >
> > > > skip_cma may cause system not responding. if cma pages is large in =
lru_list
> > > > and system is in lowmemory, many tasks would direct reclaim and was=
te
> > > > cpu time to isolate_lru_pages and return.
> > > >
> > > > Test this patch on android-5.15 8G device
> > > > reproducer:
> > > > - cma_declare_contiguous 3G pages
> > > > - set /proc/sys/vm/swappiness 0 to enable direct_reclaim reclaim fi=
le
> > > >   only.
> > > > - run a memleak process in userspace
> > >
> > > Does this represent a sane configuration? CMA memory is unusable for
> > > kernel allocations and memleak process is also hard to reclaim due to
> > > swap suppression. Isn't such a system doomed to struggle to reclaim a=
ny
> > > memory? Btw. how does the same setup behave with the regular LRU
> > > implementation? My guess would be that it would struggle as well.
> >
> > I assume the regular LRU implementation you are talking about is the LR=
U
> > without skip_cma()?
>
> No, I mean standard LRU reclaim implementation rather than MGLRU.

I guess Hailong was running the standard LRU with active/inactive lists
as his v1 even didn't touch MGLRU,
https://lore.kernel.org/linux-mm/20240314141516.31747-1-liuhailong@oppo.com=
/

Hailong, please correct me if this is not the case.

>
> --
> Michal Hocko
> SUSE Labs