Received-SPF: pass (google.com: domain of linux-kernel+bounces-110927-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Michael Kelley <mhklinux@outlook.com>
To: Petr Tesarik <petrtesarik@huaweicloud.com>, Christoph Hellwig
	<hch@lst.de>, Marek Szyprowski <m.szyprowski@samsung.com>, Robin Murphy
	<robin.murphy@arm.com>, Petr Tesarik <petr.tesarik1@huawei-partners.com>,
	Will Deacon <will@kernel.org>, open list <linux-kernel@vger.kernel.org>,
	"open list:DMA MAPPING HELPERS" <iommu@lists.linux.dev>
CC: Roberto Sassu <roberto.sassu@huaweicloud.com>, Petr Tesarik
	<petr@tesarici.cz>
Subject: RE: [PATCH v3 2/2] bug: introduce ASSERT_VAR_CAN_HOLD()
Thread-Topic: [PATCH v3 2/2] bug: introduce ASSERT_VAR_CAN_HOLD()
Thread-Index: AQHae7P8YK5+vxRKhkyT7q/3TX9dpbFDK5Ww
Date: Fri, 22 Mar 2024 04:33:27 +0000
Message-ID:
 <SN6PR02MB41579FDA4C3A34A1466FF707D4312@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <20240321171902.85-1-petrtesarik@huaweicloud.com>
 <20240321171902.85-3-petrtesarik@huaweicloud.com>
In-Reply-To: <20240321171902.85-3-petrtesarik@huaweicloud.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?3hPJFcUxz/wxuF1UA5NU6cd2O3FfcYh2it0iOOF4eSG3qtzs8msEw5zMwV8j?=
 =?us-ascii?Q?+m1IZ1JYKYsmxSuv5sXltx1gO9QTtQ6OQwWEFGJkds9BW9zSpDPwq4urFFEL?=
 =?us-ascii?Q?utkqbAIuLD9qIsChS0vtxpjOPYvLWHLAYZwO96R2XICSMjQVs7w83CIUrClj?=
 =?us-ascii?Q?qCiytCbd/6F3z45IaRCTplLVGOZEhkfoLAmrRRblIdY2TCfEVYb7xDRGlEP3?=
 =?us-ascii?Q?d+nK/u1A+2vCiOeVfM7Od19hCCPGEUEgj6qckliZZ6CGQAdpAEagdYkQ2Xol?=
 =?us-ascii?Q?mPjMidW6hJE0wilseiivpgPApkS6Jj0KeKcdiLF3WLgwo01muAfXW2+ATpXs?=
 =?us-ascii?Q?mc9TDJh4YmAlWNwlnmA+pOSkTLVhOypJIokVb/LiO//PGP7D5tAZYHYuJa1u?=
 =?us-ascii?Q?1xxNFXLnDRPKn79yG1NHZ69u8z3aHttLjFypU38MqoBRoFzhmICEw9lGsosh?=
 =?us-ascii?Q?NokXAPau3FAUgsDZRftCQx5UF1434OmLUO+xAQsvKhHrTUNtSz7nAAMlKWhj?=
 =?us-ascii?Q?7jsCuUaa+T1rXAdY+jIf+gzkuzMWdEo7e4Wjl6ZWGdeItuFVtCfWZf5JtCji?=
 =?us-ascii?Q?g4G2WVrOyryYZWHsT9s7HbbPraBOo77ilwU6lYzA15OyKA2VM683FviXHLz3?=
 =?us-ascii?Q?nLytVEaAthfFAooqhy7i6ldcM4tcZBgVeVefRHRFpgR1rSmuVZPMMj7NTMU2?=
 =?us-ascii?Q?B4ZXogDNhq4pT5rBuj3JTlZfxi8qorge6U5i42Jx2a6e1/Sz5VuklNTLm3Dv?=
 =?us-ascii?Q?kY1XjBmmG3Srwan+hvSH/zFHkcAoiPjJM+WuUHi4+NxSU/kcTOEWtHaL3ewz?=
 =?us-ascii?Q?Xb4dO09m2bdjZbPMvpzqJ7ikzczStNf/pdZRrv+yqjd4HT9EYJEJC61fzT7i?=
 =?us-ascii?Q?V5f0E9ODaL4OilR41ztV4kFWu2rs+YRnVa0OORMnzhcVP531/0yhHZTUQV2h?=
 =?us-ascii?Q?T0VcG2fBEtfAChhaksc98dxQaka8PAT0eD1NkxBdKWJYQYu4S6NVmVUc/aF0?=
 =?us-ascii?Q?HwWzmk1tsw7uLfg2DYF9MPOBFda3ql0J6xTdlgrN0lW/j/7XXsIB0CwF4WxY?=
 =?us-ascii?Q?+NOyaPsJbGQoXODA1eLPbJgazSeFkv9cp+i92+j813TZVVZEesLECkBukooc?=
 =?us-ascii?Q?/BPFQiWcM/xOdKF6amwlwiiBJLR0vMsYpSbVCVjlXh5rJkmpJ1kcb+cyb+qE?=
 =?us-ascii?Q?G005odn65LARJv9Jp4qsxPN6DSqZXPBJg+IkGw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 48a961af-6a05-43bb-0171-08dc4a293839
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 04:33:27.6703
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR02MB10336

From: Petr Tesarik <petrtesarik@huaweicloud.com> Sent: Thursday, March 21, =
2024 10:19 AM
>=20
> Introduce an ASSERT_VAR_CAN_HOLD() macro to check at build time that a
> variable can hold the given value.
>=20
> Use this macro in swiotlb to make sure that the list and pad_slots fields
> of struct io_tlb_slot are big enough to hold the maximum possible value o=
f
> IO_TLB_SEGSIZE.
>=20
> Signed-off-by: Petr Tesarik <petr.tesarik1@huawei-partners.com>
> ---
>  include/linux/build_bug.h | 10 ++++++++++
>  kernel/dma/swiotlb.c      |  2 ++
>  2 files changed, 12 insertions(+)
>=20
> diff --git a/include/linux/build_bug.h b/include/linux/build_bug.h
> index 3aa3640f8c18..6e2486508af0 100644
> --- a/include/linux/build_bug.h
> +++ b/include/linux/build_bug.h
> @@ -86,4 +86,14 @@
>  		"Offset of " #field " in " #type " has changed.")
>=20
>=20
> +/*
> + * Compile time check that a variable can hold the given value
> + */
> +#define ASSERT_VAR_CAN_HOLD(var, value) ({		\
> +	typeof(value) __val =3D (value);			\
> +	typeof(var) __tmp =3D __val;			\
> +	BUILD_BUG_ON_MSG(__tmp !=3D __val,		\
> +		#var " cannot hold " #value ".");	\
> +})
> +
>  #endif	/* _LINUX_BUILD_BUG_H */
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 3779a48eec9b..8256fcdc0cf6 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -285,6 +285,8 @@ static void swiotlb_init_io_tlb_pool(struct io_tlb_po=
ol *mem, phys_addr_t start,
>  		mem->areas[i].used =3D 0;
>  	}
>=20
> +	ASSERT_VAR_CAN_HOLD(mem->slots[0].list, IO_TLB_SEGSIZE);
> +	ASSERT_VAR_CAN_HOLD(mem->slots[0].pad_slots, IO_TLB_SEGSIZE);
>  	for (i =3D 0; i < mem->nslabs; i++) {
>  		mem->slots[i].list =3D min(IO_TLB_SEGSIZE - io_tlb_offset(i),
>  					 mem->nslabs - i);
> --
> 2.34.1

This was tested implicitly as part of my broader testing of
Patch 1 of the series.  From a code review standpoint, I
don't feel very competent to recognize potential problems
in ASSERT_VAR_CAN_HOLD(), so I haven't given a
"Reviewed-by:" for this patch.

Tested-by: Michael Kelley <mhklinux@outlook.com>