Received-SPF: pass (google.com: domain of linux-kernel+bounces-110993-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Xu Yang <xu.yang_2@nxp.com>
To: Frank Li <frank.li@nxp.com>
CC: "will@kernel.org" <will@kernel.org>, "mark.rutland@arm.com"
	<mark.rutland@arm.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com"
	<festevam@gmail.com>, "john.g.garry@oracle.com" <john.g.garry@oracle.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>, "namhyung@kernel.org"
	<namhyung@kernel.org>, "irogers@google.com" <irogers@google.com>,
	"mike.leach@linaro.org" <mike.leach@linaro.org>, "peterz@infradead.org"
	<peterz@infradead.org>, "mingo@redhat.com" <mingo@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>, "alexander.shishkin@linux.intel.com"
	<alexander.shishkin@linux.intel.com>, "adrian.hunter@intel.com"
	<adrian.hunter@intel.com>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>
Subject: RE: [PATCH v7 5/8] perf: imx_perf: fix counter start and config
 sequence
Thread-Topic: [PATCH v7 5/8] perf: imx_perf: fix counter start and config
 sequence
Thread-Index: AQHadr8CiB2Brc8ylUabi+uaJoTA8rE92C8AgAV/fWA=
Date: Fri, 22 Mar 2024 06:31:51 +0000
Message-ID:
 <PAXPR04MB8829062113118B354CACCD438C312@PAXPR04MB8829.eurprd04.prod.outlook.com>
References: <20240315095555.2628684-1-xu.yang_2@nxp.com>
 <20240315095555.2628684-5-xu.yang_2@nxp.com>
 <ZfiJFj1IO67FR/z4@lizhi-Precision-Tower-5810>
In-Reply-To: <ZfiJFj1IO67FR/z4@lizhi-Precision-Tower-5810>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?iQVQEgQWHShTeM3VNfofBIIQtBEmmA+RUQNCDFUd28X9xi/AuUHchqMTxAJH?=
 =?us-ascii?Q?Wh7gxelffj0GmX9yZrbEMvy6AbbDr/ymv+TWD/ope9ffa/J7Z1MECDnqHEXX?=
 =?us-ascii?Q?9GYCe9y+8FxKxHORsYazDYN51cxMtxNaRSVRx+n8aVwb8JOVbyuot02JmZ8h?=
 =?us-ascii?Q?FK+7ciJsm+ehj/nq7BwP5xLJzuXPcjKNMjaMi5ArMZQpFDkx/+38mmAIH493?=
 =?us-ascii?Q?OzsSxOeLfa09EkMtAvdLcewr0dNde7qqbGij56LVXvni3sSgQqjEr8j6cShS?=
 =?us-ascii?Q?Av0i7dxA1Ta0ETTTLC5MNB44p4lcM2aiUbnTsp2z1v59+4eVnDaqNMVXxk1S?=
 =?us-ascii?Q?0pUQ6RmdzXQR5Lnbf61yLfgw233YIS/xdBlbH6wNgkr+RJ+eOFKCdUlApMSm?=
 =?us-ascii?Q?D6pV3BOiyP3qwXtYjQ2xv4Mju4EySRcQc3+K8MQIDwfUuiwecC1/EROZGJZc?=
 =?us-ascii?Q?hUC79lPW/jW2RNyGXj/yxP2GQa/VmxaFnAEwaoFibYTn28dxCQNHT/fIbGMB?=
 =?us-ascii?Q?WITpBtGQ7WZsy6r5+QKvNaWuoKSmOWGLffX25uSdxGuWUExVbOLH99bhnB3X?=
 =?us-ascii?Q?SnSbxlqwt1KH7xf+NTH1LyIhLLl4mvlkYMKkwnDDJdcY814L/cRVXIHOgVvW?=
 =?us-ascii?Q?Ud0Nj4CkXJ15AYnvfpC5U8iYRZgFk2aMy1XD0eLDgUuOUc0j+ka0AgVFhfn9?=
 =?us-ascii?Q?o8bQFvD6cB70GtJCn6VNCSYFS5ce5+Xmja5yV4UcY7QG0nGZD+Y7OwHqF43u?=
 =?us-ascii?Q?+PS82D4D+AqVqe940iyGUFAf3pfb+X1A0sr7q04TQtpzc7Tnh83Dx7Rf/Rc6?=
 =?us-ascii?Q?fsPnUT5UG8WDIoD8vteNIYyUbAPYZG98T3zSJP26ynfwbsTI0paq2gyU19bU?=
 =?us-ascii?Q?9HZHneZpR0J4TpzUwW6AsAO27jD9HeszV0IL84P3mQpnp+hLGQxu9XxQvBw2?=
 =?us-ascii?Q?gTIZkeXCfcabsL4rRKHi6e6Mg6o7SQJI2DjqlUdaxrd1FB7e6DBkH3xx6sKJ?=
 =?us-ascii?Q?bDh8zKIWIgzU6fwYZeENK/1H29+6rGEsApelgmg4ZjXPnaeJJbD6parBZFeD?=
 =?us-ascii?Q?jI88cxiiDInI01f2O6B/pIt2uN/z4N1SsfcdgyYt6Mo7jpUml1n1dLCVrwy5?=
 =?us-ascii?Q?RUL48+8jDm+3lnudl/QrTCHyaraSea4pjeqm2+fyhYc40msZs7BRsbbEeT9j?=
 =?us-ascii?Q?D4MAzVf8nsKuWExlzisA+G0Nd80gfiz5JuXA+j78bj8IG2i520XHVyEUY9bl?=
 =?us-ascii?Q?E6AoGK1pOvqAgulV4rapmnvuhS3V+R4LEAXFrp79oCGVngDOQVEKSweQ6csP?=
 =?us-ascii?Q?yYQxqwWilcksgZOa41KKW4cSfiQCDrNXJSre2F2pY2d+eFHR53rx0B2AeuOB?=
 =?us-ascii?Q?UnwF4DLOdsNIchaoILfHroCvM4+muxhJODSRoN6ZNfHoINWhVuwRXHnNDbDl?=
 =?us-ascii?Q?H9IFx8v9unsKnCWyB7c2ng+J/VyM2V0LxkxcT15i6miOIL6m5WnaNtx84iw+?=
 =?us-ascii?Q?oro6qxtmGQbMUOa8xswUd0ENdHDzQTVWoV0HEQkvD5a11Feu3pplNG9KDVq/?=
 =?us-ascii?Q?A0A3GQUOkpV/U/E1lI0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8829.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69a3f7ce-009c-40d8-2db1-08dc4a39c25c
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 06:31:51.4100
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BmRxFtc57aBbap76Sj6vpsKh/XxmXPY8LJJslyMJ5MaBoY3/u8/QzTAX3bwIgW9YwGh8zhHMWXojFGhc3X9UCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10007


>=20
> On Fri, Mar 15, 2024 at 05:55:52PM +0800, Xu Yang wrote:
> > In current driver, the counter will start firstly and then be configure=
d.
> > This sequence is not correct for AXI filter events since the correct
> > AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate=
.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>=20
> This one should be bug fix. Can you add fixes tag?

Sure.

Thanks,
Xu Yang

>=20
> >
> > ---
> > Changes in v5:
> >  - new patch
> > Changes in v6:
> >  - no changes
> > Changes in v7:
> >  - no changes
> > ---
> >  drivers/perf/fsl_imx9_ddr_perf.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_d=
dr_perf.c
> > index 5537f4e07852..c99c43b214cb 100644
> > --- a/drivers/perf/fsl_imx9_ddr_perf.c
> > +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> > @@ -523,12 +523,12 @@ static int ddr_perf_event_add(struct perf_event *=
event, int flags)
> >  	hwc->idx =3D counter;
> >  	hwc->state |=3D PERF_HES_STOPPED;
> >
> > -	if (flags & PERF_EF_START)
> > -		ddr_perf_event_start(event, flags);
> > -
> >  	/* read trans, write trans, read beat */
> >  	imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2);
> >
> > +	if (flags & PERF_EF_START)
> > +		ddr_perf_event_start(event, flags);
> > +
> >  	return 0;
> >  }
> >
> > --
> > 2.34.1
> >