Received-SPF: pass (google.com: domain of linux-kernel+bounces-110994-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240321180617.35390-1-five231003@gmail.com> <affc1b03-7a23-4fd8-bf85-4155bcd41df1@linaro.org>
In-Reply-To: <affc1b03-7a23-4fd8-bf85-4155bcd41df1@linaro.org>
From: Kousik Sanagavarapu <five231003@gmail.com>
Date: Fri, 22 Mar 2024 12:03:33 +0530
Message-ID: <CAN19-EdU5OPb=0Qz0_b3GxAJsjD_DAoVRrQM1+38p2SGVTAOgQ@mail.gmail.com>
Subject: [PATCH v2] spi: dt-bindings: jcore,spi: convert spi-jcore to dtschema
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, 
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Mark Brown <broonie@kernel.org>, 
	Shuah Khan <skhan@linuxfoundation.org>, 
	Javier Carrasco <javier.carrasco.cruz@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 22 Mar 2024, 11:33 Krzysztof Kozlowski,
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 21/03/2024 19:02, Kousik Sanagavarapu wrote:
>>
>> +  spi-max-frequency:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>
> No, drop. From which other SPI binding did you take it? I asked you to
> look at existing code.


Without this, "make dt_binding_check" would break though, right at the
position in the example where "spi-max-frequency" is used.  That was
also the reason why additionalProperties was set to true in the last
iteration, but after reading the doc more carefully I realized that was
wrong after you pointed it out.

I followed along bindings/spi/nvidia,tegra114-spi.yaml.

(Sorry for the HTML mail ping, I'm replying from mobile)