Received-SPF: pass (google.com: domain of linux-kernel+bounces-111004-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Xu Yang <xu.yang_2@nxp.com>
To: frank.li@nxp.com,
	will@kernel.org,
	mark.rutland@arm.com,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	shawnguo@kernel.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	festevam@gmail.com,
	john.g.garry@oracle.com,
	jolsa@kernel.org,
	namhyung@kernel.org,
	irogers@google.com
Cc: mike.leach@linaro.org,
	peterz@infradead.org,
	mingo@redhat.com,
	acme@kernel.org,
	alexander.shishkin@linux.intel.com,
	adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: [PATCH v8 5/8] perf: imx_perf: fix counter start and config sequence
Date: Fri, 22 Mar 2024 14:39:27 +0800
Message-Id: <20240322063930.749126-5-xu.yang_2@nxp.com>
In-Reply-To: <20240322063930.749126-1-xu.yang_2@nxp.com>
References: <20240322063930.749126-1-xu.yang_2@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?uj8duaSwgp0yqbdiorrpiXaBQRzShGho9/AKwEcNcIAy7fEsuJRDJOA3OlkV?=
 =?us-ascii?Q?RcO0Q94nUHUn1TNIH92Oa8MuTeeijebWSxv3J7a/QEzra2TKfTah12aB/0mx?=
 =?us-ascii?Q?8Qdcxa0LlvWDfTMm2sqL5oW/wpGIApB+zB0KWr3PgwEDmActHyFzDGz3GDQt?=
 =?us-ascii?Q?xRKHZPgHndharlfX6oXxn6NnQpXAoWHxNNURRwbibFZuvSCvI8FXJcaaut8A?=
 =?us-ascii?Q?WxascSyidtqSux8JLPUgVGZgbXp6DNe4khThsv5PlLvlJl4v9WGC9hb1SUO3?=
 =?us-ascii?Q?gyh1s8bDdNKpL8C2LQbJspxFGWHnJtJE2XrrB+aKEONkBRiGLPPRdr7r2sze?=
 =?us-ascii?Q?8NK7A361gwHAw2xrtsCST3D7Hvni1UFxAuiQb9f4H+dn69ASf7eYdhNPCU/U?=
 =?us-ascii?Q?i0uu9K+U5PQKTw2KerbDt0BUyip0WlzQDo6W9a+Hy7/xhVm8j42y8Wm+DPrL?=
 =?us-ascii?Q?MAu+4KJen1FoCNyBZHD83QWFdTdHD+itDr/G+OkRHzj75+QM3Gr6M2fqZJrP?=
 =?us-ascii?Q?zWwGNqTnmV0nLxTdPdDZvDgDQiH6LtzI7EGPt4sNDEzi5YWXsOyEZnFu8s2O?=
 =?us-ascii?Q?MR8keRL3vofJw4FN88A/5wwEViCPVl/vgi66mJHG3xX/JmnRCFpdJeFxk6Nu?=
 =?us-ascii?Q?1ZpisW8ukhK95F7MfizE35Mhp1XEnvehicaKHE3tJ/BoHZ1RaMBGwU9TyOQR?=
 =?us-ascii?Q?XNV8jo5inoKDzHNm1s2D+9rwkd2n3s8e588jqV9Fgi5VQMpz/K5yEs9M+lFw?=
 =?us-ascii?Q?vLlKSO0xBoxPV5JtMXzyQT47VUQKVoRxNYQJo598heMlvBXD8e6s7L/rziv5?=
 =?us-ascii?Q?Qv5aKlVqRFrl9B4qyHpysJhpvUMAuOCAiTF14ltcR7ozCSFFTyFIK57oEhNq?=
 =?us-ascii?Q?MB+JW3KMNZK7fo63JLR2vEvuha7zuWtCYdv6eaKf4kAM7du3z6skCiU9GLT3?=
 =?us-ascii?Q?Pwld5Vww9agsnRo5Iz4Zyah/W3MNltmCv7fODSSJnfUUYMLYys+rPoUiGm3q?=
 =?us-ascii?Q?JYAljky17oZt8nE86PTJweFtXjt+4umIbllap6HkgQCCi4vOwTz4tPPX7OuZ?=
 =?us-ascii?Q?/JZAEXjPYWkLVqKSBfdmNEqw4EFLs86d30J5ngaSxxerBCK0rqF9uKviI8sV?=
 =?us-ascii?Q?2KWHX4rS/dY5dxJ/HXNc6AIOcT8B4GcelYjlzX8Iptn1od4uCcgLhBj947CV?=
 =?us-ascii?Q?cLDfwhZnReQBbnG1rThXXWIXUsigIw8+CUfvYj1lLKYWQ/UB7m6NIHTzgV2Z?=
 =?us-ascii?Q?6q5zp1Q9jETdWdiMjTu4fzU+24t8Qgb8iXMfYqE+0f9YuHOLiGF4cu58n8uK?=
 =?us-ascii?Q?31EwW/OddzijJdkJgl/ed24lkm8XQpwm5Lae1fnl9O7/ouApQfvRsrggBb7t?=
 =?us-ascii?Q?NAbpb3XrI18LRzjnYtDAYRJbqys99ZVNM9Dubk//js4xJgsZkruF7Tfhqv+w?=
 =?us-ascii?Q?qb6aRr9Tn6Zja4JTDu+yQF3bxHB4om2JenFz0KgC5CBQ4+zUAHgzSvmgfsMn?=
 =?us-ascii?Q?ngvVrRMMxCt1vdf9jL6PAIZ9cmDq0goqKHOn/DuHlgT7FCsGoWa4jA6ViwUY?=
 =?us-ascii?Q?cEw3ZyNTLiPXb2sFHJsPN5MvZYvWix77gSwl5fQl?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 995ba2e7-54f1-4c06-e484-08dc4a3ad99f
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8829.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 06:39:40.6237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nuBRZcJFOpnaIIBFiSfU5+lyKXEyR1ZiZilN24l/cpl5HtexZax9wpTnolJB42QcGHIcWzzMiTIfQMgXFA4QqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8928

In current driver, the counter will start firstly and then be configured.
This sequence is not correct for AXI filter events since the correct
AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate.

Fixes: 55691f99d417 ("drivers/perf: imx_ddr: Add support for NXP i.MX9 SoC DDRC PMU driver")
cc: <stable@vger.kernel.org>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v5:
 - new patch
Changes in v6:
 - no changes
Changes in v7:
 - no changes
Changes in v8:
 - add fix tag
---
 drivers/perf/fsl_imx9_ddr_perf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index 011377c01dea..fab6596d3e28 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -539,12 +539,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
 	hwc->idx = counter;
 	hwc->state |= PERF_HES_STOPPED;
 
-	if (flags & PERF_EF_START)
-		ddr_perf_event_start(event, flags);
-
 	/* read trans, write trans, read beat */
 	imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2);
 
+	if (flags & PERF_EF_START)
+		ddr_perf_event_start(event, flags);
+
 	return 0;
 }
 
-- 
2.34.1