Received-SPF: pass (google.com: domain of linux-kernel+bounces-111061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: linus.walleij@linaro.org,
	brgl@bgdev.pl,
	andy@kernel.org
Cc: linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V3] gpiolib: use dev_err() when gpiod_configure_flags failed
Date: Fri, 22 Mar 2024 15:37:25 +0800
Message-Id: <20240322073725.3338266-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM8PR04MB7443:EE_
X-MS-Office365-Filtering-Correlation-Id: fc62f867-91c0-4ee8-3ea4-08dc4a41cb41
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TjcaUMgD5Fq19I2p0b3VG2EL57QJKaH/7WhhKXCrRU7HRRaHol6LAOmUqmNi62Xqo/z0Wez2hj/jJ19id4r9t8fFL8ooB963W4by4hRFxPK403HargZD2hihE/S9thOEsYYDxD9Zka+HSp6e5dHc+0DizIBngzRQDLgR42fyKpoiIMexnp7appRySMpQCvSEnDHngp1lOFumC904wAWRsbnP0s5M9H9ozbeyjC237fG7HMsifTM5YplU1fQGhpnTSN+bl6o6PZEM/Yr7Ri3HaiwTTvNbrt/i17/NE/MADXBrqaBD4tUmRi2h7JCYmPQORgGK5EqtGFWUWaVXIwaS7koLsgs62lV8ZdDWlwi6cm7mbmI16vCrJGlCAV4FYUjYFXIuUjt1Qj9rQOSfjBpmqdtXkSPFdl3R0rEZ6epejZ9Xstc9rGUiEiP7qxrxiRFm3Aubz36TORyWf3RJc0I4SZKpMpF8bN/RBhuomzUUNPc6iGChVceVp4IqIXdoPXHSfoYpogF6WWWPHuUGj2Qx4Clc5D7200mUXixs40AKo3kHRGpM+iqcJ0FifA7eRvMua3jJCXUX32KRzG6WjLEz5V0RKp+mIEO/l7xUG+QNcoz4umXNPQ8VFjbDlr0j1WdEFufLkzlHxR8XHSlJui3b/Swim9n4jdQtvU5MbRTfjiGbI3kvTHgGZq2jEiVMXv9KI/guW/EkSFQeNxOvxvcuVA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(52116005)(366007)(38350700005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mQ2KiBeMk6gjurTITW5SVpY4hLzy123JOjJAG0xlsgoY4miypWWlwPbhgF8O?=
 =?us-ascii?Q?i8JKrNuTsuDb24J7b1BuuEYRBvz9+3YVyXrzkIZ3CtVQUEQVLHbtHHqyJpf0?=
 =?us-ascii?Q?qQgBHYCnCnwKWdZG0zWAOjyA4GZ6sYx+EuTc5szOtDUjB4J/2gDDIArTjSYD?=
 =?us-ascii?Q?BHaORk1zjNvcBeHXLi101PW4QXY3znLbn9mVrDhHzdXMIKkXgbVMj67C9JBM?=
 =?us-ascii?Q?01Noy1+JdrBOf6glE1dxLC0ISt5TWAeqQWas8KEc8JGf85cm1FBxSRcK0Yz0?=
 =?us-ascii?Q?3672Z/zssPiXCiY+L96YFrpDa618Lrf3ukZWQ8lw0oNCcxMtjim7Do6fayPS?=
 =?us-ascii?Q?eQbszaeRxrF8ytoLmRMtVFJYJMqfOmd/vsxC/n/p21bqosyNgTwHpL68yG2u?=
 =?us-ascii?Q?5wSilEDdwxluQmX4mxjwrrFtTAXI5Y+JB+bhs1LewieGJ997WXl2YYAIzrpk?=
 =?us-ascii?Q?xEe3Jjoa7OEkirZXlFRyQuhukzD69+BZ7RsZ4SJe2zEdPnL8RSiNHxo150+f?=
 =?us-ascii?Q?b2tYVz//Fy65ove8AGEkbHGoiPiExOR6Q1y4GmXAphF/ikSsw6c0b0kTGz8P?=
 =?us-ascii?Q?1XTbwNsJQd/ab5/qX5a40/E305mwUB43gHCokMz2VeeHtimy8Zpj3tpKoQr8?=
 =?us-ascii?Q?NljIpZ3wN81V2Jhwh1k8nBLiUJ/sTlKYuDbcuC9v3Z7k7zk0BFlybmcp301F?=
 =?us-ascii?Q?wVcrss2Q5/ow0FmD1xYgR1IvO2UIjo8aii5bHKOMtefxEIGS/M3N/tjddbjy?=
 =?us-ascii?Q?ZIqT+Sw+NDI4igojrgb5aFmo/DxAnVS0N+GrrgD55SGzuvFKDN+CUp2Se7tl?=
 =?us-ascii?Q?omXKJ7AKd2z0UY/ikjNZ4N4fuH7faRaP+XrQckGnqV9U6JLRVf4JZk8mhIpU?=
 =?us-ascii?Q?+XfYwhuaPWNlS1YF/S65CyhiCfpcdCB0hbfOgvyyjZC/S6kic/1fnV8614br?=
 =?us-ascii?Q?G65EudYUcj6gcXr3R79uLrS9FmoVvOSIk4u4mxmnh46SHc0wfNf/SRPgIGcs?=
 =?us-ascii?Q?h01u1nov/s+6v4ah56rvnaoeNehmod/+A+hGn5sS9FUI+FKRr2no62aHguCn?=
 =?us-ascii?Q?rRb2mX89bxl92Z7dluuY523hxC/R0+rkYNdPRP663YiWr56Bd7wrOTDG56mv?=
 =?us-ascii?Q?gr2eQcDNKn+nbWzH/EbvOOcqjTERepnEtJQReFtVd7cHbbmaOYHY5fXWZx7J?=
 =?us-ascii?Q?+vp6pEpBN4GQ+BEsWE9tAWB/9u6RNknxx3gRo6fuYLaIu3yH4WMaQb2keEb8?=
 =?us-ascii?Q?/LCRSc5TtPRy+XFP67986FhquUgLv7xzMnYFuE1he+I+oiXD72aQBfkjbLNT?=
 =?us-ascii?Q?L8DuCNEnI+bu97fg27KQ+MjtwXDFLRWLbp7ecmidqezjokeE/mF0Gc9IdPwb?=
 =?us-ascii?Q?C8NSeNEck1Q6xUt+v4+3pxw/fju99a3wTPz3HxYZysrrChRvwCK1dWHU7hwm?=
 =?us-ascii?Q?xwnlXtqCFsia0QOwhNiiWOdS0VP45f8+hKDPnsY2LLdgVxxA2d1tmH5e62gX?=
 =?us-ascii?Q?XzA+5r+r5ZAUC1/aYmBY4Pu/Kcf5KGJBCBJ0D6RGxqZv5gTyjlwRTbBWl2ZK?=
 =?us-ascii?Q?AMysiUap8ASQyFpa9tgE7A9DrcRqfDyl80CT6se5?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc62f867-91c0-4ee8-3ea4-08dc4a41cb41
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 07:29:23.0703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nDoGa/WFsGFU9UkU1EmaIyRgbz95Gz4iTWjEGuijPRLRVAsT/osWttsY1iHbcxJWGJ77x20P0Hk+SIEBQ9qwYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7443

From: Peng Fan <peng.fan@nxp.com>

When gpio-ranges property was missed to be added in the gpio node,
using dev_err() to show an error message will helping to locate issues
easier.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V3:
 Move gpiod_put before dev_err per Andy Shevchenko
V2:
 Update commit log

 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ce94e37bcbee..b988704f5d63 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4233,8 +4233,8 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
 
 	ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
 	if (ret < 0) {
-		dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
 		gpiod_put(desc);
+		dev_err(consumer, "setup of GPIO %s failed: %d\n", con_id, ret);
 		return ERR_PTR(ret);
 	}
 
-- 
2.37.1