Received-SPF: pass (google.com: domain of linux-kernel+bounces-111087-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240322072456.1251387-1-gaoxingwang1@huawei.com>
In-Reply-To: <20240322072456.1251387-1-gaoxingwang1@huawei.com>
From: Jason Xing <kerneljasonxing@gmail.com>
Date: Fri, 22 Mar 2024 15:58:30 +0800
Message-ID: <CAL+tcoDiSsqhef=aAAwRP92pNv=K43UE--T_MikxpmsTchxCaA@mail.gmail.com>
Subject: Re: [PATCH] netlink: fix typo
To: gaoxingwang <gaoxingwang1@huawei.com>
Cc: mkubecek@suse.cz, idosch@nvidia.com, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org, yanan@huawei.com, liaichun@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 3:26=E2=80=AFPM gaoxingwang <gaoxingwang1@huawei.co=
m> wrote:
>
> Add missing colon in coalesce_reply_cb
>
> Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx=
 aggr params)

This commit cannot be found in net/net-next tree...

> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>
> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>

nit: two duplicated SoB

> ---
>  netlink/coalesce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c

Where is this file? I suspect you're not using the standard mainline?

> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, voi=
d *data)
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
>         show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> -       show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> +       show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
>         show_cr();
>
> --
> 2.27.0
>
>