Received-SPF: pass (google.com: domain of linux-kernel+bounces-111259-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240322073240.91639-1-yang.lee@linux.alibaba.com> <20240322073240.91639-2-yang.lee@linux.alibaba.com>
In-Reply-To: <20240322073240.91639-2-yang.lee@linux.alibaba.com>
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: Fri, 22 Mar 2024 18:57:59 +0900
Message-ID: <CAKFNMon20yyJ2Daf3nkG1A4hP=ENEnO_em4qrGm50e=A9c1++A@mail.gmail.com>
Subject: Re: [PATCH -next 2/3] fs: Add kernel-doc comments to nilfs_btree_convert_and_insert()
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 4:32=E2=80=AFPM Yang Li wrote:
>
> This commit adds kernel-doc style comments with complete parameter
> descriptions for the function nilfs_btree_convert_and_insert.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  fs/nilfs2/btree.c | 22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
> index 65659fa0372e..de38012fd87c 100644
> --- a/fs/nilfs2/btree.c
> +++ b/fs/nilfs2/btree.c
> @@ -1857,13 +1857,21 @@ nilfs_btree_commit_convert_and_insert(struct nilf=
s_bmap *btree,
>  }
>
>  /**
> - * nilfs_btree_convert_and_insert -
> - * @bmap:
> - * @key:
> - * @ptr:
> - * @keys:
> - * @ptrs:
> - * @n:
> + * nilfs_btree_convert_and_insert - Convert and insert entries into a B-=
tree
> + * @btree: NILFS B-tree structure
> + * @key: Key of the new entry to be inserted
> + * @ptr: Pointer (block number) associated with the key to be inserted
> + * @keys: Array of keys to be inserted in addition to @key
> + * @ptrs: Array of pointers associated with @keys
> + * @n: Number of keys and pointers in @keys and @ptrs
> + *
> + * This function is used to insert a new entry specified by @key and @pt=
r, along
> + * with additional entries specified by @keys and @ptrs arrays, into a N=
ILFS B-tree.
> + * It prepares the necessary changes by allocating the required blocks a=
nd any
> + * necessary intermediate nodes. This function handles the conversion of=
 a B-tree
> + * node when it is necessary to split it due to the size constraint.
> + *
> + * Return: 0 on success or a negative error code on failure.
>   */
>  int nilfs_btree_convert_and_insert(struct nilfs_bmap *btree,
>                                    __u64 key, __u64 ptr,
> --
> 2.20.1.7.g153144c
>

Hi,

First of all, thank you for posting these patches.
These three kernel-doc comment completions are necessary.

One thing I would like to point out is that the last part of the
descriptive comment for this patch is not accurate.
nilfs_btree_convert_and_insert() is used to convert configurations
from other forms of block mapping (the one that currently exists is
direct mapping) to a B-tree, and is not intended to split a B-tree
node block on excess of the number of entries.

So, I'd like to slightly adjust the description for this patch and
send all three to upstream.
Or, if you want to fix it yourself, please send me the revised version.

Thanks,
Ryusuke Konishi