Received-SPF: pass (google.com: domain of linux-kernel+bounces-111273-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <49fa2bd1-bd6e-4404-a1c7-2170d37f0194@oracle.com>
Date: Fri, 22 Mar 2024 10:07:00 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] kbuild: disable pahole multithreading for reproducible
 builds
To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau
 <martin.lau@linux.dev>,
        Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
        Yonghong Song <yonghong.song@linux.dev>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>
Cc: bpf@vger.kernel.org, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240322-pahole-reprodicible-v1-1-3eaafb1842da@weissschuh.net>
Content-Language: en-GB
From: Alan Maguire <alan.maguire@oracle.com>
In-Reply-To: <20240322-pahole-reprodicible-v1-1-3eaafb1842da@weissschuh.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?S2p4ZEx1THl2emJKRk1kbGN3L1NyZFdRVlNFWFhva3dId2lwc0tTS252Njhk?=
 =?utf-8?B?VDdGL2pZaEthdGhLWjdBZkFqZWpVQnFnbU1UWXhlZE9QU2xVMjVWUjBsRlJ4?=
 =?utf-8?B?NHV5cWJKaEdOUDJyMUhVTXZQUU9MNW9XS1lHbnd4akZkakQ4SHFCWG9TaFoz?=
 =?utf-8?B?M1J2MlNWNTdmUmU4cGNiZ3NXeTU1MTNLZ1A1Z092SWZjVmtKNy8rQkVpZFp2?=
 =?utf-8?B?S1JMemtxSlhYajNGZEFIQUM5R1VhMk4wSDRXamVpQVNoZDhobUtCTDgxVUVW?=
 =?utf-8?B?eU5mVnhXVk9tNG9rWm1VUURQYXhMS014dGF1NDVuR2NyKzk0TW1icHlJRm5K?=
 =?utf-8?B?TWdTZHROUWVKbzZ2VEhHYzgrWlduNVdiUnpqdS9uZHh1MTZoUS9SaFVNcGVv?=
 =?utf-8?B?aEJtZFp0RkhNS2ZXcGVpQVc4UXdwcklQOUJWeGtZTERsTkNmYWk1bUxvYkN1?=
 =?utf-8?B?TVhZYWFKVGNtMUIxbUtRb3VOa2k5UUJpcm9rRFVaeDNOL3VKWHE5NURpTExY?=
 =?utf-8?B?ZmpsSklxQ0oyT2UveXYzSVBGbURQRWJMOFQ0NG90YWtnaHJ4N0RVc3Y4Yk1J?=
 =?utf-8?B?cEpxUmtnS1ExZ1hUOUh6MnJGZFNBSFV0T09WWXBmZVFvUGw0TSt1MWtrS0pE?=
 =?utf-8?B?emZ5MlFQcVVrUGE2L1M1cEZ2b3J6eXdsYjZuQ3o4MGFmY1ZuT0RCd3lrQTB1?=
 =?utf-8?B?bDBLMlBLLzJJZWxONmdpNlE1ZVdvUXlRZk1ENjhUM28yWFZnK2hXVGJRMDNH?=
 =?utf-8?B?dnNuclN0Z2dZRnpXU1VKbHFORzFkWFpmeXpOdVFaZDhKekZTdmlpa0RFbm01?=
 =?utf-8?B?L2c1LzdmVkVhbmc4dXhCZTYxVUtXekJZTi9PMUpVVXR1N2JYbTJTdEZCQkRV?=
 =?utf-8?B?dityMDZqUllNdXpHdlJVMVBjOXc0Y2VLYzZBdTBUNHhrSkZKUGZrZTJGRnQ0?=
 =?utf-8?B?WGZvWUhSQlNUNkc2U0h3TytUalhCOC9VWEc4ZWJTOTFwOEExRldBK2crWjF3?=
 =?utf-8?B?NFlMTSt3NUlEdVJhOWh4TnVRRVIyS2xWMzF3cmpuTFBucWJrWnVzckgydTBH?=
 =?utf-8?B?dGdGYUlIVDk5bTBuM0lTMVR0czV2Rkk1T0k5bnNoMmIxVko4RlE4c2RlVWZJ?=
 =?utf-8?B?VlV4Q3RYVWdoaFVWQnVlVkZ0YjhuTDJVSk4xcm1zMmYwSjJLSXVCelIwT3lz?=
 =?utf-8?B?NDN3dzF4SGY1Mk9lS3oyRmNsTUsxSXBGaVFKZk5VZ0tMNTArcGE2NWg5Vk9w?=
 =?utf-8?B?djZkdU9UNElKaWNvYmRONFVHaXNBcUZrbmlIay9PbGh5VmlzckFxeGNBV0tm?=
 =?utf-8?B?cUJXOEpEMTVFOTNXMXZwR1JKLytkalY1NGlsMWdhcmpSZEJabzdHQ2hiM01H?=
 =?utf-8?B?ck1xek1hR3V4cWphaUd5dEVobUNqVjhDd3lWVTVweE5Pc2pnU1RMRW1uSlZx?=
 =?utf-8?B?Qy8xUFNBd3k5VFFBeHZxOGZsMFhXdkVKTThjWFFrOGdOejJNc2NUcDA4eEU3?=
 =?utf-8?B?dmVIN3pKTDVnVjVMeStpeWdjVjN5ZnUzMTJReHpOQUZHeGFZVmVFTCtqMmN0?=
 =?utf-8?B?Z1VrQkx5ZHhjZFhiem0zMWwzV0w5RGNHTXFTUWdycVNvMU5BSGROdGlwK3BU?=
 =?utf-8?B?MVppK3RGeThNUHRJOUlLNHlEemJRSC9icFllVzIzUVc5dEkrTVllUDhXTkdF?=
 =?utf-8?B?RkxrWUlnbzV4eEFnL0xxQU8vYkVJV3l2VDgzRmtiNXNKbWJnUStrQ1pPbDly?=
 =?utf-8?B?ODNvYmt4T1VYc21TVEV1QzA3VnRRemxkejVwM253QjBOSVh0SWtWS2pCVnNG?=
 =?utf-8?B?bG5ic3l5MHJRc1JIaFRaZ2FxQ3JOb0d3bitUN0N5eDUwTjFIWWUzUHJOYjZh?=
 =?utf-8?B?NUhmT3o3Q0Q3ZE9VNCtUeDVDSUxHUnF3U0YrbndrYko4YTBIQUs4K045bjlk?=
 =?utf-8?B?cDF0OHp2NWRxQWhaazBRdkF3eDZYZUp6MVRjQnZNK3NQelNZa0YxYTRkUGFW?=
 =?utf-8?B?TTZlUjV3d0p4TTVWKzl1Y2E4WFVrWGxtVEJtUmJ5dTVFT0NXK1draWlSWjUy?=
 =?utf-8?B?cW1DQ21uUVIxeVRsVjNPWFBvTWxscUxpbkpYMEtwcHhWS0k4cE5mckhtUTZi?=
 =?utf-8?B?MUdyWFBBWnBOb0VtSTduNXByK2ZEQXY1R3VOSHU2ay9GU2hZdzF6TEVKNXN2?=
 =?utf-8?Q?bnWoBuPH93K4fcMhy/4O5cw=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	wCyGnWtE3VdxaWZUexCi/LE/vcYg6I/2Pwr8pmaYiZOBl3x9INlGPXU/IrzCD9fuQT06+T2jLBCyJyB9k73iYfQCmQEjQ5qfRATNJASxFIXSkD6XuxQjDwusye/3C3xekAmMtzAx+iU+OONoQ95dRuoiflItHogYMxvLoEsp3MkYfATxtqpLGmd3KXMMCv3wIQ8ARh+NJsMRlJqJHaUCAjyXVZAhpDu7TJua2+LUteAOm6ElUiGzmSNd7n7i78H7p3zU5AyvZpRmToxXJ7lCbbafM/e2md5JmGKZudevEWSBLpgRLd5jOR+9OqqSAYwqguhCKQoWfFxUFhxKNeSb52THbKXzBdzsqdv5Q43iqAzWBoo/xhaPeXbt9ty784JPFgytssYMwWzJIC3Rdf24k1PSk1uGeW/kVkotdBDthFN4uK5MpoTRZy8Fe12YDfaf2YsgdIGWsT1vCEEU/L3d5uLPodhTrsaj3zi1o+WkxoB1G+sxvIIMUZ7SClSs2y9gN75YH8nXRAzdlMgAYgdullbvo5C/wiY8vin0xzXHiM0GE4QwoCKtq6B5oGk+nRrm/FbVsokA3xAy9N6HSI3kAQaPexfc4vs8hPKexhHjUyo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 358db59d-99fc-49a2-4856-08dc4a57d32d
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 10:07:04.8944
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GHZ6WfiZYIb3aW62NGU42hzbHsx1C5JNEUI03DPLYvVGrqZwdMPCp4bIsTTB0/hc0WET8E828u56cyBLNnXDug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6548
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-22_06,2024-03-21_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403210000
 definitions=main-2403220071
X-Proofpoint-GUID: m2iE9KaiCuMWarir62dTPbdkmAMso8ae
X-Proofpoint-ORIG-GUID: m2iE9KaiCuMWarir62dTPbdkmAMso8ae

On 22/03/2024 08:31, Thomas Weißschuh wrote:
> A BTF type_id is a numeric identifier allocated by pahole through
> libbpfd. Ids are incremented for each allocation.
> Running pahole multithreaded makes the sequence of allocations
> non-deterministic which also makes the type_id itself non-deterministic.
> As the type_id end up in the binary this breaks reproducibility.
> 
> Therefore, if the kernel is built reproducibly as indicated by
> KBUILD_BUILD_TIMESTAMP, disable threading in pahole.
> 
> Fixes: b4f72786429c ("scripts/pahole-flags.sh: Parse DWARF and generate BTF with multithreading.")
> Fixes: 72d091846de9 ("kbuild: avoid too many execution of scripts/pahole-flags.sh")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Yep, we've talked about sorting final BTF in various ways but until that
is implemented, non-parallel execution of pahole is the best way to get
reliabily-reproducing BTF ids. We should probably update the pahole
manpage to warn about parallel non-deterministic id allocation in the
meantime.

Reviewed-by: Alan Maguire <alan.maguire@oracle.com>

> ---
>  scripts/Makefile.btf | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf
> index 82377e470aed..2356929e62e4 100644
> --- a/scripts/Makefile.btf
> +++ b/scripts/Makefile.btf
> @@ -10,7 +10,10 @@ endif
>  
>  pahole-flags-$(call test-ge, $(pahole-ver), 121)	+= --btf_gen_floats
>  
> +# threaded execution randomizes BTF type_id allocation, breaking reproducibility
> +ifeq ($(KBUILD_BUILD_TIMESTAMP),)
>  pahole-flags-$(call test-ge, $(pahole-ver), 122)	+= -j
> +endif
>  
>  pahole-flags-$(CONFIG_PAHOLE_HAS_LANG_EXCLUDE)		+= --lang_exclude=rust
>  
> 
> ---
> base-commit: 8e938e39866920ddc266898e6ae1fffc5c8f51aa
> change-id: 20240322-pahole-reprodicible-02e904e45686
> 
> Best regards,