Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1034073lqp; Fri, 22 Mar 2024 03:45:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUQ//VBwKAjSRqDkWLxO9+q9cNVlvWjf1qgvYrNxewew3QYa96PslgHCn3Pwk4lgFcAl2rYOMXy/VZyN5bk7BhbJ8dS99IOQR5y7629Hg== X-Google-Smtp-Source: AGHT+IHz1G/IVRzhdTfm0w43S7yvbadFZ0ZgOtoDwC0UL6zMInXhDcVADy1NfIQQ4Fjl+M276qXt X-Received: by 2002:a05:6358:60cd:b0:17e:6dd9:d7d1 with SMTP id i13-20020a05635860cd00b0017e6dd9d7d1mr2063954rwi.31.1711104338815; Fri, 22 Mar 2024 03:45:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711104338; cv=pass; d=google.com; s=arc-20160816; b=r/UmJ8lFOoNWe+kU4/4OfBeQtp8XsP8oB19brg8Ejz4GnkfQ2sJHitERi39XJYFBTV cuVI4KRfvPhrs0IkGW40/YkdPihe1iDdxCxFB/3Bd3PJBaOMd2F20Mu3B2rcYqdrBl9i +PHSMAih7iqjrzScaLh/Od2tbn3t5BLr1ucUMamz4R4CajXmTogERPwCIqA+nkZtQisE 9Mi/KUZMqdsUcKPUW0Nw9y+/31JiSV5hI14oxQuILZeYm/EUYIZ7sB6NKljU/AT7avn6 Mq9GExG+ivuJydOpBMBJF8cj851z6z89xg/d3L7Z3GB3MQmposv6i0J8yOBRqFpqmGgY c+IQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=RXOvXSZ2teuejrNSvg4eVnqLQCp7+IzA+LatJX05CoE=; fh=76fY95VCn/tTPDURHIWBg4FyCkia1KFHdPTfdxMrHno=; b=npxC5q+n3/gYZUuMuvJJfqxbxVq4gROUwRQH0gHgd4IztDm0+OViuufluWblLkGIKN wsWefHAQF3NWpo9NeondgYfRXLgXnB8tS3zaeu8A3UpEn5vCmccGr+mO1NHVKniJSsv9 5uA4MCzHZ4wt6YlxGzngWcw3QUnXs6LDN6n+PO036T5LoFSx6BKBQM/CCCLWtJHuKO6J /D3X0vPT8HNtWfsRHMT0Vp81jXgzpU1gOgXnfTSiL3n/fl6wDWS8iBW0MFvNQz7F9LoR 9smhDUCG6D9s4MMrc4n3sEE2ItN8buhgqxP92fHefv8+K9xjvTsRm8RNwOzC2hg8+TaS OR6g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-111300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111300-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id g1-20020a63fa41000000b005e840aef2dbsi1819597pgk.570.2024.03.22.03.45.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 03:45:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-111300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-111300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111300-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 70CEBB2678E for ; Fri, 22 Mar 2024 10:33:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20DDD3FB02; Fri, 22 Mar 2024 10:32:45 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 21DE43A1C5; Fri, 22 Mar 2024 10:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711103564; cv=none; b=l6M9QF5gAbyciyjT+X5FjZokPNGMwMEYNPLzTQUPw67Y0xBMTY7mpJjq9zCjv1rw3/Bip7V/xDHS4vDx0sbpIO6e2/OjqTZzDMoEqqUn4DiI1sBSQMiZ5ibNURpzyGWDfS56B1OK/RKcBMaiieu7KvNeMbZ0cIlpxujFfMbrmsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711103564; c=relaxed/simple; bh=rmY1Ezl/4TLieyFpoPKm5P9cmNGH4Ej3lVmVLgRJ0WQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TCeh8RVEpIUZ/body0oZOeACHBaN+6wR9qAoAm3LHueI9agGD7qzC3RWdjR6ew3/BfyfPIPccyudONYzfpFgaEbYRcYR44v1p3Ixc1MOZa1K/oltjE9pK5JL2F4+dRswIv1ATbXgxOpFqOyzr/l6XzS3eNar613eGkiPpo5T4Fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 94EC81063; Fri, 22 Mar 2024 03:33:16 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.71.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 140EA3F64C; Fri, 22 Mar 2024 03:32:39 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH v2 3/4] PM: EM: Add em_dev_update_chip_binning() Date: Fri, 22 Mar 2024 10:32:20 +0000 Message-Id: <20240322103221.47594-4-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240322103221.47594-1-lukasz.luba@arm.com> References: <20240322103221.47594-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a function which allows to modify easily the EM after the new voltage information is available. The device drivers for the chip can adjust the voltage values after setup. The voltage for the same frequency in OPP can be different due to chip binning. The voltage impacts the power usage and the EM power values can be updated to reflect that. Signed-off-by: Lukasz Luba --- include/linux/energy_model.h | 5 ++++ kernel/power/energy_model.c | 51 ++++++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+) diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 770755df852f1..d30d67c2f07cf 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -172,6 +172,7 @@ struct em_perf_table __rcu *em_table_alloc(struct em_perf_domain *pd); void em_table_free(struct em_perf_table __rcu *table); int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, int nr_states); +int em_dev_update_chip_binning(struct device *dev); /** * em_pd_get_efficient_state() - Get an efficient performance state from the EM @@ -387,6 +388,10 @@ int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, { return -EINVAL; } +static inline int em_dev_update_chip_binning(struct device *dev) +{ + return -EINVAL; +} #endif #endif diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 6960dd7393b2d..1494a909844a4 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -808,3 +808,54 @@ static void em_update_workfn(struct work_struct *work) { em_check_capacity_update(); } + +/** + * em_dev_update_chip_binning() - Update Energy Model with new values after + * the new voltage information is present in the OPPs. + * @dev : Device for which the Energy Model has to be updated. + * + * This function allows to update easily the EM with new values available in + * the OPP framework and DT. It can be used after the chip has been properly + * verified by device drivers and the voltages adjusted for the 'chip binning'. + * It uses the "dynamic-power-coefficient" DT property to calculate the power + * values for EM. For power calculation it uses the new adjusted voltage + * values known for OPPs, which might be changed after boot. + */ +int em_dev_update_chip_binning(struct device *dev) +{ + struct em_perf_table __rcu *em_table; + struct em_perf_domain *pd; + int i, ret; + + if (IS_ERR_OR_NULL(dev)) + return -EINVAL; + + pd = em_pd_get(dev); + if (!pd) { + dev_warn(dev, "Couldn't find Energy Model %d\n", ret); + return -EINVAL; + } + + em_table = em_table_dup(pd); + if (!em_table) { + dev_warn(dev, "EM: allocation failed\n"); + return -ENOMEM; + } + + /* Update power values which might change due to new voltage in OPPs */ + for (i = 0; i < pd->nr_perf_states; i++) { + unsigned long freq = em_table->state[i].frequency; + unsigned long power; + + ret = dev_pm_opp_calc_power(dev, &power, &freq); + if (ret) { + em_table_free(em_table); + return ret; + } + + em_table->state[i].power = power; + } + + return em_recalc_and_update(dev, pd, em_table); +} +EXPORT_SYMBOL_GPL(em_dev_update_chip_binning); -- 2.25.1