Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1034199lqp; Fri, 22 Mar 2024 03:45:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXtfLY7UoZo8llOF503moOwdISFliJoJfUGOuFDynQX17CkJKw+HAkPtWOQzIXLngVurUgJGeug2GT1J7pKvO7jXNj1H33viDxJ8WgsWw== X-Google-Smtp-Source: AGHT+IHcCbbIV/MeDmBgTlKwoWuVJ9D7HuDnraR5IkNpbUmc9NvncoVcsJZQv+/+IRV+tAC8HAG0 X-Received: by 2002:a17:90b:50a:b0:29b:a4d9:b125 with SMTP id r10-20020a17090b050a00b0029ba4d9b125mr1629583pjz.30.1711104354548; Fri, 22 Mar 2024 03:45:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711104354; cv=pass; d=google.com; s=arc-20160816; b=0xaFuoh/l7mcLljh74/+i8Lv7vr1vBGu/SXEfg/3V5Wr1yGlWcc4mdPDrHq6jHtsjj iVHrFqRxDunBw9ZvvMOlw27TG9Ii33j2HW/M6m5MDx/Rq1kFbdIrZV2T2/pUWIoXSpoi bStf6gDvgdeBcCfl81p+hmWvqtCOkn12osxQibGc/xJDr6TfNMSE3tIW7xPodRTE7OC9 BAmZ3Auy7GpnBMNgyVrrXUSufvF4KnsH3bOUW0+As3gbk62a103FbRao73DvPXhiYWh2 m+hpcACpp3FsdETZIl1S2dJz76sy2hwFks/gS1AW1lhwuEgG1951OJghvHGIZ6Tm6VMS ZaYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=uFLAb0F25k8NRPb1i7faRr465nj8uyGIRN7Vrexl6dk=; fh=76fY95VCn/tTPDURHIWBg4FyCkia1KFHdPTfdxMrHno=; b=wmcqWtjkS/STDcscYMBo6fhMtzLtHk7bBUmz0vxHYw/Jk0MX9yqtxd/yz4TedLcjA5 z6q8MaxkLkmZoQD3z41YiykzmoDOE3MndBK2B68jOs8wIAqIr7cs1OaP5uHGNrQoTrIk kqPPu3eDAVFBedIvDgnL4pLMlrHD3Y7Z6BVPnddJ2CX1mVNIFKKw77xcyTE8+mlz9B2F lLaLnl/i9lChmxk85eB+nywgISYSsmgeKjheI8KKklLENHgEO3HipefSmHke+PCyYuDr 5zvUc+6eGNmsFRlrdwWtei1kVlcf3jKEWjpfs1F/Cab0MOQ4sdMHV4H3DyOPW/qrJbJz kbpQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-111301-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111301-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s22-20020a632c16000000b005e857e4fe0fsi1673867pgs.517.2024.03.22.03.45.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 03:45:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-111301-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-111301-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111301-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5D420B268F3 for ; Fri, 22 Mar 2024 10:33:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9FA313FBAC; Fri, 22 Mar 2024 10:32:47 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A85DF3FB14; Fri, 22 Mar 2024 10:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711103567; cv=none; b=JWrKYviPOoJ3DfyIwpHatn2HdZKAKgDnWxDtI+2BAmMNyHrIYMmSnW9kR5cmFPEs/ITrZCZOHfXEEOd2+672MsRdV522qHtOgU8hx5g+xXW2yguIm581Uu+Ns0BVB6HM8XORw7Zhbam0yKYzABKbsjONo6SDl/M6figgZnXulmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711103567; c=relaxed/simple; bh=mzHk+OCGnE2cjK/GID6NafKHM6xvW+nmtg17CRUaB+w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pAiVaVJ0BglYDILAMVkw1RiOjWzomuurK7YxjFP7i29t6nGU2HaG8p51jaohVKCTpUh7u5g8C9JrFvE9e0RfxGcKE4PI2diH1tQy0iRy3Oh7Y0u5uFyhnt2i5c/wfHZ76KCcKvGjylh2EDhy/ROqdWlwSjBmbl2JWP3co3qchWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D3411007; Fri, 22 Mar 2024 03:33:19 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.71.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C27C33F64C; Fri, 22 Mar 2024 03:32:42 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH v2 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Date: Fri, 22 Mar 2024 10:32:21 +0000 Message-Id: <20240322103221.47594-5-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240322103221.47594-1-lukasz.luba@arm.com> References: <20240322103221.47594-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the voltage for OPPs is adjusted there is a need to also update Energy Model framework. The EM data contains power values which depend on voltage values. The EM structure is used for thermal (IPA governor) and in scheduler task placement (EAS) so it should reflect the real HW model as best as possible to operate properly. Based on data on Exynos5422 ASV tables the maximum power difference might be ~29%. An Odroid-XU4 (with a random sample SoC in this chip lottery) showed power difference for some OPPs ~20%. Therefore, it's worth to update the EM. Signed-off-by: Lukasz Luba --- drivers/soc/samsung/exynos-asv.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c index d60af8acc3916..bd6bb2cab2cd8 100644 --- a/drivers/soc/samsung/exynos-asv.c +++ b/drivers/soc/samsung/exynos-asv.c @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -97,9 +98,17 @@ static int exynos_asv_update_opps(struct exynos_asv *asv) last_opp_table = opp_table; ret = exynos_asv_update_cpu_opps(asv, cpu); - if (ret < 0) + if (!ret) { + /* + * When the voltage for OPPs successfully + * changed, update the EM power values to + * reflect the reality and not use stale data + */ + em_dev_update_chip_binning(cpu); + } else { dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n", cpuid); + } } dev_pm_opp_put_opp_table(opp_table); -- 2.25.1