Received-SPF: pass (google.com: domain of linux-kernel+bounces-111312-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 22 Mar 2024 11:39:50 +0100
From: Kory Maincent <kory.maincent@bootlin.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Luis Chamberlain
 <mcgrof@kernel.org>, Russ Weight <russ.weight@linux.dev>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki"
 <rafael@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Mark Brown <broonie@kernel.org>, Frank Rowand <frowand.list@gmail.com>,
 Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
 Russell King <linux@armlinux.org.uk>, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
 devicetree@vger.kernel.org, Dent Project <dentproject@linuxfoundation.org>
Subject: Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework
 within PSE framework
Message-ID: <20240322113950.27d35376@kmaincent-XPS-13-7390>
In-Reply-To: <ZfxjosqPMo0ECBmx@pengutronix.de>
References: <20240227-feature_poe-v5-0-28f0aa48246d@bootlin.com>
	<20240227-feature_poe-v5-13-28f0aa48246d@bootlin.com>
	<ZeObuKHkPN3tiWz_@pengutronix.de>
	<20240304102708.5bb5d95c@kmaincent-XPS-13-7390>
	<ZeWi90H-B4XeSkFs@pengutronix.de>
	<20240321171524.0b04bfcc@kmaincent-XPS-13-7390>
	<ZfxjosqPMo0ECBmx@pengutronix.de>
Organization: bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Oleksij,

On Thu, 21 Mar 2024 17:43:14 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> On Thu, Mar 21, 2024 at 05:15:24PM +0100, Kory Maincent wrote:
> > Hello Oleksij,
> > Sorry, I forgot to reply about this.
> > This is specific to pse_regulator driver. Could we tackle this change in
> > another patch series when the current patch series got applied?
> > Also I don't have the hardware to test it. =20
>=20
> ACK, no problem.

I have a question unrelated to this.
Why do you add refcount on the pse_control struct?
The pse control is related to the RJ45 port. Each port is exclusively relat=
ed
to one pse control.
Shouldn't we return an error in case of two get of the same pse control ind=
ex?
Do you see use cases where a pse control could be get two times?

Regards,
--=20
K=C3=B6ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com