Received-SPF: pass (google.com: domain of linux-kernel+bounces-111348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <43b3feb2-8eb7-4f6d-a41b-d2d3c8893ec4@arm.com>
Date: Fri, 22 Mar 2024 11:06:55 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/4] Update Energy Model after chip binning adjusted
 voltages
Content-Language: en-US
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
 sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org,
 daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org,
 krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
 m.szyprowski@samsung.com, mhiramat@kernel.org
References: <20240322103221.47594-1-lukasz.luba@arm.com>
From: Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <20240322103221.47594-1-lukasz.luba@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 3/22/24 10:32, Lukasz Luba wrote:
> Hi all,
> 
> This is a follow-up patch aiming to add EM modification due to chip binning.
> The first RFC and the discussion can be found here [1].
> 
> It uses Exynos chip driver code as a 1st user. The EM framework has been
> extended to handle this use case easily, when the voltage has been changed
> after setup. On my Odroid-xu4 in some OPPs I can observe ~20% power difference.
> According to that data in driver tables it could be up to ~29%.
> 
> This chip binning is applicable to a lot of SoCs, so the EM framework should
> make it easy to update. It uses the existing OPP and DT information to
> re-calculate the new power values.
> 
> 
> Changes:
> v2:
> - removed 'ret' from error message which wasn't initialized (Christian)
> v1:
> - exported the OPP calculation function from the OPP/OF so it can be
>    used from EM fwk (Viresh)
> - refactored EM updating function to re-use common code
> - added new EM function which can be used by chip device drivers which
>    modify the voltage in OPPs
> RFC is at [1]
> 
> Regards,
> Lukasz Luba
> 
> [1] https://lore.kernel.org/lkml/20231220110339.1065505-1-lukasz.luba@arm.com/
> 
> Lukasz Luba (4):
>    OPP: OF: Export dev_opp_pm_calc_power() for usage from EM
>    PM: EM: Change the em_adjust_new_capacity() to re-use code
>    PM: EM: Add em_dev_update_chip_binning()
>    soc: samsung: exynos-asv: Update Energy Model after adjusting voltage
> 
>   drivers/opp/of.c                 |  17 +++--
>   drivers/soc/samsung/exynos-asv.c |  11 +++-
>   include/linux/energy_model.h     |   5 ++
>   include/linux/pm_opp.h           |   8 +++
>   kernel/power/energy_model.c      | 109 +++++++++++++++++++++++++------
>   5 files changed, 125 insertions(+), 25 deletions(-)
> 

Please ignore this version. It still has that 'ret'. I've fixed in
different repo, but sent patches from different terminal.

I'll resend it in a second...

Regards,
Lukasz