Received-SPF: pass (google.com: domain of linux-kernel+bounces-111344-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <5e278d43-93dd-47ac-8502-28db2fcd32f9@leemhuis.info>
Date: Fri, 22 Mar 2024 12:01:52 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Regression] 6.8 - i2c_hid_acpi: probe of i2c-XXX0001:00 failed
 with error -110
Content-Language: en-US, de-DE
To: =?UTF-8?Q?Philip_M=C3=BCller?= <philm@manjaro.org>,
 Hans de Goede <hdegoede@redhat.com>
Cc: Jiri Kosina <jkosina@suse.com>,
 Linux kernel regressions list <regressions@lists.linux.dev>,
 Benjamin Tissoires <benjamin.tissoires@redhat.com>,
 "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
 LKML <linux-kernel@vger.kernel.org>
References: <9a880b2b-2a28-4647-9f0f-223f9976fdee@manjaro.org>
 <a587f3f3-e0d5-4779-80a4-a9f7110b0bd2@manjaro.org>
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@leemhuis.info>
Reply-To: Linux regressions mailing list <regressions@lists.linux.dev>
In-Reply-To: <a587f3f3-e0d5-4779-80a4-a9f7110b0bd2@manjaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[BCCed Greg and the stable list, as this is apparently a mainline
regression and has nothing to do with the stable series

Also CCing Jiri, Benjamin as well as various lists]

On 19.03.24 05:52, Philip Müller wrote:
> On 18/03/2024 17:58, Philip Müller wrote:
>> I'm currently developing on the OrangePi Neo-01, which ships with two
>> similar touchpads using the Synaptics driver. On 6.7.10 those two
>> devices get detected normally. On 6.8.1 it seems to error out.

Thx or the report.

>> I either get none, or at best only one of those two devices.
>>
>> i2c_hid_acpi: probe of i2c-XXX0001:00 failed with error -110
>> i2c_hid_acpi: probe of i2c-XXX0002:00 failed with error -110
> 
> I found the regression in commit aa69d6974185e9f7a552ba982540a38e34f69690
> HID: i2c-hid: Switch i2c_hid_parse() to goto style error handling

FWIW, that's a change from Hans. He is normally quite responsive, but as
he has not replied yet I guess he is AFK for a few days.

Ciao, Thorsten

> When I use the commit before I can rmmod and modprobe in a batch script
> using a loop without erroring out to -110. Attached the testing script
> and dmesg log snippets
> 
> #!/bin/bash
> for ((n=0;n<5;n++))
> do
> sudo rmmod i2c_hid_acpi
> sleep 1
> sudo modprobe i2c_hid_acpi --force-vermagic
> sleep 2
> done
> 
> I will try to use the code of 6.8.1 and revert that commit.

P.S.: To be sure the issue doesn't fall through the cracks unnoticed,
I'm adding it to regzbot, the Linux kernel regression tracking bot:

#regzbot report /
#regzbot introduced aa69d6974185e9f7a552ba982540a38e34f69690
#regzbot title HID: i2c-hid: probe of i2c-XXX0001:00 failed with error -110
#regzbot ignore-activity

--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.