Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1045846lqp; Fri, 22 Mar 2024 04:09:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVMXgPfOybJIE/2BbPPTsWT2VIkqWNWrKSPyUar4M1IS9gRzjEM1QrWAOqya0i6kyVGODfyHtsYDKJmEB6XwDCSCTgY2TFwMD3KWBu0Lg== X-Google-Smtp-Source: AGHT+IEsKCT5VQZTAY+wbzd8+RVzY5YhoCUeWnHPEzfcXR8TVkthPLHdcQzFdoRd9muX53qXF0vS X-Received: by 2002:a05:622a:47:b0:431:375b:bc95 with SMTP id y7-20020a05622a004700b00431375bbc95mr648600qtw.2.1711105794327; Fri, 22 Mar 2024 04:09:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711105794; cv=pass; d=google.com; s=arc-20160816; b=ohG0jdSK8WLi3E09IK3vxfNMeLt9ypHs/UttKDK2vjBYCYGeOideDyEdMxwUe23rcW edyOy/L7z/Ku/LKsDmWvOnInbDQ0Ubl7y8JnP3q/Hpd00UnObWCmGGI/Xq5jKymkNZiz ZsuKHU0aGOAMZFOOQynnIRSBtLFtk4FKq/aa8HiTyd01CI81nU1X29W7J+JimI1+JdSd 7hoK4f2eAR1ox+iAg4RqF7kAR9RQuaFKeJ3ywerImMvU95oUn4ENCR8U8fB043+aYNxW Qf4SBy2MZ5nMe5iDq11jfVn5SDfAtLnEDdoWWJdGMrzm+1OwWlGnaFwvlvuz3Koafg06 RERg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=N7wIR8WXnVy0rQAsMoDi9E2zN9y5HdUkzYu9w8L+l2E=; fh=76fY95VCn/tTPDURHIWBg4FyCkia1KFHdPTfdxMrHno=; b=NfPxVhEUi3mQ1CyyIp7HdW4LndMDnbiY2Vv4BAB1m2U4zcV1S6NGpnHDx6ufs9ejo3 TCwpM+r4EEhkFkjj17AW2A7v40ypPN+6WRfoQDhic8BDwVvwmg6QQqoqksWji/y3s88+ BXLXtYeS2egw5kgH/HvVwDc6kYPuWZY20oLl2KNvIh6TMYYHfTp8sVnliu1qCGfeWlv0 zva86Iryp1boIotfYnNhnMyGDLQX3Mx/IkountdoccWAMng5SmL4VImZxYBTVneEQjSq gxdYShIgK380sZBlHGPpbwsg53DAisKMRVMcNZY5EP1FS1zb8bSrHmFIuqqkfaTnQij4 nCwg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-111352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111352-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id q20-20020a05622a031400b00431247ba699si1725464qtw.378.2024.03.22.04.09.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 04:09:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-111352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-111352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111352-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 132F31C21291 for ; Fri, 22 Mar 2024 11:09:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83D423FE5F; Fri, 22 Mar 2024 11:09:10 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86E0A3E487; Fri, 22 Mar 2024 11:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711105750; cv=none; b=tHW45Bp1p/JKPav4lxJMyR3S/aLKKehv7sjyjoDbeiNUGQrppIAmXhf5jnydB1GxpFmazL5HHzGhv02Qjw8KLY3S8zYT8dZd3AhQdXoldNUFlMau3236gC0PUf7iHRBYorBgMDby2alrB1jWWMEBjQSE4wcQSh876UUGFp2k8HY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711105750; c=relaxed/simple; bh=q8TUnzTjHJK2dbOIIZXg2IIaPFcqKZKbJCN59JbEVCo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KfSZElQx5uMopdLRSte7KXlzw3wFAQLKez9i+U6f8kpZ/jEjTKHT5F5c2SsBxZoZ8CeENhonnQe2wXcjIF4O2Al2xWuUk/7JsIIk1JMStFLfN/HHoIE+LTASTDvfdIAJws1ZDcmubL/iaiCTeap0kQ2FPMXNlqcwS2NJfBoCHb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B88A1007; Fri, 22 Mar 2024 04:09:42 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.71.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B1D313F64C; Fri, 22 Mar 2024 04:09:05 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [RESEND][PATCH v2 3/4] PM: EM: Add em_dev_update_chip_binning() Date: Fri, 22 Mar 2024 11:08:49 +0000 Message-Id: <20240322110850.77086-4-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240322110850.77086-1-lukasz.luba@arm.com> References: <20240322110850.77086-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a function which allows to modify easily the EM after the new voltage information is available. The device drivers for the chip can adjust the voltage values after setup. The voltage for the same frequency in OPP can be different due to chip binning. The voltage impacts the power usage and the EM power values can be updated to reflect that. Signed-off-by: Lukasz Luba --- include/linux/energy_model.h | 5 ++++ kernel/power/energy_model.c | 51 ++++++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+) diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 770755df852f1..d30d67c2f07cf 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -172,6 +172,7 @@ struct em_perf_table __rcu *em_table_alloc(struct em_perf_domain *pd); void em_table_free(struct em_perf_table __rcu *table); int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, int nr_states); +int em_dev_update_chip_binning(struct device *dev); /** * em_pd_get_efficient_state() - Get an efficient performance state from the EM @@ -387,6 +388,10 @@ int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, { return -EINVAL; } +static inline int em_dev_update_chip_binning(struct device *dev) +{ + return -EINVAL; +} #endif #endif diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 6960dd7393b2d..f7f7ae34ec552 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -808,3 +808,54 @@ static void em_update_workfn(struct work_struct *work) { em_check_capacity_update(); } + +/** + * em_dev_update_chip_binning() - Update Energy Model with new values after + * the new voltage information is present in the OPPs. + * @dev : Device for which the Energy Model has to be updated. + * + * This function allows to update easily the EM with new values available in + * the OPP framework and DT. It can be used after the chip has been properly + * verified by device drivers and the voltages adjusted for the 'chip binning'. + * It uses the "dynamic-power-coefficient" DT property to calculate the power + * values for EM. For power calculation it uses the new adjusted voltage + * values known for OPPs, which might be changed after boot. + */ +int em_dev_update_chip_binning(struct device *dev) +{ + struct em_perf_table __rcu *em_table; + struct em_perf_domain *pd; + int i, ret; + + if (IS_ERR_OR_NULL(dev)) + return -EINVAL; + + pd = em_pd_get(dev); + if (!pd) { + dev_warn(dev, "Couldn't find Energy Model\n"); + return -EINVAL; + } + + em_table = em_table_dup(pd); + if (!em_table) { + dev_warn(dev, "EM: allocation failed\n"); + return -ENOMEM; + } + + /* Update power values which might change due to new voltage in OPPs */ + for (i = 0; i < pd->nr_perf_states; i++) { + unsigned long freq = em_table->state[i].frequency; + unsigned long power; + + ret = dev_pm_opp_calc_power(dev, &power, &freq); + if (ret) { + em_table_free(em_table); + return ret; + } + + em_table->state[i].power = power; + } + + return em_recalc_and_update(dev, pd, em_table); +} +EXPORT_SYMBOL_GPL(em_dev_update_chip_binning); -- 2.25.1