Received-SPF: pass (google.com: domain of linux-kernel+bounces-111421-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Fri, 22 Mar 2024 14:30:28 +0200 (EET)
To: Reinette Chatre <reinette.chatre@intel.com>
cc: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>, 
    Babu Moger <babu.moger@amd.com>, 
    =?ISO-8859-15?Q?Maciej_Wiecz=F3r-Retman?= <maciej.wieczor-retman@intel.com>, 
    Fenghua Yu <fenghua.yu@intel.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 11/13] selftests/resctrl: Convert ctrlgrp & mongrp to
 pointers
In-Reply-To: <578d0b55-c51a-49d1-8f54-989215a3a4b8@intel.com>
Message-ID: <93e4f096-47df-9eba-095f-e8a8c3cd04f5@linux.intel.com>
References: <20240311135230.7007-1-ilpo.jarvinen@linux.intel.com> <20240311135230.7007-12-ilpo.jarvinen@linux.intel.com> <578d0b55-c51a-49d1-8f54-989215a3a4b8@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-552054796-1711110628=:1115"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-552054796-1711110628=:1115
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 20 Mar 2024, Reinette Chatre wrote:
> On 3/11/2024 6:52 AM, Ilpo J=C3=A4rvinen wrote:
> > The struct resctrl_val_param has control and monitor groups as char
> > arrays but they are not supposed to be mutated within resctrl_val().
> >=20
> > Convert the ctrlgrp and mongrp char array within resctrl_val_param to
> > plain const char pointers and adjust the strlen() based checks to
> > check NULL instead.
> >=20
> > Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> >  tools/testing/selftests/resctrl/resctrl.h   | 4 ++--
> >  tools/testing/selftests/resctrl/resctrlfs.c | 8 ++++----
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/=
selftests/resctrl/resctrl.h
> > index 52769b075233..54e5bce4c698 100644
> > --- a/tools/testing/selftests/resctrl/resctrl.h
> > +++ b/tools/testing/selftests/resctrl/resctrl.h
> > @@ -89,8 +89,8 @@ struct resctrl_test {
> >   */
> >  struct resctrl_val_param {
> >  =09char=09=09*resctrl_val;
> > -=09char=09=09ctrlgrp[64];
> > -=09char=09=09mongrp[64];
> > +=09const char=09*ctrlgrp;
> > +=09const char=09*mongrp;
> >  =09char=09=09filename[64];
> >  =09unsigned long=09mask;
> >  =09int=09=09num_of_runs;
> > diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testin=
g/selftests/resctrl/resctrlfs.c
> > index 79cf1c593106..dbe0cc6d74fa 100644
> > --- a/tools/testing/selftests/resctrl/resctrlfs.c
> > +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> > @@ -469,7 +469,7 @@ static int create_grp(const char *grp_name, char *g=
rp, const char *parent_grp)
> >  =09 * length of grp_name =3D=3D 0, it means, user wants to use root co=
n_mon
> >  =09 * grp, so do nothing
> >  =09 */
>=20
> Could you please confirm that the comments are still accurate?

It's not, I missed it.

> > -=09if (strlen(grp_name) =3D=3D 0)
> > +=09if (!grp_name)
> >  =09=09return 0;

But now when looking into the surrounding code, to me it looks the correct=
=20
action here is to remove the comment and return -1 instead of 0. It makes
this just an internal sanity check that grp_name is provided by the=20
caller.

--=20
 i.

--8323328-552054796-1711110628=:1115--