Received-SPF: pass (google.com: domain of linux-kernel+bounces-111433-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <23f6cc23-9f9b-405b-8c8e-5cda14e79587@linux.alibaba.com>
Date: Fri, 22 Mar 2024 20:41:24 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -next] fs: Add kernel-doc comments to
 ocfs2_prepare_orphan_dir()
Content-Language: en-US
To: Yang Li <yang.lee@linux.alibaba.com>, akpm <akpm@linux-foundation.org>
Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240322063718.88183-1-yang.lee@linux.alibaba.com>
From: Joseph Qi <joseph.qi@linux.alibaba.com>
In-Reply-To: <20240322063718.88183-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/22/24 2:37 PM, Yang Li wrote:
> This commit adds kernel-doc style comments with complete parameter
> descriptions for the function ocfs2_prepare_orphan_dir.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/namei.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 9221a33f917b..8a61c5f94533 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -2187,8 +2187,10 @@ static int __ocfs2_prepare_orphan_dir(struct inode *orphan_dir_inode,
>   * @osb: ocfs2 file system
>   * @ret_orphan_dir: Orphan dir inode - returned locked!
>   * @blkno: Actual block number of the inode to be inserted into orphan dir.
> + * @name: Buffer to store the name of the orphan.
>   * @lookup: dir lookup result, to be passed back into functions like
>   *          ocfs2_orphan_add
> + * @dio: Flag indicating if direct IO is being used or not.
>   *
>   * Returns zero on success and the ret_orphan_dir, name and lookup
>   * fields will be populated.