Received-SPF: pass (google.com: domain of linux-kernel+bounces-111428-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>, Justin Ernst <justin.ernst@hpe.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
 Justin Ernst <justin.ernst@hpe.com>
Subject: Re: [PATCH] tools/power/turbostat: Fix uncore frequency file string
Date: Fri, 22 Mar 2024 13:38:02 +0100
Message-ID: <1980117.DIVbhacDa7@work.fritz.box>
In-Reply-To: <20240308204957.2007212-1-justin.ernst@hpe.com>
References: <20240308204957.2007212-1-justin.ernst@hpe.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart7509112.W097sEU6C4";
 micalg="pgp-sha256"; protocol="application/pgp-signature"

--nextPart7509112.W097sEU6C4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1"
From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>, Justin Ernst <justin.ernst@hpe.com>
Date: Fri, 22 Mar 2024 13:38:02 +0100
Message-ID: <1980117.DIVbhacDa7@work.fritz.box>
In-Reply-To: <20240308204957.2007212-1-justin.ernst@hpe.com>
References: <20240308204957.2007212-1-justin.ernst@hpe.com>
MIME-Version: 1.0

On Freitag, 8. M=E4rz 2024 21:49:57 CET Justin Ernst wrote:
> Running turbostat on a 16 socket HPE Scale-up Compute 3200 (SapphireRapid=
s)
> fails with: turbostat:
> /sys/devices/system/cpu/intel_uncore_frequency/package_010_die_00/current=
_f
> req_khz: open failed: No such file or directory
>=20
> We observe the sysfs uncore frequency directories named:
> ...
> package_09_die_00/
> package_10_die_00/
> package_11_die_00/
> ...
> package_15_die_00/
>=20
> The culprit is an incorrect sprintf format string "package_0%d_die_0%d" u=
sed
> with each instance of reading uncore frequency files.
> uncore-frequency-common.c creates the sysfs directory with the format
> "package_%02d_die_%02d". Once the package value reaches double digits, the
> formats diverge.
Yep, currently in:
drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
line 238.

Looks like the proper bugfix.
=20
> Change each instance of "package_0%d_die_0%d" to "package_%02d_die_%02d".
>=20
> Signed-off-by: Justin Ernst <justin.ernst@hpe.com>

Reviewed-by: Thomas Renninger <trenn@suse.de>

       Thomas
--nextPart7509112.W097sEU6C4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEo0EXulPW3gW/5bAoTxjWwdl3vVUFAmX9e6oACgkQTxjWwdl3
vVXxNwf5AWawwcrw7oZOe5MpqLkq3TLMdUCnB2ZyDdYQvL/53El5phMTS1giob/S
xdppK7m50CrbWVw3rugnrN/ljgQ1FAhLzmL2yfJ16WO3LtQxUttNfFWFLg/4Ug4n
MCdeKa8FamtxQu4CTLijPjx1LWcCSISxjCrFMb4Fvuz5EkVZfj1F2sOV8A/shpfK
hPS23mywWpC5UwFEh0i3kKLil0QexN3oF3A5xj2byqfQr8TOMrKAC8Lm8JkAD9si
EFueVsnoVzJLMqW4D8q80rQByjau3GHGHn9q+8o4hEmfNXu821Dv/SZUu72xnydC
6dk3bBfCNR3w8UYTjf/JNv24LdkG5w==
=nD7I
-----END PGP SIGNATURE-----

--nextPart7509112.W097sEU6C4--