Received-SPF: pass (google.com: domain of linux-kernel+bounces-111456-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 22 Mar 2024 14:14:24 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Arnd Bergmann <arnd@arndb.de>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Marc Zyngier <maz@kernel.org>, Nathan Rossi <nathan.rossi@digi.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] irqchip: armada: suppress unused-function
 warning
Message-ID: <1656dbc4-a695-4150-b24c-aeb3d6ecd77e@lunn.ch>
References: <20240322125838.901649-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240322125838.901649-1-arnd@kernel.org>

On Fri, Mar 22, 2024 at 01:58:25PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> armada_370_xp_msi_reenable_percpu is only defined when CONFIG_PCI_MSI
> is enabled, and only called when SMP is enabled.
> 
> Without CONFIG_SMP, there are no callers, so we get a build time
> warning instead:
> 
> drivers/irqchip/irq-armada-370-xp.c:319:13: error: 'armada_370_xp_msi_reenable_percpu' defined but not used [-Werror=unused-function]
>   319 | static void armada_370_xp_msi_reenable_percpu(void) {}
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Mark the function as __maybe_unused to avoid adding more complexity
> to the #ifdefs.
> 
> Fixes: 8ca61cde32c1 ("irqchip/armada-370-xp: Enable MSI affinity configuration")
> Link: https://lore.kernel.org/lkml/20221215170202.2441960-1-arnd@kernel.org/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew