Received-SPF: pass (google.com: domain of linux-kernel+bounces-111465-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Marcel Ziswiler <marcel@ziswiler.com>
To: linux-phy@lists.infradead.org
Cc: linux-imx@nxp.com,
	Lucas Stach <l.stach@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	kernel@pengutronix.de,
	Richard Zhu <hongxing.zhu@nxp.com>,
	linux-kernel@vger.kernel.org,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Fabio Estevam <festevam@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Rob Herring <robh@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Tim Harvey <tharvey@gateworks.com>,
	Vinod Koul <vkoul@kernel.org>,
	Yang Li <yang.lee@linux.alibaba.com>,
	imx@lists.linux.dev
Subject: [PATCH v1 0/1] phy: freescale: imx8m-pcie: facing pcie link-up instability
Date: Fri, 22 Mar 2024 14:06:31 +0100
Message-ID: <20240322130646.1016630-1-marcel@ziswiler.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:74KcX7nW7Lw=;X3qNWHTWhdPGP4Bx7ruOjmlom1t
 jH5YtiuSOPVk+aY+hPN1VCaiVMjSxq6opeaKoSwgnnK8Vaqepb/M2GX/BOokDCU6x6heLdXvt
 CrdJIJVK6szYP09OJznxTK6qzO0HA/FiRe+y7dfqTKkEF+PC9IHBNI2VVeC601uPp+ukIDwDM
 8Te8DrdPzwIMBSd7sYBkd8KXpi/nrNkhFt0FNy3chWnftKRAWNDfvvL524u58DmPSfYH6h/71
 zaXi7de3UV4g0+o3dB4BvXJWWPustT1U9GI+zHzX549MjUhOPtJPN0en8gcSR5KyNP8wSIt6K
 Ut86YRpJFDOHxSf0PfPTZPtm+qzqslbaLDotkbJlc0p1PJznZFnHgiB86Uo/+uMNYHiRyP4u+
 +49/SkjWXTciUd4dxtcziR1weA7q/RpgL7voCba5OnCi4T8y2WJxCOo238hvn3pjowPQ9++m2
 0YtZpU6bdgs1Y7EsTIe4nMFRBR3e74cXbpLq61+f1SSH2tsXWvNqxSP8b4AdwZcbroaooMqWJ
 cfFE7+KNhv9jL9bElajVjjSCX4RwP3fDZwupWRBKTp94SELsjApFnk9lJgTQcP2lL7P9/n9xT
 aiByBGLsD3lUKvhij5JJKAcPHXvjSg42YmuHf89u/V6Gw8eZVKZrv4zIsMrxUIJq1MSMXfahv
 9UqMPySHYwmLz9IVAaCCXfBf30nVcgLvMN8/KKcl+4i5P66rt4q2HrSfopIQBOiSqftBxrgOv
 FouyEfBgQw1GL/puex+bMic26uJvPrX7g==

From: Marcel Ziswiler <marcel.ziswiler@toradex.com>


In our automated testing setup, we use Delock Mini-PCIe SATA cards [1].
While this setup has proven very stable overall we noticed upstream on
the i.MX8M Mini fails quite regularly (about 50/50) to bring up the PCIe
link while with NXP's downstream BSP 5.15.71_2.2.2 it always works. As
that old downstream stuff was quite different, I first also tried NXP's
latest downstream BSP 6.1.55_2.2.0 which from a PCIe point of view is
fairly vanilla, however, also there the PCIe link-up was not stable.
Comparing and debugging I noticed that upstream explicitly configures
the AUX_PLL_REFCLK_SEL to I_PLL_REFCLK_FROM_SYSPLL while working
downstream [2] leaving it at reset defaults of AUX_IN (PLL clock).
Unfortunately, the TRM does not mention any further details about this
register (both for the i.MX 8M Mini as well as the Plus). Maybe somebody
from NXP could further comment on this?

BTW: On the i.MX 8M Plus we have not seen any issues with PCIe with the
exact same setup which is why I left it unchanged.

[1] https://www.delock.com/produkt/95233/merkmale.html
[2] https://github.com/nxp-imx/linux-imx/blob/lf-5.15.71-2.2.0/drivers/pci=
/controller/dwc/pci-imx6.c#L1548


Marcel Ziswiler (1):
  phy: freescale: imx8m-pcie: fix pcie link-up instability

 drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

=2D-
2.44.0