Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1138677lqp; Fri, 22 Mar 2024 06:47:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVB1ubqWklzjnK5P11vd/R/FFtbT4mcwvKy3gBmLIobIjGLY42iSEOz/rYqL7kjDc6ouvjmJjrj34FdK06b0a4bwhvGp2ctmD/z85Vd5Q== X-Google-Smtp-Source: AGHT+IGlLGj3pm3Y49VyB7WW5FrEIgajPdhfMmki32sdGhNN8WFZfZvq8LnoLibjtJN/4QVq79Ue X-Received: by 2002:a05:6a20:1592:b0:1a3:81d2:29f with SMTP id h18-20020a056a20159200b001a381d2029fmr3497551pzj.17.1711115241149; Fri, 22 Mar 2024 06:47:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711115241; cv=pass; d=google.com; s=arc-20160816; b=hWXl7+oDE+hEyX2HNq224hth7wvCvXGGKoJm5g3AKVBdmfNiU3+9wYRoppwFL76lSZ ZoC8w5Ry26mrN8U3/7ACPdLHhsKlpNeLPdEsdmBhvoEGVeS5+B979JOOv+d72Bu7W1Gu AqEjVLHV7Ul1HVjAjNbnOqbb7yF2ECgv8hAE6UoHoYTdozrGpUijmJLYqwRjVjXlaKX9 LxykUYJ+WzlwU3l0Tp9L8JiAu3V4VVNzQ+migQS2/o4u8wTtAk3mp3N/j/GoChMQmlkJ P/oqhm9ipnMWY3Opk6V4ICmellrMiMf/8X7pvav5G3JXenadJliAqEmEhi3v2Py+dDQ2 nYFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from; bh=6qsAP77qJ4xhJsHrmi/GU+KJe0kvUi/03nzkh2reOOs=; fh=eIqFenkGkqCdDrqkQ/JhZn5bbDQbIG9hGFEjiMtKEuk=; b=A0oKO6+BMYbhKi2G6KG7bMlGMSK2HJ75tdQFmje6SEm60yjSns4c72viDl0g0pUrVF uhDtg2Wk/VsXTHuySPyBa2MfcwzJcmew3b3nfyx+JFugey1lTUeJbjMdzG+ODUUz5bf4 d63RcTdb06bOnLABkoc8hMmwDeKEqfoPYdmRpLEkgld7AzZKKT/zhXSsZ4TTy0NjsWs2 rsBUz2XDSMgQT8kt1bJ0Pcq99LuVXWu9fDbWkqmx2telmsui/F5wnv6qHWcEnyxheHsz 6kKj7K0XkvmvcJmjMsW+jf9zD7m3dmU2FCssHwernOVlRWZMJOg4Co9Wg5F26oGJqlv5 itgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=korsgaard.com); spf=pass (google.com: domain of linux-kernel+bounces-111554-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111554-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b10-20020a170902d88a00b001e04cf2c1besi1949072plz.204.2024.03.22.06.47.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 06:47:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-111554-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=korsgaard.com); spf=pass (google.com: domain of linux-kernel+bounces-111554-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111554-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B88B9285AED for ; Fri, 22 Mar 2024 13:44:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 404CE5FDB0; Fri, 22 Mar 2024 13:36:43 +0000 (UTC) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16EA45BFF; Fri, 22 Mar 2024 13:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711114602; cv=none; b=OzJJUva6nsHjri6Yr4LnNsiyGNIgqCVA0jmjDrR5yTAlSNkOi2SbJFkVb9zuUm5sMcVJfzkE0b6qIVVvXqMSGbnbw270areGXxyBPfFNQFWjWpf0ZgW8TLvjcERv4xzx0gUAxHLb1e6SZ3YuDaze4Cux//RmW8DFlwM1tuhtIE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711114602; c=relaxed/simple; bh=qn+E2wYjJfNHPhIQlSnI5xtESAViWEOYAofY4YkCvnQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=Jw5KUk4XCzJmo+BMYF7dFG2YEWLcua5gHt+0pusFrdmLOlBaghhBcDQptfmGyaSqIAfqqcRs0J0g+qd/LD6jUVxM+hMnvrulNomPZfoBmFrPzBU0n4vPM/6hGp1dIV+wkQLJesNTNYcUz0+82ixB8nctZwdlGJM8V3c7pChWorE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com; spf=pass smtp.mailfrom=korsgaard.com; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korsgaard.com Received: by mail.gandi.net (Postfix) with ESMTPSA id C978C1C0005; Fri, 22 Mar 2024 13:36:29 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.96) (envelope-from ) id 1rnf4P-005ytU-0d; Fri, 22 Mar 2024 14:36:29 +0100 From: Peter Korsgaard To: Arnd Bergmann Cc: Vinod Koul , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , Nathan Chancellor , Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Randy Dunlap , Rob Herring , Zhang Jianhua , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] dmaengine: owl: fix register access functions References: <20240322132116.906475-1-arnd@kernel.org> Date: Fri, 22 Mar 2024 14:36:29 +0100 In-Reply-To: <20240322132116.906475-1-arnd@kernel.org> (Arnd Bergmann's message of "Fri, 22 Mar 2024 14:21:07 +0100") Message-ID: <87o7b62xsy.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: peter@korsgaard.com >>>>> "Arnd" == Arnd Bergmann writes: > From: Arnd Bergmann > When building with 'make W=1', clang notices that the computed register > values are never actually written back but instead the wrong variable > is set: > drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 244 | u32 regval; > | ^ > drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 268 | u32 regval; > | ^ > Change these to what was most likely intended. > Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver") > Signed-off-by: Arnd Bergmann Good catch! Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard