Received-SPF: pass (google.com: domain of linux-kernel+bounces-111624-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 22 Mar 2024 14:33:03 +0000
From: Mark Brown <broonie@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: corbet@lwn.net, workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
	lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org,
	Barry Song <v-songbaohua@oppo.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Zankel <chris@zankel.net>,
	Huacai Chen <chenhuacai@loongson.cn>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Guenter Roeck <linux@roeck-us.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH v3 1/2] Documentation: coding-style: ask function-like
 macros to evaluate parameters
Message-ID: <7d965b3a-c857-4498-aea9-5a3ad8ad5b76@sirena.org.uk>
References: <20240322084937.66018-1-21cnbao@gmail.com>
 <20240322084937.66018-2-21cnbao@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="F/USLqwBIaw6nYmg"
Content-Disposition: inline
In-Reply-To: <20240322084937.66018-2-21cnbao@gmail.com>


--F/USLqwBIaw6nYmg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 09:49:36PM +1300, Barry Song wrote:

> The driver code, for itself, seems be quite innocent and placing
> maybe_unused seems pointless,
>=20
>  struct page *dst_page =3D sg_page(req->dst);
>=20
>  for (i =3D 0; i < nr_pages; i++)
>  	flush_dcache_page(dst_page + i);
>=20
> And it should be independent of architectural implementation
> differences.
>=20
> Let's provide guidance on coding style for requesting parameter
> evaluation or proposing the migration to a static inline
> function.

Reviewed-by: Mark Brown <broonie@kernel.org>

--F/USLqwBIaw6nYmg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX9lp4ACgkQJNaLcl1U
h9D/3Qf+OAmGX1LtgvGmlxtBTyB3f+RqYVcaN+eDJ5mmGb/PBXtUHrCWMIjdJV1T
alW4pNoJlPHSip3U7gjDx/VVEkHpBMD6wl3aoTYn+1iiG+8fwxu5WRYWptGwx3ux
NULjEcNjGxzdVH6RBC/9KiOEU3WyWMBRDlNzA78mngM8JDDOephB6Z8OEYbz53A7
PQGn3ogxV5WvhEYmJw402pzierGbewLnmiPTJhhdp81l+kIGFKtuxch8Ucde+tzw
qU2EgbM7OVuXj3LVw/aDPjyYJwZhwXUVuV+TB1MVqog4dqkbon6UgPonc2PPwTnO
EOFhcKG422l9nhl/Iig/3i1DVCAVZw==
=i5nb
-----END PGP SIGNATURE-----

--F/USLqwBIaw6nYmg--