Received-SPF: pass (google.com: domain of linux-kernel+bounces-111729-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a9bddc1c-9652-400c-8f79-b745894604d9@infradead.org>
Date: Fri, 22 Mar 2024 08:51:32 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ftrace: fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry
Content-Language: en-US
To: Prasad Pandit <ppandit@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
 Prasad Pandit <pjp@fedoraproject.org>
References: <20240322121801.1803948-1-ppandit@redhat.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240322121801.1803948-1-ppandit@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/22/24 05:18, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@fedoraproject.org>
> 
> Fix FTRACE_RECORD_RECURSION_SIZE entry, replace tab with

replace the tab between "default" and "128" with a space

> a space character. It helps Kconfig parsers to read file
> without error.

Parsers should accept either tab or space but this is a
reasonable change.

> Fixes: 773c16705058 ("ftrace: Add recording of functions that caused recursion")
> Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  kernel/trace/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 61c541c36596..47345bf1d4a9 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -965,7 +965,7 @@ config FTRACE_RECORD_RECURSION
>  
>  config FTRACE_RECORD_RECURSION_SIZE
>  	int "Max number of recursed functions to record"
> -	default	128
> +	default 128
>  	depends on FTRACE_RECORD_RECURSION
>  	help
>  	  This defines the limit of number of functions that can be

-- 
#Randy