Received: by 2002:a05:7208:70d5:b0:7f:5597:fa5c with SMTP id q21csp1269423rba; Fri, 22 Mar 2024 08:56:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUinAarM8okiH/8vY+xjBmdhyxmy24B77qA1xyJJAmNfH8iEu29HkYvE5S2cB6BXoal2Ws8uXDaUhhFdXfyxd5DqHhYOHeRgt0YvTHdnA== X-Google-Smtp-Source: AGHT+IEViSvgVeHpW9peh/O1srPJGaPpWjIR6PuBZPJ5CZVJJKuj1mnmdZkObe7I/q5P3m5rOOFQ X-Received: by 2002:a05:6358:741f:b0:17e:cd0f:3bde with SMTP id s31-20020a056358741f00b0017ecd0f3bdemr3317194rwg.29.1711123016527; Fri, 22 Mar 2024 08:56:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711123016; cv=pass; d=google.com; s=arc-20160816; b=ZreinItQ9n7WRD2LWEJNAAcTSOjObzvJ0pSO2tfKmIWZEJ7MyNXAROc7eM8bcZWnGp Lxdh/QET9MmtfQqfz4R8AuDGqQOJNc+Wp1qh/sA/KEdDfM1+sjOouQBl513b9asPx02b iUkYMJWvdoDsBqvDF07WuhQSRozH+tMJ+UnRkagTyxCCaKSIas/1zzaizqc+C9BDjNxB +Zo0LW8VrDHlShFFGYutFINVe2bl831COiO8eeJ7LlY7NGzxC5hQ+PRrrcVqc98g/wlW EJCA/vS9J56UCeH+4Kbon+CL33b5CI2F7CKEcvhbarpStZ5ZVcuI6GVaMMSSR7jNJPVt 8rQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bFqRY/K29N5KY4oWl3hHzhxOBffmPcj/lfWbmVtrjFY=; fh=lbdQIi6pa8bPVaPhzzrxZ1Ap5RUpuHW5d0IT6gO4TZ8=; b=hRGV7FrxAovz535RLkHApi5uzpMbzuq7csgrjBtQj/NAxRsZ5yXXr0ZQ5oSMfeNGOY j6CAcg7h1DSk7QgTtnKy4O24/XOgooBUSB06xt37CHBybNwppeU9Quzej3L3NJ0dRzqn UCrHcJkeqOSK1YritPWGnCzN6ELwhfQYISA4m+RN206w+cKn4HICtWIlMR308kHsgEVv cRI6oTzk+LfvLqHa6uWc823LnzHbpkg9ey8dfMOlNJYcDsNi7P2WrVa2imyTG4phJaRY zMjMcVjn63POjkxGWOsHE/skfGzlt7K8nJu+k9q/+2OPJVd+b2dLUC35qsZ3GxDUEuRG 0FTA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qg+gMoCJ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-111733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j20-20020a63e754000000b005dc5576a4fasi2179982pgk.770.2024.03.22.08.56.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 08:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-111733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qg+gMoCJ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-111733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 14C4E286844 for ; Fri, 22 Mar 2024 15:56:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B7A5556763; Fri, 22 Mar 2024 15:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qg+gMoCJ" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 531AD524DF; Fri, 22 Mar 2024 15:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711123007; cv=none; b=UyG96QPf29aAb14fWekieLv2/6y2JO7yNahDmz8wDcuXVrWpQgZ2wD3bcUWKzIyywSI4xKrk0BoaM4ppAoWs2VRukPtU1vJopodGrfGbF5ePpNTn9cTgkn1ZHawtQFUN/5Qvk3VZ8qFIOvuAsZNb3koWd0Ocztfj1WOioQXKVFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711123007; c=relaxed/simple; bh=TN6iWFQ6tks/7SD6PC2cwdtWsPju4N4ielJpFORj08Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aFhnEfJ4WD+AjaxguyqJKyARb3tJNm9IMkQes7eCsqAh4ndOtIumL+dHi3zog4h3U9tlHBcahh4jXTZdmf+aRRKuPf91e2O0hiNClZ+uFFtNc1JQvyymHp9IVDphZVeXUKpkAlhYB+vgJWlvoSNio5UwgYvqZ1uZK5Dp+XmNok0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=qg+gMoCJ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=bFqRY/K29N5KY4oWl3hHzhxOBffmPcj/lfWbmVtrjFY=; b=qg+gMoCJCGMDoZ5fvzr4D2pcHv fjWbyQ5pmoQok07RbG+aciz9Jd3XbkrxVzu+FOK+4a2p5+LhaAYtwcGBaLrNO0XY+TSK7fiKyjq0Z fmYW94VP/KBohx0uO/VCJQXHqPs2/BTmlwBHyx+Ers5NAYxSif2r0FcusvFMA6IjL/2M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rnhFx-00AyDl-8A; Fri, 22 Mar 2024 16:56:33 +0100 Date: Fri, 22 Mar 2024 16:56:33 +0100 From: Andrew Lunn To: POPESCU Catalin Cc: "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , GEO-CHHER-bsp-development , "m.felsch@pengutronix.de" Subject: Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across suspends Message-ID: <5746c9da-1d45-4d06-a925-4150e680b8ec@lunn.ch> References: <20240306171446.859750-1-catalin.popescu@leica-geosystems.com> <8de1d4e3-6d80-45a5-a638-48451d9b5c15@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > > It looks like the issue I'm trying to address in this patch is not > > specific to dp8382x. Right now, depending on if the PHY is reset or not > > during resume (either through mdio_device reset_gpio/reset_ctrl or > > phy_driver soft_reset callback), the WOL configuration is either the PHY > > reset value or the BIOS value. I could still make the patch but it > > doesn't really make sense to address only dp8382x. This is an interesting point. soft_reset the driver is in control off. It can preserve the WoL setting over the soft reset. A hardware reset is a different matter. However, if we woke up due to WoL, the PHY never went to sleep, its state is intact, so why are we doing a hardware reset? Andrew