Received-SPF: pass (google.com: domain of linux-kernel+bounces-111762-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1711122067.git.thomas.lendacky@amd.com>
In-Reply-To: <cover.1711122067.git.thomas.lendacky@amd.com>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Fri, 22 Mar 2024 18:10:52 +0200
Message-ID: <CAMj1kXGUZAzBQMzZOsZaYuaGfAn4AHv1FMzZT9vvHCU3aAjcfg@mail.gmail.com>
Subject: Re: [PATCH 0/2] Fixes for recent x86/boot rip-relative addressing changes
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, 
	Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, 
	Dave Hansen <dave.hansen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 22 Mar 2024 at 17:41, Tom Lendacky <thomas.lendacky@amd.com> wrote:
>
> This patch series provides fixes for the recent x86/boot rip-relative
> addressing changes that causes system crashes when booting with 5-level
> pagetables and SME active.
>
> I thought I had tested 5-level paging with SME, but must have missed
> it. There are two patches to fix the issues that can be squashed into
> a single patch with multiple Fixes: tags if desired.
>

Perhaps you tested the entire series, where the final patch removed
those variables altogether?

> The second patch is sort of a revert, but instead uses the newer
> RIP_REL_REF() macro instead of reverting the fix and continuing to use
> the fixup_pointer() support.
>

Thanks for fixing this.

Series

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>