Received: by 2002:a05:7208:70d5:b0:7f:5597:fa5c with SMTP id q21csp1290553rba; Fri, 22 Mar 2024 09:28:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUfDjk/aVZQfVGAi+XlFuOcjJAEn1iEtQr/zUzK9UZbDBedhY2YsSCqOzQ9xHctC42f1hDLVBKkoGABt789s5C3eZf17jafMnV3whsw/Q== X-Google-Smtp-Source: AGHT+IG1QAzNuX2PBiIHcTsAqj6nvGSug4jiF4YB1S9T2ad2jO18seWxOQpaTGkHD6DnrHmba0n4 X-Received: by 2002:a05:6358:4325:b0:17c:1c76:84b1 with SMTP id r37-20020a056358432500b0017c1c7684b1mr2829847rwc.14.1711124886390; Fri, 22 Mar 2024 09:28:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711124886; cv=pass; d=google.com; s=arc-20160816; b=cifVVat3HASPAS6TZDjzCii7qw/E1YajPsRfd/rgLtWdtuFC38hEmN/Z0EkcQB/TCI mn4dKdhI9Hw+kM5Wg9WP+JqXTY1sznYMLUok61bLsyX/fKJUTKC4h4/0Q3rbz3ms1kor CqnizMbbiy3g47AtUljYafg+UBgnu/WZmOdFYH3poAqAvQ4c8xuOTq0+S/PV/ktDyRIE H7AzuYmOIoy50rZBUKbms3V9rF5vMJsoa8Ggo4zZYs579wIrFfPcCAh2h0oZBrErGIYP q17PT/j16uY6QTESv5Hfu3NqUZ2Myx22aWt8wI5aSKBbNj7q8HOFM7NFsBSSv3RjkYHO lb9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=wyXuDtgX+Y6XQjAmPXH/iL4ErrxO3nFeQF8ijLYpbuo=; fh=TODIdAauESDaBDkLhKv1OZ3TVRB5/QIrE+4lBfK+zSA=; b=WTrDv3Q1UNLfKDAciFtS/gOCkU1tLbzu4BM1UVX/0jaNAOVIe6XcOCFXBZIF+J/dXk 74Z3EWDpwOMWczVXA2bDbGJlEElyOKtMgXeClbkvdOotXbptakAw2CUlNmUmy1T/Emcc 3MAGGzhBblgB8kC66GgCJA6En2NuMmH8eyAqCuO2KK4X3qqy3wQlX6uWHnoramJxRVKm fCHlvImnn+TeVl+mkjNQDcOyvwEReYFCbBWmR4fJsuIq5JqtOu7P8pltIzVVMZBjTvPX D+omkUS9OxzsO/lsWjeaKxd66u5gDhV84fWREBOfhbDho20YPNIBcTw7t43VId9slaZM /PxQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Hwch4OxJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-111776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111776-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 9-20020a05621420c900b006961007657asi2352712qve.178.2024.03.22.09.28.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 09:28:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-111776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Hwch4OxJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-111776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111776-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1282B1C213E3 for ; Fri, 22 Mar 2024 16:28:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6391159147; Fri, 22 Mar 2024 16:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Hwch4OxJ" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 258934F60D; Fri, 22 Mar 2024 16:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711124879; cv=none; b=TZS8/lZLM/U22DZwKTxrQY0gPvK7KZ1wp5gtZ4tsEBWnCUJspJBcbvnfEh2m7Xj+UFCk06s3X2yH+yywW01T0YbFJ42l94DjDB8knWw/Z/G6zEHoArgWFqLrgGv4m8QhKWfu2/GJMIZOYlRVMZdMTbe6FD77PCoSU2bsDvQZDWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711124879; c=relaxed/simple; bh=Yg2Xfm9bBL3/e8m4eyIH1Wm/XrSP3qfZNh7KZLgdZbg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ALGeQv/Ng/J4ge1nzj2c5si59EYTDs98R+olVHdj9DgpDjJ9ku+JWPZKSgZfxCv/ZLZagGXLMdBKe33QlFgYs4mJDNGMDhxKRaSDRz1YCiEa8Bt8yFWyFb0DWMPgUaOjuaWOE35LmJfaAPIw837kEgK0bGTUqX1Rlh62zYmzgyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Hwch4OxJ; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711124878; x=1742660878; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Yg2Xfm9bBL3/e8m4eyIH1Wm/XrSP3qfZNh7KZLgdZbg=; b=Hwch4OxJ2Qx/emOvLbjz5yEaj1I/rY6PYXwhTkmgF0H3bmFDBHb114oM 7YiSBV5y7F9pHCnSw+HxQPyLIiYGMr8jr9SQ/2Q0ULNECmYpbAeWeJefy QHwD5ZG6caqX6YjsbM86CuXylw9FOgJPMlqbESYpJFeIwm1zlkcDKqWj6 ZleBJmJ20bOjJgSg32hTLdXMj3gZGB3Xckf3Mu3nPalh6QY9RiDiDDG0X sasCeDnBl2QX1MEX90dIKeyiLH2ArcjqTyuDC+Y72IvnqMY3Hznv/2IFX LZqB6hdU5L8txG4TXr7CGVhHYBJFuI9wgfsvwVsx1kOUbwQIAbhkmLCLd g==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="17574400" X-IronPort-AV: E=Sophos;i="6.07,146,1708416000"; d="scan'208";a="17574400" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 09:27:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,146,1708416000"; d="scan'208";a="15017149" Received: from ashwanim-mobl.amr.corp.intel.com (HELO [10.209.56.241]) ([10.209.56.241]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 09:27:55 -0700 Message-ID: <003f1e83-fd93-4f4f-a316-d3e89e5a23a5@intel.com> Date: Fri, 22 Mar 2024 09:27:54 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm/ident_map: Use full gbpages in identity maps except on UV platform. Content-Language: en-US To: Steve Wahl , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Linux regressions mailing list , Pavin Joseph , stable@vger.kernel.org, Eric Hagberg Cc: Simon Horman , Eric Biederman , Dave Young , Sarah Brofeldt , Russ Anderson , Dimitri Sivanich References: <20240322162135.3984233-1-steve.wahl@hpe.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240322162135.3984233-1-steve.wahl@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/22/24 09:21, Steve Wahl wrote: > Some systems have ACPI tables that don't include everything that needs > to be mapped for a successful kexec. These systems rely on identity > maps that include the full gigabyte surrounding any smaller region > requested for kexec success. Without this, they fail to kexec and end > up doing a full firmware reboot. > > So, reduce the use of GB pages only on systems where this is known to > be necessary (specifically, UV systems). Isn't this called "buggy firmware"? I'd much rather add synthetic entries to the memory maps that have this information than hack around it by assuming that things are within a gigabyte.