Received-SPF: pass (google.com: domain of linux-kernel+bounces-111779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240322130646.1016630-1-marcel@ziswiler.com>
In-Reply-To: <20240322130646.1016630-1-marcel@ziswiler.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Fri, 22 Mar 2024 13:29:05 -0300
Message-ID: <CAOMZO5ANM-ze3=ZG33ZgO+=4V_z5QJhqherB_d7WSe33sVB21w@mail.gmail.com>
Subject: Re: [PATCH v1 0/1] phy: freescale: imx8m-pcie: facing pcie link-up instability
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: linux-phy@lists.infradead.org, linux-imx@nxp.com, 
	Lucas Stach <l.stach@pengutronix.de>, linux-arm-kernel@lists.infradead.org, 
	kernel@pengutronix.de, Richard Zhu <hongxing.zhu@nxp.com>, linux-kernel@vger.kernel.org, 
	Marcel Ziswiler <marcel.ziswiler@toradex.com>, Heiko Stuebner <heiko@sntech.de>, 
	Kishon Vijay Abraham I <kishon@kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>, Rob Herring <robh@kernel.org>, 
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, 
	Tim Harvey <tharvey@gateworks.com>, Vinod Koul <vkoul@kernel.org>, 
	Yang Li <yang.lee@linux.alibaba.com>, imx@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Marcel,

On Fri, Mar 22, 2024 at 10:07=E2=80=AFAM Marcel Ziswiler <marcel@ziswiler.c=
om> wrote:
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
>
> In our automated testing setup, we use Delock Mini-PCIe SATA cards [1].
> While this setup has proven very stable overall we noticed upstream on
> the i.MX8M Mini fails quite regularly (about 50/50) to bring up the PCIe
> link while with NXP's downstream BSP 5.15.71_2.2.2 it always works. As
> that old downstream stuff was quite different, I first also tried NXP's
> latest downstream BSP 6.1.55_2.2.0 which from a PCIe point of view is
> fairly vanilla, however, also there the PCIe link-up was not stable.
> Comparing and debugging I noticed that upstream explicitly configures
> the AUX_PLL_REFCLK_SEL to I_PLL_REFCLK_FROM_SYSPLL while working
> downstream [2] leaving it at reset defaults of AUX_IN (PLL clock).
> Unfortunately, the TRM does not mention any further details about this
> register (both for the i.MX 8M Mini as well as the Plus). Maybe somebody
> from NXP could further comment on this?
>
> BTW: On the i.MX 8M Plus we have not seen any issues with PCIe with the
> exact same setup which is why I left it unchanged.
>
> [1] https://www.delock.com/produkt/95233/merkmale.html
> [2] https://github.com/nxp-imx/linux-imx/blob/lf-5.15.71-2.2.0/drivers/pc=
i/controller/dwc/pci-imx6.c#L1548

The detailed information above is important. It should be in the
commit log of the patch IMHO.

Thanks for the fix.