Received: by 2002:a05:7208:70d5:b0:7f:5597:fa5c with SMTP id q21csp1305002rba; Fri, 22 Mar 2024 09:53:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXCKeWKPrYTqQbfJc6bxX8wUQ2lDxCnVl/tDYko878meHMgBT+FRxDiBNkPKLtxQ+Eki3LkGVLXo4eVxSaMvakQcMdes3+E7EaKhBgJ4A== X-Google-Smtp-Source: AGHT+IFPWdOrzxVfYrIaE+Z9FWd796HTwZ3SRfCFNaHLbhtXY/ZyunOro3DKWnv6VaXBoqV2HCfC X-Received: by 2002:a9d:7a54:0:b0:6e5:3134:1108 with SMTP id z20-20020a9d7a54000000b006e531341108mr178676otm.38.1711126383815; Fri, 22 Mar 2024 09:53:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711126383; cv=pass; d=google.com; s=arc-20160816; b=YdwCVls7GcEx5S0RzQcNV5rL5l2oH7Rr1qWqAgnxw3SWhFRK86w3D4srYzaamMts9l 0wRlFqxsvr9B2oEpQ03j2Bq6abiM9k29URh5QHEAsP93ebHb7dWsQjz9FivzIrzcZRr1 uAoAVYO2RN76bTrjawHkd2jTmFgSW0o3D/919iN+21DXFZ21FMI7dqEfbrZZepw9rTLo yXhqZR7U30+FBph4gXRT60Q18+8B+XbzjQn8M7wvkzLxFE84UDlkZ9W+uOMpXlw7/NxD S8gq7ifsBxDphtSjqrryWxNVxtZHJCiXJJksNmE8Oajkq0+6T/IJuJaqbv2spqTeaacP arfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=2MEvpbcjD55OPVHZv1k/P6RoxHeXbs2ZBZ6egLEjNfc=; fh=Ybqzib7VvyNw0H6IRXAkoWQJMJZhcT0LA+Wn4AzKnx8=; b=ukm1u7IAM3l8jskOulg8dCr4fr6VnsrrhTdYZ0a/Gc0qC7L5mRjzU8tJaDhexr4C0V 1K9g3u+5V03IFGKFG9MaAn2m8uloPwsvK1ajacWQ2JmO6q+K9TkIKitBjFdhZx16hf5E 7qascPjGGoXDn4IaIwiY1cU8FyvmujFRUzlgJYrK0giTHDNoG26ITiUocKGQbtM3rf1a iJMYXDAulpLNISQOEKsQtPO5CN1ZOPRwNifiW1vyqOWsPWX9id+xY4AG+EPD9LMziqfh PcnApxqjvcqwVo+oWQXY6RomOmXz3bapbpaTRR1vAF3ovkxiej4807r3WT+ZXjrw/sG1 2GNg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=DfypVfih; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-111810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111810-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h10-20020a05620a244a00b00789efda569esi2636002qkn.22.2024.03.22.09.53.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 09:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-111810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=DfypVfih; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-111810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-111810-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8CCB71C2208B for ; Fri, 22 Mar 2024 16:53:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0239C5FBA1; Fri, 22 Mar 2024 16:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DfypVfih" Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EE05D47A for ; Fri, 22 Mar 2024 16:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711126370; cv=none; b=uI6ahPFcemvRO2w/64lBfVITvlA7UUzk9feVK1s8uuCIesfbv/8kwx1Tnjvmqgw5spwoIxv7cXhHVrfuRxikc4JqM8mD+gbWYzi91VNlsAIsBDzpjMI4eCQ0wGQIS1RICpM2ELvKwJ3POaUZJXgS7EJNgZGPI8exL268KI3K9Ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711126370; c=relaxed/simple; bh=0ghGhHkYB5a3QE//W4UnFTfqJRNvrjDLfq9w7NmbnE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ec+MmrH7U8z5o0u95B+ovH/ZUC2dSd26fPuCcUUheozw3kKjC3PgUPPVefc3DnmjCaq40kZm7M2jsOc4fZmJR8b8q9dtcvAwOidcNQ2+bx6/tIbsVk2woDwp88JSCp+yF8hLAQg99Dp5ef3HcefmVfpPBfQr4BeS/XJRGwsdJMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DfypVfih; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-78a2093cd44so187327885a.0 for ; Fri, 22 Mar 2024 09:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711126366; x=1711731166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2MEvpbcjD55OPVHZv1k/P6RoxHeXbs2ZBZ6egLEjNfc=; b=DfypVfihvSjfHp0uF+n+R3ynH5q+gqbjWBIReNQegtnnKc0zH8uutBbwtUnV4wiC2K ocauUFi86+dTyiCUHnG7zBNy/j7yU5+mwsZ/idS12W55JK5Rfzf10U+pYdCF6kYPTVMC QtmGnALiah2V96fdSrsOPQbXjtu5wJHjkb1OgO0gZNDWrJ8agkO0NDBLtD26RF2Dkh44 csLjUxirk12G3eelgZApK3tzm6a9fd5ljhNkVsaQV4ZlmP0bVC3QJd50HdQuv2sR0VV7 OsUNSS2YEPj8xwr8tnolZUEgepZa5DkLQ9v01GFdEF00H2ka/p9cml47jGlxctk8v0SC rnTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711126366; x=1711731166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2MEvpbcjD55OPVHZv1k/P6RoxHeXbs2ZBZ6egLEjNfc=; b=BX8+P7VOpxVFLjyXzHZe1q5NhRUxMWXi4DrEkdWQ4BVKfqGeMpqTANoYlLlD5XmBi2 y38jT+eguvlz5dvCQ14IAhT6rIM4m3IT+5alPlJzqkr5WkaZeidNmn6wzu3PkKFCNdu/ xxFgfyoI2dK8iMpoGLiA1Sq06Zb7Iyzz9a8d9xCx8qKKuUi2LzwkuLTNqoEU7LXULVY2 fhMLHGcXnexvZDRtZ8044o+fw3OPov/V7CYfNH+UT+Bta9SOdTxjQZXROsviaMGbmwGE yMYnKCAytb/XUfHE2HMdK1J2JtHYVFmjeGmOVu7Hvu6nLA0kxJ7y9J3UAU/vZefqDHJt lt8w== X-Gm-Message-State: AOJu0YyTwesn/pkUDU0TfH807KZKCzwEqCCDzInY8sXh7bQ532erBnQS onCGhQs54aQoUduCGcqD4FJmLrhG1g1dW2ZeW6jdgnAtsqTfYX4q7O+Rtfc= X-Received: by 2002:a05:620a:2af1:b0:78a:3225:60c4 with SMTP id bn49-20020a05620a2af100b0078a322560c4mr2512675qkb.53.1711126366579; Fri, 22 Mar 2024 09:52:46 -0700 (PDT) Received: from citadel.lan (2600-6c4a-4d3f-6d5c-0000-0000-0000-1019.inf6.spectrum.com. [2600:6c4a:4d3f:6d5c::1019]) by smtp.gmail.com with ESMTPSA id j1-20020a37ef01000000b00789e9bbf962sm894901qkk.133.2024.03.22.09.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 09:52:45 -0700 (PDT) From: Brian Gerst To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , "H . Peter Anvin" , Uros Bizjak , David.Laight@aculab.com, Brian Gerst Subject: [PATCH v4 01/16] x86/stackprotector/32: Remove stack protector test script Date: Fri, 22 Mar 2024 12:52:18 -0400 Message-ID: <20240322165233.71698-2-brgerst@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240322165233.71698-1-brgerst@gmail.com> References: <20240322165233.71698-1-brgerst@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Test for compiler support directly in Kconfig. Signed-off-by: Brian Gerst --- arch/x86/Kconfig | 2 +- scripts/gcc-x86_32-has-stack-protector.sh | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100755 scripts/gcc-x86_32-has-stack-protector.sh diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 03483b23a009..f326903cbe67 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -412,7 +412,7 @@ config PGTABLE_LEVELS config CC_HAS_SANE_STACKPROTECTOR bool default $(success,$(srctree)/scripts/gcc-x86_64-has-stack-protector.sh $(CC) $(CLANG_FLAGS)) if 64BIT - default $(success,$(srctree)/scripts/gcc-x86_32-has-stack-protector.sh $(CC) $(CLANG_FLAGS)) + default $(cc-option,-mstack-protector-guard-reg=fs -mstack-protector-guard-symbol=__stack_chk_guard) help We have to make sure stack protector is unconditionally disabled if the compiler produces broken code or if it does not let us control diff --git a/scripts/gcc-x86_32-has-stack-protector.sh b/scripts/gcc-x86_32-has-stack-protector.sh deleted file mode 100755 index 825c75c5b715..000000000000 --- a/scripts/gcc-x86_32-has-stack-protector.sh +++ /dev/null @@ -1,8 +0,0 @@ -#!/bin/sh -# SPDX-License-Identifier: GPL-2.0 - -# This requires GCC 8.1 or better. Specifically, we require -# -mstack-protector-guard-reg, added by -# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81708 - -echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -m32 -O0 -fstack-protector -mstack-protector-guard-reg=fs -mstack-protector-guard-symbol=__stack_chk_guard - -o - 2> /dev/null | grep -q "%fs" -- 2.44.0