Received-SPF: pass (google.com: domain of linux-kernel+bounces-111912-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <82d9de6c-a76f-61e9-02bd-f74beb87166e@amd.com>
Date: Fri, 22 Mar 2024 13:05:45 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 0/2] Fixes for recent x86/boot rip-relative addressing
 changes
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>
References: <cover.1711122067.git.thomas.lendacky@amd.com>
 <CAMj1kXGUZAzBQMzZOsZaYuaGfAn4AHv1FMzZT9vvHCU3aAjcfg@mail.gmail.com>
Content-Language: en-US
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <CAMj1kXGUZAzBQMzZOsZaYuaGfAn4AHv1FMzZT9vvHCU3aAjcfg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OWxuTU9VWDNmTzBmQllIQ2tyWmJ1TjZSR0U5TGtsdkk2MzdJQ0s2L3A0cjFY?=
 =?utf-8?B?NTE4QStiblhlc2ttNFVjVmFUWUVzUUtxZFcremZFMExQQUcvTVV1Y2pOd3hI?=
 =?utf-8?B?Rk5ISG5YYkRxV0lpeDhnYk05MVhSTW5WR3RzZllKTlM2U3E2QXdEZ3RCVE4w?=
 =?utf-8?B?R2c1Z1g5NHUzYnpvTS9nSzlRMGVuV0R1NTdkQXN4YS83cS9ENHJQdDNiMG5q?=
 =?utf-8?B?OFNXd0RvblB2dXIvd00zSFJPT2pOUHltc010YUdHdFhkazIyODVSYW1YTU9Z?=
 =?utf-8?B?UVJzTTBnNlUrTzQyWXVCNWRQSTFOUDkvQ1p5cHBIZHB0ZzYrUFZqSmNrbWRa?=
 =?utf-8?B?cy9CblgyQ3ZGenZBcC9KRzRZOFpMUlBaMGdDRWN1NWRSSjgxZmR2V25HdWhX?=
 =?utf-8?B?ZmxMb0hSWWNTTW1wRytLTWpYbVhRRFk2ZStYRVNSMkR1YUNWMy9xbU8xOU5i?=
 =?utf-8?B?TGwyeTBkblQwTGxjRHpiandkZXFCWVZHY2pZOWREVE43Yjd5NTlLZlF2MnRn?=
 =?utf-8?B?TUxQMU1OOG03Nm1lZUZ3MG5uMUdWazZabTErdTlyU1FOTStHWDJDUmt3bkVP?=
 =?utf-8?B?TDRqUmRxa1RqdDRzMHU1VGxjcnJxejNEWlVIclVPc21LbEIxb0JwcVF5bk9W?=
 =?utf-8?B?L0NLWXU5OHJaczE0endEYTUwcE9QelI0VmUwQXB6N0NScFhVTlh2ejJ6R1Yx?=
 =?utf-8?B?Wmo2SGpOc3N6N3FwOWxiU0R2YW54eFFlMWlmamdMRTE2KzZhVE1kMXIvbFA3?=
 =?utf-8?B?RjNJUmk5cEFiN1lwNk5hd0RoVkZCR3hycjFqTjBVUFQ0Zk5OTFRtSlExUXhK?=
 =?utf-8?B?amRNanRRVHFqN3l0OWY5ZUdWMmw5R0lUK0dabXowM0hVeW1vbEZQcVBDaG1M?=
 =?utf-8?B?SlNZcTlXZUdyRG84b3NiUzBDemVjR2pzcGp3bkViQkJyQnlPamZuaWptd0lN?=
 =?utf-8?B?OGZzZmtnT0dzcGp6RzVtL1BvbTNLVUxpNE9xSytRYkRqSEpvY1p1aVpHVTA0?=
 =?utf-8?B?MHhOUEZOV21HU1pDU0tQdldWc2NUdlNQRUwxVlVyS2pGWCsyR251SVJweDdC?=
 =?utf-8?B?a1ZUV3laZUJXTDVmL1VsaENBL01RbXhzY0lBRzQ1N2tXSHRUL1NpZUl1LzVE?=
 =?utf-8?B?bFJ3UjhEYkJkVDNERFQ1dHlrajdMS1REdXgvSUdTQVZyRm4xMW5FMXNoYUZv?=
 =?utf-8?B?d3F5c002bEttcDdFdnpZMWsrUUpNclZidUp1a3NTTVovTENWc1RYYksyay83?=
 =?utf-8?B?aFRlMDVtMERlQ0pFSkJPNnVWUUxlSmJnajR6WUFNVy9MU1lhZnUxc3c2VkZM?=
 =?utf-8?B?MnZpVjFobmVjVVB2dVJDRGp4K3Z6all0SnZ5ektCd0xERTA0dzBad1JGN1B6?=
 =?utf-8?B?dDFVNnI4Rmo5SHBxQWJqeDhnbVNUdVhienE4QjRKNC9TNGVLYTRVUld6cW9K?=
 =?utf-8?B?OWg1Z2s1cm4xVmpkck9mM1U4N1l3cXE1OWpUTkhNOHUvamRCdWt3clhzdC9y?=
 =?utf-8?B?UHJuWFdFMTNjSk5ySzBRZG9mM21Ib3ZMQUJoRjhjZWFQNXYreEJNNGg5eGRY?=
 =?utf-8?B?Tm8zaFQyQWRNZVpXLzdMRUw1dlJhMmJjN293WnlmVWZEaG1lcC9CNzBWcjY0?=
 =?utf-8?B?NVFNNlVLUVlSa09mckYwWXRoWWFsYmd0OWZoSHpmUW1odGkvUmZxVXgxLzBs?=
 =?utf-8?B?MlVQMmlhUG4ycXozRHhzOWUyeTlSYVpUbXdrR2o5RVNMa2V2SlBXcjk0OTZp?=
 =?utf-8?B?VFh3QnA2c3RjT0Q4dVo3czNvK3hRMGRNc3NHNVNGaW1UK3U0c20rcGY0MXZK?=
 =?utf-8?B?M2NkQzh6bnExQXFwMnVORXdQN2hxOThRSDR2MlYyc2piWG9qOTZrdHBNU0dX?=
 =?utf-8?B?QTRHR2x3TU9Ka3RMSm5Dekc1TmRMcFQ1WGdnL08zU3FQV2ZiQ1VMM1BteDQw?=
 =?utf-8?B?ZUw0U1hYVktoWFVFSGJJUmQwaDgzSlpKcEx5SEMzRUQ4QlJ0dnJ3UjA3K25z?=
 =?utf-8?B?K0NxZGl5citKbGppYkVCUUNqZmZxb08xYklSZWRmS1BOY0NUc0tNM3Fhc1pR?=
 =?utf-8?B?T2tLRVkvL2VZWFIyWHNidEJhOTkvb2hzWEhoS3F3ZEJoZnJqbkNZMjg2d2lq?=
 =?utf-8?Q?UET4GDNgDR1KKPOoKuWplf6wz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74255aa2-0eeb-4591-d468-08dc4a9ab3c0
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 18:05:48.2173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qnvK2hWdgXxtugwbYsbdoZwUasq0CGI5NqJwIdeaCOe0decPT2V6f1KeFev1F++uqmGsCHGtkfWEiFirvNdZmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB9050

On 3/22/24 11:10, Ard Biesheuvel wrote:
> On Fri, 22 Mar 2024 at 17:41, Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> This patch series provides fixes for the recent x86/boot rip-relative
>> addressing changes that causes system crashes when booting with 5-level
>> pagetables and SME active.
>>
>> I thought I had tested 5-level paging with SME, but must have missed
>> it. There are two patches to fix the issues that can be squashed into
>> a single patch with multiple Fixes: tags if desired.
>>
> 
> Perhaps you tested the entire series, where the final patch removed
> those variables altogether?

Maybe, but that wouldn't explain the first fix in the series. I should've 
encountered an issue no matter what. I probably used the wrong config file 
or ...  who knows at this point.

Thanks,
Tom

> 
>> The second patch is sort of a revert, but instead uses the newer
>> RIP_REL_REF() macro instead of reverting the fix and continuing to use
>> the fixup_pointer() support.
>>
> 
> Thanks for fixing this.
> 
> Series
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>