Received-SPF: pass (google.com: domain of linux-kernel+bounces-111915-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Steve Wahl <steve.wahl@hpe.com>,  Dave Hansen
 <dave.hansen@linux.intel.com>,  Andy Lutomirski <luto@kernel.org>,  Peter
 Zijlstra <peterz@infradead.org>,  Thomas Gleixner <tglx@linutronix.de>,
  Ingo Molnar <mingo@redhat.com>,  Borislav Petkov <bp@alien8.de>,
  x86@kernel.org,  "H. Peter Anvin" <hpa@zytor.com>,
  linux-kernel@vger.kernel.org,  Linux regressions mailing list
 <regressions@lists.linux.dev>,  Pavin Joseph <me@pavinjoseph.com>,
  stable@vger.kernel.org,  Eric Hagberg <ehagberg@gmail.com>,  Simon Horman
 <horms@verge.net.au>,  Dave Young <dyoung@redhat.com>,  Sarah Brofeldt
 <srhb@dbc.dk>,  Russ Anderson <rja@hpe.com>,  Dimitri Sivanich
 <sivanich@hpe.com>
References: <20240322162135.3984233-1-steve.wahl@hpe.com>
	<003f1e83-fd93-4f4f-a316-d3e89e5a23a5@intel.com>
Date: Fri, 22 Mar 2024 12:31:40 -0500
In-Reply-To: <003f1e83-fd93-4f4f-a316-d3e89e5a23a5@intel.com> (Dave Hansen's
	message of "Fri, 22 Mar 2024 09:27:54 -0700")
Message-ID: <87le6ab2bn.fsf@email.froward.int.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH] x86/mm/ident_map: Use full gbpages in identity maps
 except on UV platform.

Dave Hansen <dave.hansen@intel.com> writes:

> On 3/22/24 09:21, Steve Wahl wrote:
>> Some systems have ACPI tables that don't include everything that needs
>> to be mapped for a successful kexec.  These systems rely on identity
>> maps that include the full gigabyte surrounding any smaller region
>> requested for kexec success.  Without this, they fail to kexec and end
>> up doing a full firmware reboot.
>> 
>> So, reduce the use of GB pages only on systems where this is known to
>> be necessary (specifically, UV systems).
>
> Isn't this called "buggy firmware"?
>
> I'd much rather add synthetic entries to the memory maps that have this
> information than hack around it by assuming that things are within a
> gigabyte.

So this change is a partial revert of a change that broke kexec in
existing configurations.  To fix a regression that breaks kexec.

I don't have enough to know which systems broke.  So I don't know
the difficulty in fixing systems.

Dave do you know what synthetic entries need to be added to the
memory maps to fix the regression?  If not we should go with this
and if we care enough we can add the synthetic entries later.

Eric