Received-SPF: pass (google.com: domain of linux-kernel+bounces-111944-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <e744b564-e5d2-48d3-91fb-8178344baf85@amd.com>
Date: Fri, 22 Mar 2024 13:28:10 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 andersson@kernel.org, mathieu.poirier@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 michal.simek@amd.com, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240315211533.1996543-1-tanmay.shah@amd.com>
 <20240315211533.1996543-3-tanmay.shah@amd.com>
 <3ca1c419-d185-4318-92ed-3c4e40dcf5bb@linaro.org>
 <14be0aa6-49b7-4342-9ca6-750c30c8e1e9@amd.com>
 <b1320ddf-bacb-41e3-9709-e90df18cc1e3@linaro.org>
 <d112481b-4331-4c0c-9775-407ac4a601fb@amd.com>
 <6f2ebe09-8ce5-4388-a01a-84ebc271472e@linaro.org>
 <72f3caa2-30ec-4191-9477-2d2a5e7f2f4b@amd.com>
 <5025fb10-3bcc-43b1-ae85-b556f1c0415f@linaro.org>
 <091c5ff9-dce9-4c63-a2ca-39d570e2f0a5@amd.com>
 <b224cd7e-ebd0-41ef-b1e2-64f76d246307@linaro.org>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <b224cd7e-ebd0-41ef-b1e2-64f76d246307@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVNzY2plQUNSTXdGbTBDSy9icUYyTG14ZjY4eG9WeVppOXoxZk5QOXQrKytM?=
 =?utf-8?B?ZmVxaGZVNjhnSFQ3WldZM0tJb2dTZDg1K2hQRFVSTEtrNmVscmp5em42Uk45?=
 =?utf-8?B?K28wa2NxdzltQ0VvTFU1d0s4MEpDVlZsak91eGc5SUJuUVlzQUJUVExjc0l6?=
 =?utf-8?B?Y0x2QXhxQVVXSjNidlNJaWVqY0lZYkJqN1VTK0k4aWdFV1lTVERXYVVicU9T?=
 =?utf-8?B?dDlrRWJaNTVicDlMaUk2T2VBcE9HRU4vU0pRS0FwRUZhL0oxaUxMK1ZZQ2wr?=
 =?utf-8?B?K1pKWkR0K1FFM3Zmb044UnNXUTA2VHZpbks5L1RrbkVMQVVmWlBQRndQWjM0?=
 =?utf-8?B?TGxtVE8zb25aS1hxbHJ5Y25IeXorU0YxaGs4Nk1QdEcwa1VZUi9WWmRUNjhT?=
 =?utf-8?B?ZkNTL0YxL3hXcmJhaFFJN0c5Z1dBa1lyZEk4dGZpMjQ3ZWVmcjRoK01FeWdZ?=
 =?utf-8?B?bTBOY2QzTDZuaVJtdXdMUzhubDRZWjVDRmRzVEdwVThibUV6QlRxbnVhR0ll?=
 =?utf-8?B?ZFNBQlF6VVg5R2JBUGsvb2Y4Wm82NFV6NFJIbUVaUjNBM2MrdlhFQUcra1FZ?=
 =?utf-8?B?R1hEcU1xMUhmVVkvalY0alh1MWtTNlovNHRrMDdVbzNKb1Y0VzlSaE1pVlN4?=
 =?utf-8?B?dW1HQ25kN1RCaUJuSmptanBEd3RHWDZGb0hUMW1laWZyZGJENkJoSnkzQjVu?=
 =?utf-8?B?eHNmSGhVSm1KT2c2NWFWVTBYenBGeUlzNHNYM1R6b21KV24rNWtSS2dnQ1No?=
 =?utf-8?B?WnJsWGRLaFBub0ZiL3Z6NTlJYklCRjBYV3E1YkU4ZFdYZjVhSHVXa0hrQzdL?=
 =?utf-8?B?bmMySEF2U1lNNUpDYXFiaU8zODRPYU1lYjFyMzZab1ovSW9oaTFSU1ZnZ3FT?=
 =?utf-8?B?VmlTZkI2Y0M0RWxGcUdjNE95bEZJSFZpMkRsVFMrWXluUml2NklRY0h1ZnRu?=
 =?utf-8?B?dmp2aW1XbS9ha3JNT3F1cmtWYTlBVG9qc1d3S2g0TWpheU0zNmttYzF4V1pn?=
 =?utf-8?B?dEhHR1VlbitpWG1zS01TdnUxbVJURmpLTmI5ZFpYUTlqcWVXdGlqMWtmTE5i?=
 =?utf-8?B?QU1EVFdyS2czSXEwdVlFb2F4MCtIaVhxREJtTzcrUjNlOWt1dGVodVc4Ty8y?=
 =?utf-8?B?alNGVnRzdTc2bCtzemRKMG1maFByaWtrVUVuSUFoOGJuTlJwQ2hCbmVMeW82?=
 =?utf-8?B?eUZtRE0xQnlGci8vMmZDbjZDdmNIdkdmYUc4ODh5bndDRE9FejB3b1EwNDNk?=
 =?utf-8?B?Nnp4TTRGQjhTNGpEclJuNDJrN3QwSGVqLzlZL0hXdmFELzdZeE9ycS9rUlZC?=
 =?utf-8?B?L2ZFcVZweE9HM2FuWFF1eklrd1NKT0hEU1ZYbkNpVHpvcm91ejlGYlNUY1F5?=
 =?utf-8?B?K0U5QVREUVc2TDQ3S1BBdE9XbWM1RzczZ3pJK2VSemRFdGZPbFZscFYyWDN1?=
 =?utf-8?B?ZGJSVnVvRmlDU05ja3lRQWZOdXIrd2ROdjdhQUNsYlZyb0JXVjdlRjVDYzhj?=
 =?utf-8?B?NVBMMThDZWxJRUUyWjlWZnN5ekErSU9tUStycElRUVExaTlNb1dIOGE0dzVp?=
 =?utf-8?B?QTkxSi9GVzZFTDVMS3I2VE1naDB2QUNxVmo0OEdQdlFqNFZjQ3BqMklqQjBB?=
 =?utf-8?B?Z2l4aUpVM0ZPalQ3UzJRWjJDUTFhOUFOSEJiaitXbzhxTFZVbnJqcWkwNS9E?=
 =?utf-8?B?MGZDemlqdDBicHRIcjdhR0J2SzA5TGQwWmg4ZkRyeEdEWm5icmRVUXVKTU9n?=
 =?utf-8?B?VEpXdStDOTFQUkhsTjVzbElvQklCTDJkU0tTcGFBU3c0MlhTakhDeTcyNk9t?=
 =?utf-8?B?YXdEQ3Nwa1pqSlZOQ2Ntb0t5TVBpWWdOcTIxaFovY0N0ODE5K1Z4M05jdUI5?=
 =?utf-8?B?SERKcktwUmdrUytjajhaRmdnL0puaWYwM0JUbDdGeVlHU0NhRFJQdHgwZG1p?=
 =?utf-8?B?dVNvRXBMMkc2WFU2VEZaaWhxUWhOV2hKblZqRUN4eE5oUkoraFhUSUNiaVZo?=
 =?utf-8?B?ZmpuSXdFRVhGQ05KbFF2UmVITFdtOVIvazFURUloRmRqSXBMRGJ3NlcxVFZJ?=
 =?utf-8?B?aXNSbDgremxkRkcySDY0K2dDMFlQRlJybnlIQ3BSaGJibEhkak5WTUdsYnA4?=
 =?utf-8?Q?OkKsrQduhy1iEuPxopY/JlosS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b09db3d-7b71-43b5-5049-08dc4a9dd5c5
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 18:28:13.7969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OVx9bd2tddfr9igRoWn9WDKoL8Py6j3SZ5E+KEy1CqJoMWpPBkMZtbeKnk5XnFos
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8295


On 3/22/24 12:44 AM, Krzysztof Kozlowski wrote:
> On 21/03/2024 16:13, Tanmay Shah wrote:
>> 
>> 
>> On 3/21/24 2:39 AM, Krzysztof Kozlowski wrote:
>>> On 20/03/2024 16:14, Tanmay Shah wrote:
>>>>
>>>>
>>>> On 3/20/24 2:40 AM, Krzysztof Kozlowski wrote:
>>>>> On 19/03/2024 15:42, Tanmay Shah wrote:
>>>>>>
>>>>>>
>>>>>> On 3/19/24 12:30 AM, Krzysztof Kozlowski wrote:
>>>>>>> On 19/03/2024 01:51, Tanmay Shah wrote:
>>>>>>>> Hello Krzysztof,
>>>>>>>>
>>>>>>>> Thanks for reviews. Please find my comments below.
>>>>>>>>
>>>>>>>> On 3/17/24 1:53 PM, Krzysztof Kozlowski wrote:
>>>>>>>>> On 15/03/2024 22:15, Tanmay Shah wrote:
>>>>>>>>>> AMD-Xilinx Versal-NET platform is successor of Versal platform. It
>>>>>>>>>> contains multiple clusters of cortex-R52 real-time processing units.
>>>>>>>>>> Each cluster contains two cores of cortex-R52 processors. Each cluster
>>>>>>>>>> can be configured in lockstep mode or split mode.
>>>>>>>>>>
>>>>>>>>>> Each R52 core is assigned 128KB of TCM memory. ATCM memory is 64KB, BTCM
>>>>>>>>>> and CTCM memoreis are 32KB each. Each TCM memory has its own dedicated
>>>>>>>>>> power-domain that needs to be requested before using it.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>>>>>>>>>> ---
>>>>>>>>>>  .../remoteproc/xlnx,zynqmp-r5fss.yaml         | 220 +++++++++++++++---
>>>>>>>>>>  1 file changed, 184 insertions(+), 36 deletions(-)
>>>>>>>>>>
>>>>>>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
>>>>>>>>>> index 711da0272250..55654ee02eef 100644
>>>>>>>>>> --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
>>>>>>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
>>>>>>>>>> @@ -18,7 +18,9 @@ description: |
>>>>>>>>>>  
>>>>>>>>>>  properties:
>>>>>>>>>>    compatible:
>>>>>>>>>> -    const: xlnx,zynqmp-r5fss
>>>>>>>>>> +    enum:
>>>>>>>>>> +      - xlnx,zynqmp-r5fss
>>>>>>>>>> +      - xlnx,versal-net-r52fss
>>>>>>>>>>  
>>>>>>>>>>    "#address-cells":
>>>>>>>>>>      const: 2
>>>>>>>>>> @@ -64,7 +66,9 @@ patternProperties:
>>>>>>>>>>  
>>>>>>>>>>      properties:
>>>>>>>>>>        compatible:
>>>>>>>>>> -        const: xlnx,zynqmp-r5f
>>>>>>>>>> +        enum:
>>>>>>>>>> +          - xlnx,zynqmp-r5f
>>>>>>>>>> +          - xlnx,versal-net-r52f
>>>>>>>>>>  
>>>>>>>>>>        reg:
>>>>>>>>>>          minItems: 1
>>>>>>>>>> @@ -135,9 +139,11 @@ required:
>>>>>>>>>>  allOf:
>>>>>>>>>>    - if:
>>>>>>>>>>        properties:
>>>>>>>>>> -        xlnx,cluster-mode:
>>>>>>>>>> -          enum:
>>>>>>>>>> -            - 1
>>>>>>>>>> +        compatible:
>>>>>>>>>> +          contains:
>>>>>>>>>> +            enum:
>>>>>>>>>> +              - xlnx,versal-net-r52fss
>>>>>>>>>
>>>>>>>>> Why do you touch these lines?
>>>>>>>>>
>>>>>>>>>> +
>>>>>>>>>>      then:
>>>>>>>>>>        patternProperties:
>>>>>>>>>>          "^r5f@[0-9a-f]+$":
>>>>>>>>>> @@ -149,16 +155,14 @@ allOf:
>>>>>>>>>>                items:
>>>>>>>>>>                  - description: ATCM internal memory
>>>>>>>>>>                  - description: BTCM internal memory
>>>>>>>>>> -                - description: extra ATCM memory in lockstep mode
>>>>>>>>>> -                - description: extra BTCM memory in lockstep mode
>>>>>>>>>> +                - description: CTCM internal memory
>>>>>>>>>>  
>>>>>>>>>>              reg-names:
>>>>>>>>>>                minItems: 1
>>>>>>>>>>                items:
>>>>>>>>>> -                - const: atcm0
>>>>>>>>>> -                - const: btcm0
>>>>>>>>>> -                - const: atcm1
>>>>>>>>>> -                - const: btcm1
>>>>>>>>>> +                - const: atcm
>>>>>>>>>> +                - const: btcm
>>>>>>>>>> +                - const: ctcm
>>>>>>>>>>  
>>>>>>>>>>              power-domains:
>>>>>>>>>>                minItems: 2
>>>>>>>>>> @@ -166,33 +170,70 @@ allOf:
>>>>>>>>>>                  - description: RPU core power domain
>>>>>>>>>>                  - description: ATCM power domain
>>>>>>>>>>                  - description: BTCM power domain
>>>>>>>>>> -                - description: second ATCM power domain
>>>>>>>>>> -                - description: second BTCM power domain
>>>>>>>>>> +                - description: CTCM power domain
>>>>>>>>>>  
>>>>>>>>>>      else:
>>>>>>>>>> -      patternProperties:
>>>>>>>>>> -        "^r5f@[0-9a-f]+$":
>>>>>>>>>> -          type: object
>>>>>>>>>> -
>>>>>>>>>> -          properties:
>>>>>>>>>> -            reg:
>>>>>>>>>> -              minItems: 1
>>>>>>>>>> -              items:
>>>>>>>>>> -                - description: ATCM internal memory
>>>>>>>>>> -                - description: BTCM internal memory
>>>>>>>>>> -
>>>>>>>>>> -            reg-names:
>>>>>>>>>> -              minItems: 1
>>>>>>>>>> -              items:
>>>>>>>>>> -                - const: atcm0
>>>>>>>>>> -                - const: btcm0
>>>>>>>>>> -
>>>>>>>>>> -            power-domains:
>>>>>>>>>> -              minItems: 2
>>>>>>>>>> -              items:
>>>>>>>>>> -                - description: RPU core power domain
>>>>>>>>>> -                - description: ATCM power domain
>>>>>>>>>> -                - description: BTCM power domain
>>>>>>>>>> +      allOf:
>>>>>>>>>> +        - if:
>>>>>>>>>> +            properties:
>>>>>>>>>> +              xlnx,cluster-mode:
>>>>>>>>>> +                enum:
>>>>>>>>>> +                  - 1
>>>>>>>>>
>>>>>>>>> Whatever you did here, is not really readable. You have now multiple
>>>>>>>>> if:then:if:then embedded.
>>>>>>>>
>>>>>>>> For ZynqMP platform, TCM can be configured differently in lockstep mode
>>>>>>>> and split mode.
>>>>>>>>
>>>>>>>> For Versal-NET no such configuration is available, but new CTCM memory
>>>>>>>> is added.
>>>>>>>>
>>>>>>>> So, I am trying to achieve following representation of TCM for both:
>>>>>>>>
>>>>>>>> if: versal-net compatible
>>>>>>>> then:
>>>>>>>>   ATCM - 64KB
>>>>>>>>   BTCM - 32KB
>>>>>>>>   CTCM - 32KB
>>>>>>>>
>>>>>>>> else: (ZynqMP compatible)
>>>>>>>>   if:
>>>>>>>>     xlnx,cluster-mode (lockstep mode)
>>>>>>>>   then:
>>>>>>>>     ATCM0 - 64KB
>>>>>>>>     BTCM0 - 64KB
>>>>>>>>     ATCM1 - 64KB
>>>>>>>>     BTCM1 - 64KB
>>>>>>>>   else: (split mode)
>>>>>>>>     ATCM0 - 64KB
>>>>>>>>     BTCM0 - 64KB
>>>>>>>>
>>>>>>>>
>>>>>>>> If bindings are getting complicated, does it make sense to introduce
>>>>>>>> new file for Versal-NET bindings? Let me know how you would like me
>>>>>>>> to proceed.
>>>>>>>
>>>>>>> All this is broken in your previous patchset, but now we nicely see.
>>>>>>>
>>>>>>> No, this does not work like this. You do not have entirely different
>>>>>>> programming models in one device, don't you?
>>>>>>>
>>>>>>
>>>>>> I don't understand what do you mean? Programming model is same. Only number
>>>>>> of TCMs are changing based on configuration and platform. I can certainly
>>>>>> list different compatible for different platforms as requested. But other than
>>>>>> that not sure what needs to be fixed.
>>>>>
>>>>> You cannot have same programming model with different memory mappings.
>>>>> Anyway, please follow writing bindings rules: all of your different
>>>>> devices must have dedicated compatible. I really though we talked about
>>>>> two IPs on same SoC...
>>>>
>>>> I agree that Versal compatible should be added, I will do that in next revision.
>>>>
>>>> For ZynqMP case, it is two IPs on same SOC. In lockstep mode and split mode,
>>>> same SOC is configuring TCM differently.
>>>>
>>>> How this should be resolved for Versal-NET ? Driver avoids such TCM configuration
>>>> for Versal-NET.
>>>
>>> Binding should describe the hardware, not what driver is doing
>>> currently, so the question is: does your device have such properties or
>>> not? Anyway, you need compatible per each variant and each SoC
>>> implementation.
>> 
>> Thanks for reviews.
>> 
>> Okay in that case I believe I should add one more property to current bindings for TCM
>> configuration.
>> 
> 
> I am not sure if you understand how IRC works... You sent me message on
> IRC about this topic and shortly after you quit. So how am I supposed to
> send reply? IRC does not work like that...
> 

Yeah, I am referring related documentation on IRC.

>> From our discussion I conclude to following next steps:
>> 
>> 1) I will send Versal and Versal-NET support as part of previous series (v14) so we get
>> bigger picture in the first place.
>> 
>> 2) Add separate compatible for versal platform.
>> Use device compatible string to maintain
>> backward compatibility and not machine (root node) compatible string.
>> 
>> 3) Add tcm,mode property in bindings and each device must configure TCM based on that
>> property only and not based on compatible string.
>> 
>> 4) Versal-NET will disallow tcm,mode property in bindings as no such configuration is
>> possible for that platform.
> 
> I really don't know your SoCs. What about Zynq? You keep using here
> names all over the place, but I am not Xilinx maintainer.
> 

Zynq doesn't have Cortex-R IP so this driver isn't needed on that.


> 
> Best regards,
> Krzysztof
>