Received-SPF: pass (google.com: domain of linux-kernel+bounces-111983-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Klymenko, Anatoliy" <Anatoliy.Klymenko@amd.com>
To: Maxime Ripard <mripard@kernel.org>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Maarten Lankhorst
	<maarten.lankhorst@linux.intel.com>, Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, "Simek,
 Michal" <michal.simek@amd.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil
 Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Jonas
 Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, Rob
 Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>, Tomi Valkeinen
	<tomi.valkeinen@ideasonboard.com>, "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-media@vger.kernel.org"
	<linux-media@vger.kernel.org>
Subject: RE: [PATCH v3 7/9] drm/atomic-helper: Add select_output_bus_format
 callback
Thread-Topic: [PATCH v3 7/9] drm/atomic-helper: Add select_output_bus_format
 callback
Thread-Index: AQHae9CO/Tr0AMCKj0CJVuI96JUP97FDg30AgACewkA=
Date: Fri, 22 Mar 2024 19:15:19 +0000
Message-ID:
 <MW4PR12MB71657AF1E6B7AC96647133D6E6312@MW4PR12MB7165.namprd12.prod.outlook.com>
References: <20240321-dp-live-fmt-v3-0-d5090d796b7e@amd.com>
 <20240321-dp-live-fmt-v3-7-d5090d796b7e@amd.com>
 <20240322-passionate-lyrebird-of-trust-819718@houat>
In-Reply-To: <20240322-passionate-lyrebird-of-trust-819718@houat>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?KwVGEThl6V86wqEtJ5G9O3uX7hgmT0GyVKgLZCMBA/BnvO6f2iW4UDohFzts?=
 =?us-ascii?Q?OQOKZlg8XR4CpWG7H1RMIYIkNKDbOhEHU3iOBiKN4Tr0ShyxGrgncUzXkzlq?=
 =?us-ascii?Q?IRPr3yjMOb8JdTmPkhzwRPiiqau4GTJc03NuVD0mDZDURgBr8Mb+0Y1QW+Ex?=
 =?us-ascii?Q?wjMBLQWnzeqBkTN6CwEEtGeJk56Q+RyUSe6UJX0ivhwPYqCFJHQ8g+9tT0OA?=
 =?us-ascii?Q?pw5kxJ5kxFj50Rj7kbN9RiKHPLsMQHw6Sby3Gs27fETEP2h9b/Ao905PVQEu?=
 =?us-ascii?Q?A2e5xorCC7UvWUlZvSHXPm8NqbFub7mplDCwGbi3lIOttjZ2d0AXoJGobJ6k?=
 =?us-ascii?Q?MBDgm7thnznKmLZuA9+qmhgWF7RTg8wtgBa/klpszrB0ZjqiJ8XTYin60Kut?=
 =?us-ascii?Q?voobEM1P0NWnv16ZHiSpp2WZq/S2RTTax3xI4TuyoYU9ncyPbQmtDiHXHykJ?=
 =?us-ascii?Q?HgJmmEZN7B+nedsxtNjF6O3KMpGpahrSm4Yy4XZ0UqLcq9nmRLUOH0GoGVBo?=
 =?us-ascii?Q?fsHlTm2OsghosQW8/tjtVRWdWJhXoNUE3+gtLp7wxETYsDPx0DC2BgPXO2lv?=
 =?us-ascii?Q?Bmv83rk+oliFgsvvYs+bcJcNfd+RoJrk1eESIH6lOIXWqkvrib5CdNidYzyz?=
 =?us-ascii?Q?P1s2kriqcwYYvYQ2sHzUikxYH+s16l4UQLpHZHyMk89szTzQ0g65x01NpY/A?=
 =?us-ascii?Q?tFHDYg2t7uQB/tG1OFUrROwaKvdExM2IcJw/w/Qr4arvucJYeYxcARiwIMoe?=
 =?us-ascii?Q?xIvU4zkAfhYDSAUTOotjd9L7uyWCfYzSnpRh9PxubKCZbWtIPPgnb24zXxgQ?=
 =?us-ascii?Q?HIHn8eATtPtymEJsMU3NHnHs/ETur/ERNHWtGHgTl0/2zweZVoL2SLa3ttVq?=
 =?us-ascii?Q?MOxsLXPurFpSzcNNIAVRDahJsPYTDrngSnHP2AVkQbhJhTg0sHcLn5QOY8wR?=
 =?us-ascii?Q?rohmbzJjMQ1amPkDMowRnKXN2++/SmlpNxhYYGl0mtxyoX4WcMflq07FPG+h?=
 =?us-ascii?Q?f5A9CnH4E+zV7GEnqGTlijDPq37d3irdERuaj+oGBaqcar+d4GKFGkreXeom?=
 =?us-ascii?Q?MfgJrmXqqcyBCaGmVQIBqtK1qUz0+4KhYmoGxJehdejnlFjeA0vnT0sdAkea?=
 =?us-ascii?Q?p0mBCA2eHTR+D/LYm16c+4iA3YGxvR3plvOOY80W/S/ozeLrsF7BkMciK2sI?=
 =?us-ascii?Q?NFacOvdojndK5pmAi3ulgsqYFRevIiSvkAsyMECw5yeRp+gnyE0nlDDrvOD0?=
 =?us-ascii?Q?WcWhITgHPZloc+8jRV1tJYo9JUVGAFPkpzcYPmnb+a7dWBJS4GWOx8Xg+0Kr?=
 =?us-ascii?Q?V+I93IKMjzL6J4dQXAxm8PTDGBkXJlFY0MOen5UpD/8Irju2ILx1VkYBHI6V?=
 =?us-ascii?Q?trdirIkDOWVKGK6qVVZFoDkfaWJ0lLiwVgzNrIqypXSalK/5/fcqo4fk39zl?=
 =?us-ascii?Q?tgYtnQZXKbRFQhxj3ehycStFkXfWX0ItI8+nn+iB6H/N7E/9oYv5HSRMJlgW?=
 =?us-ascii?Q?qymyy+Ukq+NLOt9EDO0JPI3/D06HbIeZywPtURpGTmtAXFy/aJOW0xoqZ3Jz?=
 =?us-ascii?Q?WV2kNRijHvOzoTrt6gY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7165.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c32740b9-8d54-4425-2007-08dc4aa46a08
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 19:15:19.3705
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vs3wZcdgupwdjYK7S1camPKuIyqUx+QZDc5BHPVuDuGKXlksIlnUBz978UaEKQqEU53KP/9betpyP2qnn//ANA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4116

Hi Maxime,

Thank you for the review.

> -----Original Message-----
> From: Maxime Ripard <mripard@kernel.org>
> Sent: Friday, March 22, 2024 2:45 AM
> To: Klymenko, Anatoliy <Anatoliy.Klymenko@amd.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Maarten Lankhor=
st
> <maarten.lankhorst@linux.intel.com>; Thomas Zimmermann
> <tzimmermann@suse.de>; David Airlie <airlied@gmail.com>; Daniel Vetter
> <daniel@ffwll.ch>; Simek, Michal <michal.simek@amd.com>; Andrzej Hajda
> <andrzej.hajda@intel.com>; Neil Armstrong <neil.armstrong@linaro.org>; Ro=
bert
> Foss <rfoss@kernel.org>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec
> <jernej.skrabec@gmail.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Mauro Carvalho Chehab <mchehab@kernel.org>; Tomi
> Valkeinen <tomi.valkeinen@ideasonboard.com>; dri-devel@lists.freedesktop.=
org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linux-media@vger.kernel.org
> Subject: Re: [PATCH v3 7/9] drm/atomic-helper: Add select_output_bus_form=
at
> callback
>=20
> On Thu, Mar 21, 2024 at 01:43:45PM -0700, Anatoliy Klymenko wrote:
> > diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> > b/drivers/gpu/drm/drm_crtc_helper.c
> > index 2dafc39a27cb..f2e12a3c4e5f 100644
> > --- a/drivers/gpu/drm/drm_crtc_helper.c
> > +++ b/drivers/gpu/drm/drm_crtc_helper.c
> > @@ -1055,3 +1055,39 @@ int drm_helper_force_disable_all(struct
> drm_device *dev)
> >  	return ret;
> >  }
> >  EXPORT_SYMBOL(drm_helper_force_disable_all);
> > +
> > +/**
> > + * drm_helper_crtc_select_output_bus_format - Select output media bus
> > +format
> > + * @crtc: The CRTC to query
> > + * @crtc_state: The new CRTC state
> > + * @supported_fmts: List of media bus format options to pick from
> > + * @num_supported_fmts: Number of media bus formats in
> > +@supported_fmts list
> > + *
> > + * Encoder drivers may call this helper to give the connected CRTC a
> > +chance to
> > + * select compatible or preffered media bus format to use over the
> > +CRTC encoder
> > + * link. Encoders should provide list of supported input
> > +MEDIA_BUS_FMT_* for
> > + * CRTC to pick from. CRTC driver is expected to select preferred
> > +media bus
> > + * format from the list and, once enabled, generate the signal accordi=
ngly.
> > + *
> > + * Returns:
> > + * Selected preferred media bus format or 0 if CRTC does not support
> > +any from
> > + * @supported_fmts list.
> > + */
> > +u32 drm_helper_crtc_select_output_bus_format(struct drm_crtc *crtc,
> > +					     struct drm_crtc_state *crtc_state,
> > +					     const u32 *supported_fmts,
> > +					     unsigned int num_supported_fmts) {
> > +	if (!crtc || !supported_fmts || !num_supported_fmts)
> > +		return 0;
> > +
> > +	if (!crtc->helper_private ||
> > +	    !crtc->helper_private->select_output_bus_format)
> > +		return supported_fmts[0];
> > +
> > +	return crtc->helper_private->select_output_bus_format(crtc,
> > +							crtc_state,
> > +							supported_fmts,
> > +							num_supported_fmts);
> > +}
>=20
> Again, the output of that selection must be found in the CRTC state, othe=
rwise
> CRTCs have no way to know which have been selected.
>=20

Yes, now I got it - thank you. I'll fix this in the next version.

> Maxime

Thank you,
Anatoliy