Received-SPF: pass (google.com: domain of linux-kernel+bounces-112041-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Fri, 22 Mar 2024 14:41:30 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 3/4] x86/topology: Handle the !APIC case gracefully
Message-ID: <69c8e34b-1297-47fe-8f24-b74bf82714b1@roeck-us.net>
References: <20240322184944.141421692@linutronix.de>
 <20240322185305.242709302@linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240322185305.242709302@linutronix.de>

On Fri, Mar 22, 2024 at 07:56:38PM +0100, Thomas Gleixner wrote:
> If there is no local APIC enumerated and registered then the topology
> bitmaps are empty. Therefore topology_init_possible_cpus() will die with a
> division by zero exception.
> 
> Prevent this by registering a fake APIC id to populate the topology
> bitmap. This also allows to use all topology query interfaces
> unconditionally. It does not affect the actual APIC code because either the
> local APIC address was not registered or no local APIC could be detected.
> 
> Fixes: f1f758a80516 ("x86/topology: Add a mechanism to track topology via APIC IDs")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter